From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v10 0/9] Add the I3C subsystem Date: Sun, 11 Nov 2018 11:10:20 -0800 Message-ID: <20181111191020.GA21003@kroah.com> References: <20181026144333.12276-1-boris.brezillon@bootlin.com> <20181111173932.GA12254@kroah.com> <20181111191017.7b2efdf1@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181111191017.7b2efdf1@bbrezillon> Sender: linux-kernel-owner@vger.kernel.org To: Boris Brezillon Cc: Wolfram Sang , linux-i2c@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Arnd Bergmann , Przemyslaw Sroka , Arkadiusz Golec , Alan Douglas , Bartosz Folta , Damian Kos , Alicja Jurasik-Urbaniak , Cyprian Wronka , Suresh Punnoose , Rafal Ciepiela , Thomas Petazzoni , Nishanth Menon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala devi List-Id: linux-gpio@vger.kernel.org On Sun, Nov 11, 2018 at 07:10:17PM +0100, Boris Brezillon wrote: > Hi Greg, > > On Sun, 11 Nov 2018 09:39:32 -0800 > Greg Kroah-Hartman wrote: > > > On Fri, Oct 26, 2018 at 04:43:24PM +0200, Boris Brezillon wrote: > > > Hi Greg, > > > > > > I think we've reached a point where we can eventually consider the I3C > > > framework for inclusion in 4.20 (5.0?). A few more issues were reported > > > on v9 and fixed in v10. I can't guarantee that the implementation is > > > free of bugs but I still think it's worth merging it in v4.20: it's a > > > new subsystem, so we don't risk regressions, and the only way we can > > > detect other issues is by having other people experiment with this > > > implementation. > > > > > > The only remaining concern raised by Arnd is the fact that both hosts > > > and slaves share the same bus type and are differentiated thanks to > > > their device_type, which IMHO is fine since this is what other > > > subsystems do (plus I don't see other solutions to have both I3C > > > devices and I3C buses represented under /sys/bus/i3c/). > > > > Yeah, it's not the nicest, but it will work, we did it also for USB and > > greybus and it solves the issue. > > > > This all looks good to me, so I've queued it up. Let's see if > > linux-next has any problems with it. > > I recently asked Stephen to add the linux-i3c tree to linux-next, so > I'm expecting conflicts :-/. Sorry, I didn't know you were planning to > take these patches through your tree. > > BTW, I also fixed a couple of things when rebasing on top of 4.20-rc1: > > - KernelVersion in the sysfs ABI doc has been updated to 5.0 There is no 5.0 yet :) > - Fixed i3c_master_getmxds_locked() (bug reported/fixed by Colin here > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1799850.html) > - Removed a blank line at the end of master-driver-api.rst > > For the record, the i3c/next branch pulled by Stephen is available here > [1]. > > > Thanks for sticking with it, nice work! > > Thanks for reviewing it! Greg, Stephen, let me know if you want me to > reset i3c/next to v4.20-rc1 to avoid conflicts in linux-next. So do you want me to just drop these patches from my tree? If so, I can, but i have no problem sending these to Linus for the next -rc1 merge window through my tree if that is easier. It's up to you. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FBFCC43441 for ; Sun, 11 Nov 2018 19:10:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0B3B214F1 for ; Sun, 11 Nov 2018 19:10:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="x6TeAeK5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0B3B214F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729498AbeKLE7n (ORCPT ); Sun, 11 Nov 2018 23:59:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:42852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729426AbeKLE7m (ORCPT ); Sun, 11 Nov 2018 23:59:42 -0500 Received: from localhost (unknown [206.108.79.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5A9A820871; Sun, 11 Nov 2018 19:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541963421; bh=SwDuDn02uSZBfKW/4peMSUJV4aPW8r7+hgyovSsrCng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x6TeAeK5CxGIthfq8GbobFcjQcyPKEWyn1Lj30co582o4cXv7T80r4GQwbwuwmCdu U2+tLujYDvHiqbtwO8xY77FIvIzJYKBCSsp8hiVa2G8saYbreBJFhozO+S+gqri/1A +CFFdDwW+dmy06ANRa+w8DIs7O4NYDo6PQLuqDt4= Date: Sun, 11 Nov 2018 11:10:20 -0800 From: Greg Kroah-Hartman To: Boris Brezillon Cc: Wolfram Sang , linux-i2c@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Arnd Bergmann , Przemyslaw Sroka , Arkadiusz Golec , Alan Douglas , Bartosz Folta , Damian Kos , Alicja Jurasik-Urbaniak , Cyprian Wronka , Suresh Punnoose , Rafal Ciepiela , Thomas Petazzoni , Nishanth Menon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vitor Soares , Geert Uytterhoeven , Linus Walleij , Xiang Lin , linux-gpio@vger.kernel.org, Sekhar Nori , Przemyslaw Gaj , Peter Rosin , Mike Shettel , Stephen Boyd , Stephen Rothwell Subject: Re: [PATCH v10 0/9] Add the I3C subsystem Message-ID: <20181111191020.GA21003@kroah.com> References: <20181026144333.12276-1-boris.brezillon@bootlin.com> <20181111173932.GA12254@kroah.com> <20181111191017.7b2efdf1@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181111191017.7b2efdf1@bbrezillon> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 11, 2018 at 07:10:17PM +0100, Boris Brezillon wrote: > Hi Greg, > > On Sun, 11 Nov 2018 09:39:32 -0800 > Greg Kroah-Hartman wrote: > > > On Fri, Oct 26, 2018 at 04:43:24PM +0200, Boris Brezillon wrote: > > > Hi Greg, > > > > > > I think we've reached a point where we can eventually consider the I3C > > > framework for inclusion in 4.20 (5.0?). A few more issues were reported > > > on v9 and fixed in v10. I can't guarantee that the implementation is > > > free of bugs but I still think it's worth merging it in v4.20: it's a > > > new subsystem, so we don't risk regressions, and the only way we can > > > detect other issues is by having other people experiment with this > > > implementation. > > > > > > The only remaining concern raised by Arnd is the fact that both hosts > > > and slaves share the same bus type and are differentiated thanks to > > > their device_type, which IMHO is fine since this is what other > > > subsystems do (plus I don't see other solutions to have both I3C > > > devices and I3C buses represented under /sys/bus/i3c/). > > > > Yeah, it's not the nicest, but it will work, we did it also for USB and > > greybus and it solves the issue. > > > > This all looks good to me, so I've queued it up. Let's see if > > linux-next has any problems with it. > > I recently asked Stephen to add the linux-i3c tree to linux-next, so > I'm expecting conflicts :-/. Sorry, I didn't know you were planning to > take these patches through your tree. > > BTW, I also fixed a couple of things when rebasing on top of 4.20-rc1: > > - KernelVersion in the sysfs ABI doc has been updated to 5.0 There is no 5.0 yet :) > - Fixed i3c_master_getmxds_locked() (bug reported/fixed by Colin here > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1799850.html) > - Removed a blank line at the end of master-driver-api.rst > > For the record, the i3c/next branch pulled by Stephen is available here > [1]. > > > Thanks for sticking with it, nice work! > > Thanks for reviewing it! Greg, Stephen, let me know if you want me to > reset i3c/next to v4.20-rc1 to avoid conflicts in linux-next. So do you want me to just drop these patches from my tree? If so, I can, but i have no problem sending these to Linus for the next -rc1 merge window through my tree if that is easier. It's up to you. greg k-h