From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2692C43441 for ; Sun, 11 Nov 2018 20:51:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D9F6208A3 for ; Sun, 11 Nov 2018 20:51:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D9F6208A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727160AbeKLGla convert rfc822-to-8bit (ORCPT ); Mon, 12 Nov 2018 01:41:30 -0500 Received: from mail.bootlin.com ([62.4.15.54]:54815 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbeKLGl3 (ORCPT ); Mon, 12 Nov 2018 01:41:29 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 6351C20757; Sun, 11 Nov 2018 21:51:51 +0100 (CET) Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id C2F60206A7; Sun, 11 Nov 2018 21:51:50 +0100 (CET) Date: Sun, 11 Nov 2018 21:51:49 +0100 From: Miquel Raynal To: "Gustavo A. R. Silva" Cc: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: fsmc: Fix unchecked return value in fsmc_read_page_hwecc Message-ID: <20181111215149.72ab683e@xps13> In-Reply-To: <20181010155857.GA18860@embeddedor.com> References: <20181010155857.GA18860@embeddedor.com> Organization: Bootlin X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, "Gustavo A. R. Silva" wrote on Wed, 10 Oct 2018 17:58:58 +0200: > Check return value of nand_read_data_op. > > Notice that, currently, all instances of nand_read_data_op() are > being checked, with the exception of two of them in marvell_nand > driver, in which the caller function explicitly returns 0 every > time. > > Also, notice that I moved the declaration of *ret* to the top of > fsmc_read_page_hwecc(). > > Addresses-Coverity-ID: 1471968 ("Unchecked return value") > Signed-off-by: Gustavo A. R. Silva > --- Applied to nand/next. Thanks, Miquèl