All of
 help / color / mirror / Atom feed
From: Borislav Petkov <>
To: Ingo Molnar <>
Subject: Re: [tip:ras/core] x86/mce: Fix -Wmissing-prototypes warnings
Date: Mon, 12 Nov 2018 13:19:02 +0100	[thread overview]
Message-ID: <20181112121902.GA9953@zn.tnic> (raw)
In-Reply-To: <>

On Mon, Nov 12, 2018 at 06:24:53AM +0100, Ingo Molnar wrote:
> Nit: please use full declarations in prototypes, i.e. 'struct pt_regs 
> *regs' or so.


I'll test them some more and add them to tip:ras/core.

> Much of traps.h does this wrong so I guess this should be a separate
> cleanup patch.

See below.

Btw, do you remember why do_page_fault()'s error_code is "unsigned long"
vs all the others which are only "long" type?

Because the error code pushed by the hardware is only a couple of (least
significant) bits. 5 to be exact + there's bit 15 which is new for SGX.
But all that should still fit in a long.


diff --git a/arch/x86/include/asm/traps.h b/arch/x86/include/asm/traps.h
index afbc87206886..877afdedbbc5 100644
--- a/arch/x86/include/asm/traps.h
+++ b/arch/x86/include/asm/traps.h
@@ -61,34 +61,34 @@ asmlinkage void xen_machine_check(void);
 asmlinkage void xen_simd_coprocessor_error(void);
-dotraplinkage void do_divide_error(struct pt_regs *, long);
-dotraplinkage void do_debug(struct pt_regs *, long);
-dotraplinkage void do_nmi(struct pt_regs *, long);
-dotraplinkage void do_int3(struct pt_regs *, long);
-dotraplinkage void do_overflow(struct pt_regs *, long);
-dotraplinkage void do_bounds(struct pt_regs *, long);
-dotraplinkage void do_invalid_op(struct pt_regs *, long);
-dotraplinkage void do_device_not_available(struct pt_regs *, long);
-dotraplinkage void do_coprocessor_segment_overrun(struct pt_regs *, long);
-dotraplinkage void do_invalid_TSS(struct pt_regs *, long);
-dotraplinkage void do_segment_not_present(struct pt_regs *, long);
-dotraplinkage void do_stack_segment(struct pt_regs *, long);
+dotraplinkage void do_divide_error(struct pt_regs *regs, long error_code);
+dotraplinkage void do_debug(struct pt_regs *regs, long error_code);
+dotraplinkage void do_nmi(struct pt_regs *regs, long error_code);
+dotraplinkage void do_int3(struct pt_regs *regs, long error_code);
+dotraplinkage void do_overflow(struct pt_regs *regs, long error_code);
+dotraplinkage void do_bounds(struct pt_regs *regs, long error_code);
+dotraplinkage void do_invalid_op(struct pt_regs *regs, long error_code);
+dotraplinkage void do_device_not_available(struct pt_regs *regs, long error_code);
+dotraplinkage void do_coprocessor_segment_overrun(struct pt_regs *regs, long error_code);
+dotraplinkage void do_invalid_TSS(struct pt_regs *regs, long error_code);
+dotraplinkage void do_segment_not_present(struct pt_regs *regs, long error_code);
+dotraplinkage void do_stack_segment(struct pt_regs *regs, long error_code);
 #ifdef CONFIG_X86_64
-dotraplinkage void do_double_fault(struct pt_regs *, long);
+dotraplinkage void do_double_fault(struct pt_regs *regs, long error_code);
-dotraplinkage void do_general_protection(struct pt_regs *, long);
-dotraplinkage void do_page_fault(struct pt_regs *, unsigned long);
-dotraplinkage void do_spurious_interrupt_bug(struct pt_regs *, long);
-dotraplinkage void do_coprocessor_error(struct pt_regs *, long);
-dotraplinkage void do_alignment_check(struct pt_regs *, long);
+dotraplinkage void do_general_protection(struct pt_regs *regs, long error_code);
+dotraplinkage void do_page_fault(struct pt_regs *regs, unsigned long error_code);
+dotraplinkage void do_spurious_interrupt_bug(struct pt_regs *regs, long error_code);
+dotraplinkage void do_coprocessor_error(struct pt_regs *regs, long error_code);
+dotraplinkage void do_alignment_check(struct pt_regs *regs, long error_code);
 #ifdef CONFIG_X86_MCE
-dotraplinkage void do_machine_check(struct pt_regs *, long);
+dotraplinkage void do_machine_check(struct pt_regs *regs, long error_code);
-dotraplinkage void do_simd_coprocessor_error(struct pt_regs *, long);
+dotraplinkage void do_simd_coprocessor_error(struct pt_regs *regs, long error_code);
 #ifdef CONFIG_X86_32
-dotraplinkage void do_iret_error(struct pt_regs *, long);
+dotraplinkage void do_iret_error(struct pt_regs *regs, long error_code);
-dotraplinkage void do_mce(struct pt_regs *, long);
+dotraplinkage void do_mce(struct pt_regs *regs, long error_code);
 static inline int get_si_code(unsigned long condition)


SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

  reply	other threads:[~2018-11-12 12:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08  1:12 [PATCH v2] x86/cpu: fix prototype warning Yi Wang
2018-11-08 15:03 ` Borislav Petkov
2018-11-08 15:32   ` Borislav Petkov
2018-11-08 15:35     ` Thomas Gleixner
2018-11-08 15:41       ` Borislav Petkov
2018-11-09 16:07       ` David Laight
2018-11-10 10:51       ` [tip:ras/core] x86/mce: Fix -Wmissing-prototypes warnings tip-bot for Borislav Petkov
2018-11-10 14:16         ` Borislav Petkov
2018-11-12  5:24           ` Ingo Molnar
2018-11-12 12:19             ` Borislav Petkov [this message]
2018-11-13 14:22           ` [tip:x86/cleanups] x86/traps: Complete prototype declarations tip-bot for Borislav Petkov
2018-11-14 13:19           ` tip-bot for Borislav Petkov
2018-11-13 14:21       ` [tip:x86/cleanups] x86/mce: Fix -Wmissing-prototypes warnings tip-bot for Borislav Petkov
2018-11-14 13:18       ` tip-bot for Borislav Petkov
2018-11-08 15:47     ` [PATCH v2] x86/cpu: fix prototype warning Michael Matz
2018-11-08 17:22       ` Borislav Petkov
     [not found]         ` <>
2018-11-09 10:55           ` Borislav Petkov
2018-11-09 11:12             ` Greg KH
2018-11-09 11:41               ` Borislav Petkov
2018-11-09 12:25                 ` Greg KH
2018-11-09 22:17       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181112121902.GA9953@zn.tnic \ \ \ \ \ \ \ \ \
    --subject='Re: [tip:ras/core] x86/mce: Fix -Wmissing-prototypes warnings' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.