From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list
Date: Mon, 12 Nov 2018 16:17:16 +0100 [thread overview]
Message-ID: <20181112151716.j35hs224xqww3zdq@mac.citrite.net> (raw)
In-Reply-To: <5BE9987802000078001FB0D1@prv1-mh.provo.novell.com>
On Mon, Nov 12, 2018 at 08:12:56AM -0700, Jan Beulich wrote:
> >>> On 12.11.18 at 16:00, <roger.pau@citrix.com> wrote:
> > Yes, it's only the module list that's passed by physical address and
> > then mapped using __va. How about the following description:
> >
> > "When booting Xen as a PVH guest the data in the PVH start info
> > structure is copied over to a multiboot structure and a module list
> > array that resides in the .init section of the Xen image. The
> > resulting multiboot module list is then handed to the generic boot
> > process using the physical address in mbi->mods_addr.
> >
> > This works fine as long as the Xen image doesn't relocate itself, if
> > there's such a relocation the physical addresses of multiboot module
> > list is no longer valid.
> >
> > Fix this by handing the virtual address of the module list to the
> > generic boot process instead of it's physical address."
>
> Sounds fine. But didn't Sergey spot two regions that were not
> taken care of? Or is the other part dealt with in patch 2?
IIRC the other one was the module(s) command line, which are relocated
in the low 1MB by pvh_info_reloc which should be fixed by patch #2.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-12 15:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 17:22 [PATCH 0/2] guest/pvh: fixes for idle memory scrubbing Roger Pau Monne
2018-11-09 17:22 ` [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list Roger Pau Monne
2018-11-09 17:54 ` [PATCH v2 " Roger Pau Monne
2018-11-12 10:28 ` [PATCH " Jan Beulich
2018-11-12 11:49 ` Roger Pau Monné
2018-11-12 12:40 ` Jan Beulich
2018-11-12 15:00 ` Roger Pau Monné
2018-11-12 15:12 ` Jan Beulich
2018-11-12 15:17 ` Roger Pau Monné [this message]
2018-11-12 15:54 ` Wei Liu
2018-11-09 17:22 ` [PATCH 2/2] guest/pvh: special case the low 1MB Roger Pau Monne
2018-11-12 10:31 ` Jan Beulich
2018-11-12 15:54 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112151716.j35hs224xqww3zdq@mac.citrite.net \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.