Re: [PATCH v5 11/15] libxl_dm: Pre-open QMP socket for QEMU

[Anthony PERARD <anthony.perard@citrix.com>]

On Mon, Nov 12, 2018 at 03:14:30PM +0000, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [PATCH v5 11/15] libxl_dm: Pre-open QMP socket for QEMU"):
> > On Tue, Oct 16, 2018 at 03:11:03PM +0100, Ian Jackson wrote:
> > > Anthony PERARD writes ("[PATCH v5 11/15] libxl_dm: Pre-open QMP socket for QEMU"):
> > > >      ret = libxl__build_device_model_args(gc, "stubdom-dm", guest_domid,
> > > >                                           guest_config, &args, NULL,
> > > > -                                         d_state, NULL);
> > > > +                                         d_state, NULL, NULL);
> > > 
> > > Did you consider adding dm_monitor_fd to d_state ?
> > 
> > No, I didn't, I'm not sur what can go into d_state. But that seems
> > better that adding an argument to many function prototypes.
> 
> I think pretty much anything to do with creating a domain can go in
> there.
> 
> > On the other hand, I would need to make sure that dm_monitor_fd have a
> > proper initial value (-1) when needed.
> 
> Yes, it would have to be initialised along with the other members of
> libxl__domain_build_state.

I didn't manage to findout where this might be. There is
libxl__build_pre() but I don't know if it's always called. Is this the
right place, or is it initialised somewhere else?

Also, now I would probably need to call libxl__pre_open_qmp_socket()
from libxl__spawn_local_dm() as the d_state (libxl_domain_build_info) is
const when passed to libxl__build_device_model_args. But that is
probably fine.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel