From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Mon, 12 Nov 2018 16:51:51 +0100 Subject: [U-Boot] [PATCH v2 1/5] mtd: Use default mtdparts/mtids when not defined in the environment In-Reply-To: References: <20181112082809.7035-1-boris.brezillon@bootlin.com> Message-ID: <20181112165151.7033da7a@bbrezillon> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 12 Nov 2018 15:55:18 +0530 Jagan Teki wrote: > On Mon, Nov 12, 2018 at 1:58 PM Boris Brezillon > wrote: > > > > U-boot provides a mean to define default values for mtdids and mtdparts > > when they're not defined in the environment. Patch mtd_probe_devices() > > to use those default values when env_get("mtdparts") or > > env_get("mtdids") return NULL. > > > > This implementation is based on the logic found in cmd/mtdparts.c. > > > > Fixes: 5db66b3aee6f ("cmd: mtd: add 'mtd' command") > > Reported-by: Stefan Roese > > Signed-off-by: Boris Brezillon > > Tested-by: Stefan Roese > > --- > > Changes in v2: > > - none > > Trigger travis-ci [1], will send v2 PR once all built fine. > > [1] https://travis-ci.org/openedev/u-boot-amarula/builds Looks like mine is all green [1] ;-). And yes, now I have travis-ci set up to track my u-boot repo, so hopefully I won't end up submitting patches that regress the tests described in .travis.yaml in the future. Still, I'd like to insist on that this test result shouldn't replace human review, which I think is still valuable to spot subtle issues. Also, I'd like to point that some of the failures caused by the spi-nand patchset are actually coming from the weird way MTD related config options are selected/defined in u-boot. This should probably be simplified somehow, but that's a different story. [1]https://travis-ci.org/bbrezillon/u-boot