From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FAAC43441 for ; Mon, 12 Nov 2018 22:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9FE92241E for ; Mon, 12 Nov 2018 22:47:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=metanate.com header.i=@metanate.com header.b="dwh9KMrq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9FE92241E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=metanate.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727839AbeKMIlz (ORCPT ); Tue, 13 Nov 2018 03:41:55 -0500 Received: from dougal.metanate.com ([90.155.101.14]:52670 "EHLO metanate.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725941AbeKMIlz (ORCPT ); Tue, 13 Nov 2018 03:41:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=metanate.com; s=stronger; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References :In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iTbZWpmbkXW8RsCR7CWjNpkWavPMv9tzkREOuPI6cfE=; b=dwh9KMrqY1AdabxAyVVvptorUy S1t2hIzOV53fycNGxdaym60YvxcsFV1gkLfCnLua6dZfOkP2kR5nGjRBixgBLPWE/05HzvdqNiW96 O0PsHShmZFYkQt4uLnDDwQsQ8rd2LimX+0zXKcFrK/74rd/vBDbaiy7krO+HELh+F6LnyvKunGKKZ QdPMcA3wEJb55oc+YzEMl9fyL8Gp043Oie0L+RUxknK9d/xVC9tVWhvVwC03j7waR/sUEz4sPoztb QMY82Y/hCqIj2ogBHh/1sKVd2CDY6m2AWilBxXivVQbFlzVfIsTwBUkr2pqYnSeNm6fBAWMdnDdW+ REPHLnfw==; Received: from johnkeeping.plus.com ([81.174.171.191] helo=donbot) by shrek.metanate.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gMKyX-00017n-MR; Mon, 12 Nov 2018 22:46:33 +0000 Date: Mon, 12 Nov 2018 22:46:26 +0000 From: John Keeping To: Minas Harutyunyan Cc: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "arthur.petrosyan@synopsys.com" Subject: Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling Message-ID: <20181112224626.6b44568a@donbot> In-Reply-To: <410670D7E743164D87FA6160E7907A56013A7A27D7@am04wembxa.internal.synopsys.com> References: <20181023134355.29829-1-john@metanate.com> <410670D7E743164D87FA6160E7907A56013A79E7CE@am04wembxa.internal.synopsys.com> <20181108173654.118f9e3e@donbot> <410670D7E743164D87FA6160E7907A56013A7A0F2B@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A56013A7A12C1@am04wembxa.internal.synopsys.com> <20181109184246.33cb4487@donbot> <410670D7E743164D87FA6160E7907A56013A7A27D7@am04wembxa.internal.synopsys.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Minas, On Mon, 12 Nov 2018 08:53:36 +0000 Minas Harutyunyan wrote: > On 11/9/2018 10:43 PM, John Keeping wrote: > > On Fri, 9 Nov 2018 14:36:36 +0000 > > Minas Harutyunyan wrote: > > > >> On 11/9/2018 12:43 PM, Minas Harutyunyan wrote: > >>> Hi John, > >>> > >>> On 11/8/2018 9:37 PM, John Keeping wrote: > >>>> Hi Minas, > >>>> > >>>> On Mon, 5 Nov 2018 08:28:07 +0000 > >>>> Minas Harutyunyan wrote: > >>>> > >>>>> On 10/23/2018 5:43 PM, John Keeping wrote: > >>>>>> By clearing the overrun flag as soon as the target frame is > >>>>>> next incremented, we can end up incrementing the target frame > >>>>>> more than expected in dwc2_gadget_handle_ep_disabled() when the > >>>>>> endpoint's interval is greater than 1. This happens if the > >>>>>> target frame has just wrapped at the point when the endpoint is > >>>>>> disabled and the frame number has not yet done so. > >>>>>> > >>>>>> Instead, wait until the frame number also wraps and then clear > >>>>>> the overrun flag. > >>>>>> > >>>>>> Signed-off-by: John Keeping > >>>>>> --- > >>>>>> drivers/usb/dwc2/gadget.c | 2 +- > >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>>> > >>>>>> diff --git a/drivers/usb/dwc2/gadget.c > >>>>>> b/drivers/usb/dwc2/gadget.c index 2d6d2c8244de..8da2c052dfa1 > >>>>>> 100644 --- a/drivers/usb/dwc2/gadget.c > >>>>>> +++ b/drivers/usb/dwc2/gadget.c > >>>>>> @@ -117,7 +117,7 @@ static inline void > >>>>>> dwc2_gadget_incr_frame_num(struct dwc2_hsotg_ep *hs_ep) if > >>>>>> (hs_ep->target_frame > DSTS_SOFFN_LIMIT) > >>>>>> { hs_ep->frame_overrun = true; hs_ep->target_frame &= > >>>>>> DSTS_SOFFN_LIMIT; > >>>>>> - } else { > >>>>>> + } else if (hs_ep->parent->frame_number < > >>>>>> hs_ep->target_frame) { hs_ep->frame_overrun = false; > >>>>>> } > >>>>>> } > >>>>>> > >>>>> Did you tested mentioned by you scenario? If you see issue can > >>>>> you provide debug log and point the issue line in the log. > >>>> > >>>> It only reproduces very occasionally so it's difficult to capture > >>>> a full debug log containing the error. > >>>> > >>>> I applied this patch to capture logging specifically around this > >>>> scenario: > >>>> > >>>> -- >8 -- > >>>> diff --git a/drivers/usb/dwc2/gadget.c > >>>> b/drivers/usb/dwc2/gadget.c index 220c0f9b89b0..3770b9d3b523 > >>>> 100644 --- a/drivers/usb/dwc2/gadget.c > >>>> +++ b/drivers/usb/dwc2/gadget.c > >>>> @@ -2722,13 +2722,20 @@ static void > >>>> dwc2_gadget_handle_ep_disabled(struct dwc2_hsotg_ep *hs_ep) } > >>>> > >>>> do { > >>>> + unsigned int target_frame = hs_ep->target_frame; > >>>> + bool frame_overrun = hs_ep->frame_overrun; > >>>> + > >>>> hs_req = get_ep_head(hs_ep); > >>>> if (hs_req) > >>>> dwc2_hsotg_complete_request(hsotg, > >>>> hs_ep, hs_req, -ENODATA); > >>>> + > >>>> dwc2_gadget_incr_frame_num(hs_ep); > >>>> /* Update current frame number value. */ > >>>> hsotg->frame_number = > >>>> dwc2_hsotg_read_frameno(hsotg); + > >>>> + dev_warn(hsotg->dev, "%s: expiring request > >>>> frame_number=0x%04x target_frame=0x%04x overrun=%u\n", > >>>> + __func__, hsotg->frame_number, > >>>> target_frame, frame_overrun); } while > >>>> (dwc2_gadget_target_frame_elapsed(hs_ep)); > >>>> dwc2_gadget_start_next_request(hs_ep); > >>>> -- 8< -- > >>>> > >>> According above patch in debug log should be printed overrun flag > >>> also. Could you please resend log with this flag. > > > > D'oh! I included a log from an earlier version before I added the > > overrun flag. > > > >> One more request. Please add EP number to debug print. > > > > Here's an updated log: > > > > -- >8 -- > > [ 264.926385] dwc2 ff580000.usb: dwc2_gadget_handle_ep_disabled: > > expiring request ep=2 frame_number=0x2161 target_frame=0x2168 > > overrun=0 [ 265.905413] dwc2 ff580000.usb: > > dwc2_gadget_handle_ep_disabled: expiring request ep=2 > > frame_number=0x3ff9 target_frame=0x0008 overrun=0 [ 265.905421] > > dwc2 ff580000.usb: dwc2_gadget_handle_ep_disabled: expiring request > > ep=2 frame_number=0x3ff9 target_frame=0x0010 overrun=0 > > [ 265.905427] dwc2 ff580000.usb: dwc2_gadget_handle_ep_disabled: > > expiring request ep=2 frame_number=0x3ff9 target_frame=0x0018 > > overrun=0 [ 265.905432] dwc2 ff580000.usb: > > dwc2_gadget_handle_ep_disabled: expiring request ep=2 > > frame_number=0x3ff9 target_frame=0x0020 overrun=0 [ 265.905438] > > dwc2 ff580000.usb: dwc2_gadget_handle_ep_disabled: expiring request > > ep=2 frame_number=0x3ff9 target_frame=0x0028 overrun=0 > > [ 265.905443] dwc2 ff580000.usb: dwc2_gadget_handle_ep_disabled: > > expiring request ep=2 frame_number=0x3ff9 target_frame=0x0030 > > overrun=0 [ 265.905448] dwc2 ff580000.usb: > > dwc2_gadget_handle_ep_disabled: expiring request ep=2 > > frame_number=0x3ff9 target_frame=0x0038 overrun=0 [ 265.905454] > > dwc2 ff580000.usb: dwc2_gadget_handle_ep_disabled: expiring request > > ep=2 frame_number=0x3ff9 target_frame=0x0040 overrun=0 > > [ 265.905459] dwc2 ff580000.usb: dwc2_gadget_handle_ep_disabled: > > expiring request ep=2 frame_number=0x3ff9 target_frame=0x0048 > > overrun=0 -- 8< -- > > > > Once again there is an initial failure before it enters the failure > > mode my patch is trying to address. This seems to be consistent, > > so it may be important, but there is ~80ms before the failure > > starts. > >>>> This was on v4.19 with an additional patch to disable descriptor > >>>> DMA because that seems to be causing problems on RK3288 although > >>>> I haven't figured out exactly why it's a problem. > >>> > >>> In which mode you run tests Slave or Buffer DMA? > > > > Buffer DMA but with descriptor DMA forced off (g_dma=1, > > g_dma_desc=0). > > > > For the record, my test case is the standard UAC2 gadget with: > > > > c_srate = p_srate = 44100 > > c_ssize = p_ssize = 4 > > c_chmask = 0xf > > p_chmask = 3 > > > > and it seems that the failure only triggers when using arecord to > > capture from the gadget interface (this is with a host program both > > streaming in both directions over the USB connection); I suspect > > that actually it just makes it more likely because there is more > > work done in the completion handler, but I haven't seen the failure > > without arecord running. > > > > > > Regards, > > John > > > I think cause of issue not in dwc2_gadget_target_frame_elapsed() > function, but in do-while loop in dwc2_gadget_handle_ep_disabled(). > Could you please try below patch: > > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c > index 8eb25e3597b0..4ad869853bfa 100644 > --- a/drivers/usb/dwc2/gadget.c > +++ b/drivers/usb/dwc2/gadget.c > @@ -2762,8 +2762,11 @@ static void > dwc2_gadget_handle_ep_disabled(struct dwc2_hsotg_ep *hs_ep) > > do { > hs_req = get_ep_head(hs_ep); > - if (hs_req) > - dwc2_hsotg_complete_request(hsotg, hs_ep, > hs_req, > + if (!hs_req) { > + dev_warn(hsotg->dev, "%s: ISOC EP queue > empty\n", __func__); > + return; > + } > + dwc2_hsotg_complete_request(hsotg, hs_ep, hs_req, > -ENODATA); > dwc2_gadget_incr_frame_num(hs_ep); > /* Update current frame number value. */ I don't see any difference after applying this patch, and the new dev_warn message does not appear. I think what happens is that dwc2_hsotg_complete_request() completes the outstanding request and the completion handler (in this case u_audio_iso_complete) enqueues a new request, so the queue is never empty. Regards, John From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc2: gadget: fix ISOC frame overflow handling From: John Keeping Message-Id: <20181112224626.6b44568a@donbot> Date: Mon, 12 Nov 2018 22:46:26 +0000 To: Minas Harutyunyan Cc: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "arthur.petrosyan@synopsys.com" List-ID: SGkgTWluYXMsCgpPbiBNb24sIDEyIE5vdiAyMDE4IDA4OjUzOjM2ICswMDAwCk1pbmFzIEhhcnV0 eXVueWFuIDxtaW5hcy5oYXJ1dHl1bnlhbkBzeW5vcHN5cy5jb20+IHdyb3RlOgo+IE9uIDExLzkv MjAxOCAxMDo0MyBQTSwgSm9obiBLZWVwaW5nIHdyb3RlOgo+ID4gT24gRnJpLCA5IE5vdiAyMDE4 IDE0OjM2OjM2ICswMDAwCj4gPiBNaW5hcyBIYXJ1dHl1bnlhbiA8bWluYXMuaGFydXR5dW55YW5A c3lub3BzeXMuY29tPiB3cm90ZToKPiA+ICAgCj4gPj4gT24gMTEvOS8yMDE4IDEyOjQzIFBNLCBN aW5hcyBIYXJ1dHl1bnlhbiB3cm90ZTogIAo+ID4+PiBIaSBKb2huLAo+ID4+Pgo+ID4+PiBPbiAx MS84LzIwMTggOTozNyBQTSwgSm9obiBLZWVwaW5nIHdyb3RlOiAgCj4gPj4+PiBIaSBNaW5hcywK PiA+Pj4+Cj4gPj4+PiBPbiBNb24sIDUgTm92IDIwMTggMDg6Mjg6MDcgKzAwMDAKPiA+Pj4+IE1p bmFzIEhhcnV0eXVueWFuIDxtaW5hcy5oYXJ1dHl1bnlhbkBzeW5vcHN5cy5jb20+IHdyb3RlOgo+ ID4+Pj4gIAo+ID4+Pj4+IE9uIDEwLzIzLzIwMTggNTo0MyBQTSwgSm9obiBLZWVwaW5nIHdyb3Rl OiAgCj4gPj4+Pj4+IEJ5IGNsZWFyaW5nIHRoZSBvdmVycnVuIGZsYWcgYXMgc29vbiBhcyB0aGUg dGFyZ2V0IGZyYW1lIGlzCj4gPj4+Pj4+IG5leHQgaW5jcmVtZW50ZWQsIHdlIGNhbiBlbmQgdXAg aW5jcmVtZW50aW5nIHRoZSB0YXJnZXQgZnJhbWUKPiA+Pj4+Pj4gbW9yZSB0aGFuIGV4cGVjdGVk IGluIGR3YzJfZ2FkZ2V0X2hhbmRsZV9lcF9kaXNhYmxlZCgpIHdoZW4gdGhlCj4gPj4+Pj4+IGVu ZHBvaW50J3MgaW50ZXJ2YWwgaXMgZ3JlYXRlciB0aGFuIDEuICBUaGlzIGhhcHBlbnMgaWYgdGhl Cj4gPj4+Pj4+IHRhcmdldCBmcmFtZSBoYXMganVzdCB3cmFwcGVkIGF0IHRoZSBwb2ludCB3aGVu IHRoZSBlbmRwb2ludCBpcwo+ID4+Pj4+PiBkaXNhYmxlZCBhbmQgdGhlIGZyYW1lIG51bWJlciBo YXMgbm90IHlldCBkb25lIHNvLgo+ID4+Pj4+Pgo+ID4+Pj4+PiBJbnN0ZWFkLCB3YWl0IHVudGls IHRoZSBmcmFtZSBudW1iZXIgYWxzbyB3cmFwcyBhbmQgdGhlbiBjbGVhcgo+ID4+Pj4+PiB0aGUg b3ZlcnJ1biBmbGFnLgo+ID4+Pj4+Pgo+ID4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBKb2huIEtlZXBp bmcgPGpvaG5AbWV0YW5hdGUuY29tPgo+ID4+Pj4+PiAtLS0KPiA+Pj4+Pj4gICAgICBkcml2ZXJz L3VzYi9kd2MyL2dhZGdldC5jIHwgMiArLQo+ID4+Pj4+PiAgICAgIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+ID4+Pj4+Pgo+ID4+Pj4+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy91c2IvZHdjMi9nYWRnZXQuYwo+ID4+Pj4+PiBiL2RyaXZlcnMvdXNiL2R3YzIv Z2FkZ2V0LmMgaW5kZXggMmQ2ZDJjODI0NGRlLi44ZGEyYzA1MmRmYTEKPiA+Pj4+Pj4gMTAwNjQ0 IC0tLSBhL2RyaXZlcnMvdXNiL2R3YzIvZ2FkZ2V0LmMKPiA+Pj4+Pj4gKysrIGIvZHJpdmVycy91 c2IvZHdjMi9nYWRnZXQuYwo+ID4+Pj4+PiBAQCAtMTE3LDcgKzExNyw3IEBAIHN0YXRpYyBpbmxp bmUgdm9pZAo+ID4+Pj4+PiBkd2MyX2dhZGdldF9pbmNyX2ZyYW1lX251bShzdHJ1Y3QgZHdjMl9o c290Z19lcCAqaHNfZXApIGlmCj4gPj4+Pj4+IChoc19lcC0+dGFyZ2V0X2ZyYW1lID4gRFNUU19T T0ZGTl9MSU1JVCkKPiA+Pj4+Pj4geyBoc19lcC0+ZnJhbWVfb3ZlcnJ1biA9IHRydWU7IGhzX2Vw LT50YXJnZXRfZnJhbWUgJj0KPiA+Pj4+Pj4gRFNUU19TT0ZGTl9MSU1JVDsKPiA+Pj4+Pj4gLQl9 IGVsc2Ugewo+ID4+Pj4+PiArCX0gZWxzZSBpZiAoaHNfZXAtPnBhcmVudC0+ZnJhbWVfbnVtYmVy IDwKPiA+Pj4+Pj4gaHNfZXAtPnRhcmdldF9mcmFtZSkgeyBoc19lcC0+ZnJhbWVfb3ZlcnJ1biA9 IGZhbHNlOwo+ID4+Pj4+PiAgICAgIAl9Cj4gPj4+Pj4+ICAgICAgfQo+ID4+Pj4+PiAgICAgICAg Cj4gPj4+Pj4gRGlkIHlvdSB0ZXN0ZWQgbWVudGlvbmVkIGJ5IHlvdSBzY2VuYXJpbz8gSWYgeW91 IHNlZSBpc3N1ZSBjYW4KPiA+Pj4+PiB5b3UgcHJvdmlkZSBkZWJ1ZyBsb2cgYW5kIHBvaW50IHRo ZSBpc3N1ZSBsaW5lIGluIHRoZSBsb2cuICAKPiA+Pj4+Cj4gPj4+PiBJdCBvbmx5IHJlcHJvZHVj ZXMgdmVyeSBvY2Nhc2lvbmFsbHkgc28gaXQncyBkaWZmaWN1bHQgdG8gY2FwdHVyZQo+ID4+Pj4g YSBmdWxsIGRlYnVnIGxvZyBjb250YWluaW5nIHRoZSBlcnJvci4KPiA+Pj4+Cj4gPj4+PiBJIGFw cGxpZWQgdGhpcyBwYXRjaCB0byBjYXB0dXJlIGxvZ2dpbmcgc3BlY2lmaWNhbGx5IGFyb3VuZCB0 aGlzCj4gPj4+PiBzY2VuYXJpbzoKPiA+Pj4+ICAKPiA+Pj4+IC0tID44IC0tICAKPiA+Pj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9kd2MyL2dhZGdldC5jCj4gPj4+PiBiL2RyaXZlcnMvdXNi L2R3YzIvZ2FkZ2V0LmMgaW5kZXggMjIwYzBmOWI4OWIwLi4zNzcwYjlkM2I1MjMKPiA+Pj4+IDEw MDY0NCAtLS0gYS9kcml2ZXJzL3VzYi9kd2MyL2dhZGdldC5jCj4gPj4+PiArKysgYi9kcml2ZXJz L3VzYi9kd2MyL2dhZGdldC5jCj4gPj4+PiBAQCAtMjcyMiwxMyArMjcyMiwyMCBAQCBzdGF0aWMg dm9pZAo+ID4+Pj4gZHdjMl9nYWRnZXRfaGFuZGxlX2VwX2Rpc2FibGVkKHN0cnVjdCBkd2MyX2hz b3RnX2VwICpoc19lcCkgfQo+ID4+Pj4gICAgIAo+ID4+Pj4gICAgICAgICAgICBkbyB7Cj4gPj4+ PiArICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHRhcmdldF9mcmFtZSA9IGhzX2VwLT50YXJn ZXRfZnJhbWU7Cj4gPj4+PiArICAgICAgICAgICAgICAgYm9vbCBmcmFtZV9vdmVycnVuID0gaHNf ZXAtPmZyYW1lX292ZXJydW47Cj4gPj4+PiArCj4gPj4+PiAgICAgICAgICAgICAgICAgICAgaHNf cmVxID0gZ2V0X2VwX2hlYWQoaHNfZXApOwo+ID4+Pj4gICAgICAgICAgICAgICAgICAgIGlmICho c19yZXEpCj4gPj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICBkd2MyX2hzb3RnX2NvbXBs ZXRlX3JlcXVlc3QoaHNvdGcsCj4gPj4+PiBoc19lcCwgaHNfcmVxLCAtRU5PREFUQSk7Cj4gPj4+ PiArCj4gPj4+PiAgICAgICAgICAgICAgICAgICAgZHdjMl9nYWRnZXRfaW5jcl9mcmFtZV9udW0o aHNfZXApOwo+ID4+Pj4gICAgICAgICAgICAgICAgICAgIC8qIFVwZGF0ZSBjdXJyZW50IGZyYW1l IG51bWJlciB2YWx1ZS4gKi8KPiA+Pj4+ICAgICAgICAgICAgICAgICAgICBoc290Zy0+ZnJhbWVf bnVtYmVyID0KPiA+Pj4+IGR3YzJfaHNvdGdfcmVhZF9mcmFtZW5vKGhzb3RnKTsgKwo+ID4+Pj4g KyAgICAgICAgICAgICAgIGRldl93YXJuKGhzb3RnLT5kZXYsICIlczogZXhwaXJpbmcgcmVxdWVz dAo+ID4+Pj4gZnJhbWVfbnVtYmVyPTB4JTA0eCB0YXJnZXRfZnJhbWU9MHglMDR4IG92ZXJydW49 JXVcbiIsCj4gPj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgX19mdW5jX18sIGhzb3RnLT5m cmFtZV9udW1iZXIsCj4gPj4+PiB0YXJnZXRfZnJhbWUsIGZyYW1lX292ZXJydW4pOyB9IHdoaWxl Cj4gPj4+PiAoZHdjMl9nYWRnZXRfdGFyZ2V0X2ZyYW1lX2VsYXBzZWQoaHNfZXApKTsKPiA+Pj4+ ICAgICAgICAgICAgZHdjMl9nYWRnZXRfc3RhcnRfbmV4dF9yZXF1ZXN0KGhzX2VwKTsKPiA+Pj4+ IC0tIDg8IC0tCj4gPj4+PiAgCj4gPj4+IEFjY29yZGluZyBhYm92ZSBwYXRjaCBpbiBkZWJ1ZyBs b2cgc2hvdWxkIGJlIHByaW50ZWQgb3ZlcnJ1biBmbGFnCj4gPj4+IGFsc28uIENvdWxkIHlvdSBw bGVhc2UgcmVzZW5kIGxvZyB3aXRoIHRoaXMgZmxhZy4gIAo+ID4gCj4gPiBEJ29oISAgSSBpbmNs dWRlZCBhIGxvZyBmcm9tIGFuIGVhcmxpZXIgdmVyc2lvbiBiZWZvcmUgSSBhZGRlZCB0aGUKPiA+ IG92ZXJydW4gZmxhZy4KPiA+ICAgCj4gPj4gT25lIG1vcmUgcmVxdWVzdC4gUGxlYXNlIGFkZCBF UCBudW1iZXIgdG8gZGVidWcgcHJpbnQuICAKPiA+IAo+ID4gSGVyZSdzIGFuIHVwZGF0ZWQgbG9n Ogo+ID4gICAKPiA+IC0tID44IC0tICAKPiA+IFsgIDI2NC45MjYzODVdIGR3YzIgZmY1ODAwMDAu dXNiOiBkd2MyX2dhZGdldF9oYW5kbGVfZXBfZGlzYWJsZWQ6Cj4gPiBleHBpcmluZyByZXF1ZXN0 IGVwPTIgZnJhbWVfbnVtYmVyPTB4MjE2MSB0YXJnZXRfZnJhbWU9MHgyMTY4Cj4gPiBvdmVycnVu PTAgWyAgMjY1LjkwNTQxM10gZHdjMiBmZjU4MDAwMC51c2I6Cj4gPiBkd2MyX2dhZGdldF9oYW5k bGVfZXBfZGlzYWJsZWQ6IGV4cGlyaW5nIHJlcXVlc3QgZXA9Mgo+ID4gZnJhbWVfbnVtYmVyPTB4 M2ZmOSB0YXJnZXRfZnJhbWU9MHgwMDA4IG92ZXJydW49MCBbICAyNjUuOTA1NDIxXQo+ID4gZHdj MiBmZjU4MDAwMC51c2I6IGR3YzJfZ2FkZ2V0X2hhbmRsZV9lcF9kaXNhYmxlZDogZXhwaXJpbmcg cmVxdWVzdAo+ID4gZXA9MiBmcmFtZV9udW1iZXI9MHgzZmY5IHRhcmdldF9mcmFtZT0weDAwMTAg b3ZlcnJ1bj0wCj4gPiBbICAyNjUuOTA1NDI3XSBkd2MyIGZmNTgwMDAwLnVzYjogZHdjMl9nYWRn ZXRfaGFuZGxlX2VwX2Rpc2FibGVkOgo+ID4gZXhwaXJpbmcgcmVxdWVzdCBlcD0yIGZyYW1lX251 bWJlcj0weDNmZjkgdGFyZ2V0X2ZyYW1lPTB4MDAxOAo+ID4gb3ZlcnJ1bj0wIFsgIDI2NS45MDU0 MzJdIGR3YzIgZmY1ODAwMDAudXNiOgo+ID4gZHdjMl9nYWRnZXRfaGFuZGxlX2VwX2Rpc2FibGVk OiBleHBpcmluZyByZXF1ZXN0IGVwPTIKPiA+IGZyYW1lX251bWJlcj0weDNmZjkgdGFyZ2V0X2Zy YW1lPTB4MDAyMCBvdmVycnVuPTAgWyAgMjY1LjkwNTQzOF0KPiA+IGR3YzIgZmY1ODAwMDAudXNi OiBkd2MyX2dhZGdldF9oYW5kbGVfZXBfZGlzYWJsZWQ6IGV4cGlyaW5nIHJlcXVlc3QKPiA+IGVw PTIgZnJhbWVfbnVtYmVyPTB4M2ZmOSB0YXJnZXRfZnJhbWU9MHgwMDI4IG92ZXJydW49MAo+ID4g WyAgMjY1LjkwNTQ0M10gZHdjMiBmZjU4MDAwMC51c2I6IGR3YzJfZ2FkZ2V0X2hhbmRsZV9lcF9k aXNhYmxlZDoKPiA+IGV4cGlyaW5nIHJlcXVlc3QgZXA9MiBmcmFtZV9udW1iZXI9MHgzZmY5IHRh cmdldF9mcmFtZT0weDAwMzAKPiA+IG92ZXJydW49MCBbICAyNjUuOTA1NDQ4XSBkd2MyIGZmNTgw MDAwLnVzYjoKPiA+IGR3YzJfZ2FkZ2V0X2hhbmRsZV9lcF9kaXNhYmxlZDogZXhwaXJpbmcgcmVx dWVzdCBlcD0yCj4gPiBmcmFtZV9udW1iZXI9MHgzZmY5IHRhcmdldF9mcmFtZT0weDAwMzggb3Zl cnJ1bj0wIFsgIDI2NS45MDU0NTRdCj4gPiBkd2MyIGZmNTgwMDAwLnVzYjogZHdjMl9nYWRnZXRf aGFuZGxlX2VwX2Rpc2FibGVkOiBleHBpcmluZyByZXF1ZXN0Cj4gPiBlcD0yIGZyYW1lX251bWJl cj0weDNmZjkgdGFyZ2V0X2ZyYW1lPTB4MDA0MCBvdmVycnVuPTAKPiA+IFsgIDI2NS45MDU0NTld IGR3YzIgZmY1ODAwMDAudXNiOiBkd2MyX2dhZGdldF9oYW5kbGVfZXBfZGlzYWJsZWQ6Cj4gPiBl eHBpcmluZyByZXF1ZXN0IGVwPTIgZnJhbWVfbnVtYmVyPTB4M2ZmOSB0YXJnZXRfZnJhbWU9MHgw MDQ4Cj4gPiBvdmVycnVuPTAgLS0gODwgLS0KPiA+IAo+ID4gT25jZSBhZ2FpbiB0aGVyZSBpcyBh biBpbml0aWFsIGZhaWx1cmUgYmVmb3JlIGl0IGVudGVycyB0aGUgZmFpbHVyZQo+ID4gbW9kZSBt eSBwYXRjaCBpcyB0cnlpbmcgdG8gYWRkcmVzcy4gIFRoaXMgc2VlbXMgdG8gYmUgY29uc2lzdGVu dCwKPiA+IHNvIGl0IG1heSBiZSBpbXBvcnRhbnQsIGJ1dCB0aGVyZSBpcyB+ODBtcyBiZWZvcmUg dGhlIGZhaWx1cmUKPiA+IHN0YXJ0cy4gCj4gPj4+PiBUaGlzIHdhcyBvbiB2NC4xOSB3aXRoIGFu IGFkZGl0aW9uYWwgcGF0Y2ggdG8gZGlzYWJsZSBkZXNjcmlwdG9yCj4gPj4+PiBETUEgYmVjYXVz ZSB0aGF0IHNlZW1zIHRvIGJlIGNhdXNpbmcgcHJvYmxlbXMgb24gUkszMjg4IGFsdGhvdWdoCj4g Pj4+PiBJIGhhdmVuJ3QgZmlndXJlZCBvdXQgZXhhY3RseSB3aHkgaXQncyBhIHByb2JsZW0uICAK PiA+Pj4KPiA+Pj4gSW4gd2hpY2ggbW9kZSB5b3UgcnVuIHRlc3RzIFNsYXZlIG9yIEJ1ZmZlciBE TUE/ICAKPiA+IAo+ID4gQnVmZmVyIERNQSBidXQgd2l0aCBkZXNjcmlwdG9yIERNQSBmb3JjZWQg b2ZmIChnX2RtYT0xLAo+ID4gZ19kbWFfZGVzYz0wKS4KPiA+IAo+ID4gRm9yIHRoZSByZWNvcmQs IG15IHRlc3QgY2FzZSBpcyB0aGUgc3RhbmRhcmQgVUFDMiBnYWRnZXQgd2l0aDoKPiA+IAo+ID4g CWNfc3JhdGUgPSBwX3NyYXRlID0gNDQxMDAKPiA+IAljX3NzaXplID0gcF9zc2l6ZSA9IDQKPiA+ IAljX2NobWFzayA9IDB4Zgo+ID4gCXBfY2htYXNrID0gMwo+ID4gCj4gPiBhbmQgaXQgc2VlbXMg dGhhdCB0aGUgZmFpbHVyZSBvbmx5IHRyaWdnZXJzIHdoZW4gdXNpbmcgYXJlY29yZCB0bwo+ID4g Y2FwdHVyZSBmcm9tIHRoZSBnYWRnZXQgaW50ZXJmYWNlICh0aGlzIGlzIHdpdGggYSBob3N0IHBy b2dyYW0gYm90aAo+ID4gc3RyZWFtaW5nIGluIGJvdGggZGlyZWN0aW9ucyBvdmVyIHRoZSBVU0Ig Y29ubmVjdGlvbik7IEkgc3VzcGVjdAo+ID4gdGhhdCBhY3R1YWxseSBpdCBqdXN0IG1ha2VzIGl0 IG1vcmUgbGlrZWx5IGJlY2F1c2UgdGhlcmUgaXMgbW9yZQo+ID4gd29yayBkb25lIGluIHRoZSBj b21wbGV0aW9uIGhhbmRsZXIsIGJ1dCBJIGhhdmVuJ3Qgc2VlbiB0aGUgZmFpbHVyZQo+ID4gd2l0 aG91dCBhcmVjb3JkIHJ1bm5pbmcuCj4gPiAKPiA+IAo+ID4gUmVnYXJkcywKPiA+IEpvaG4KPiA+ ICAgCj4gSSB0aGluayBjYXVzZSBvZiBpc3N1ZSBub3QgaW4gZHdjMl9nYWRnZXRfdGFyZ2V0X2Zy YW1lX2VsYXBzZWQoKSAKPiBmdW5jdGlvbiwgYnV0IGluIGRvLXdoaWxlIGxvb3AgaW4gZHdjMl9n YWRnZXRfaGFuZGxlX2VwX2Rpc2FibGVkKCkuCj4gQ291bGQgeW91IHBsZWFzZSB0cnkgYmVsb3cg cGF0Y2g6Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2R3YzIvZ2FkZ2V0LmMgYi9kcml2 ZXJzL3VzYi9kd2MyL2dhZGdldC5jCj4gaW5kZXggOGViMjVlMzU5N2IwLi40YWQ4Njk4NTNiZmEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvZHdjMi9nYWRnZXQuYwo+ICsrKyBiL2RyaXZlcnMv dXNiL2R3YzIvZ2FkZ2V0LmMKPiBAQCAtMjc2Miw4ICsyNzYyLDExIEBAIHN0YXRpYyB2b2lkCj4g ZHdjMl9nYWRnZXRfaGFuZGxlX2VwX2Rpc2FibGVkKHN0cnVjdCBkd2MyX2hzb3RnX2VwICpoc19l cCkKPiAKPiAgICAgICAgICBkbyB7Cj4gICAgICAgICAgICAgICAgICBoc19yZXEgPSBnZXRfZXBf aGVhZChoc19lcCk7Cj4gLSAgICAgICAgICAgICAgIGlmIChoc19yZXEpCj4gLSAgICAgICAgICAg ICAgICAgICAgICAgZHdjMl9oc290Z19jb21wbGV0ZV9yZXF1ZXN0KGhzb3RnLCBoc19lcCwKPiBo c19yZXEsCj4gKyAgICAgICAgICAgICAgIGlmICghaHNfcmVxKSB7Cj4gKyAgICAgICAgICAgICAg ICAgICAgICAgZGV2X3dhcm4oaHNvdGctPmRldiwgIiVzOiBJU09DIEVQIHF1ZXVlIAo+IGVtcHR5 XG4iLCBfX2Z1bmNfXyk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwo+ICsgICAg ICAgICAgICAgICB9Cj4gKyAgICAgICAgICAgICAgIGR3YzJfaHNvdGdfY29tcGxldGVfcmVxdWVz dChoc290ZywgaHNfZXAsIGhzX3JlcSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIC1FTk9EQVRBKTsKPiAgICAgICAgICAgICAgICAgIGR3YzJf Z2FkZ2V0X2luY3JfZnJhbWVfbnVtKGhzX2VwKTsKPiAgICAgICAgICAgICAgICAgIC8qIFVwZGF0 ZSBjdXJyZW50IGZyYW1lIG51bWJlciB2YWx1ZS4gKi8KCkkgZG9uJ3Qgc2VlIGFueSBkaWZmZXJl bmNlIGFmdGVyIGFwcGx5aW5nIHRoaXMgcGF0Y2gsIGFuZCB0aGUgbmV3CmRldl93YXJuIG1lc3Nh Z2UgZG9lcyBub3QgYXBwZWFyLgoKSSB0aGluayB3aGF0IGhhcHBlbnMgaXMgdGhhdCBkd2MyX2hz b3RnX2NvbXBsZXRlX3JlcXVlc3QoKSBjb21wbGV0ZXMgdGhlCm91dHN0YW5kaW5nIHJlcXVlc3Qg YW5kIHRoZSBjb21wbGV0aW9uIGhhbmRsZXIgKGluIHRoaXMgY2FzZQp1X2F1ZGlvX2lzb19jb21w bGV0ZSkgZW5xdWV1ZXMgYSBuZXcgcmVxdWVzdCwgc28gdGhlIHF1ZXVlIGlzIG5ldmVyCmVtcHR5 LgoKClJlZ2FyZHMsCkpvaG4K