All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Sasha Levin <sashal@kernel.org>,
	linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 34/44] clk: renesas: r9a06g032: Fix UART34567 clock rate
Date: Tue, 13 Nov 2018 00:49:40 -0500	[thread overview]
Message-ID: <20181113054950.77898-34-sashal@kernel.org> (raw)
In-Reply-To: <20181113054950.77898-1-sashal@kernel.org>

From: Phil Edworthy <phil.edworthy@renesas.com>

[ Upstream commit ee02950d53eee0d4c7f1c08a35272b77d24b9459 ]

The clock for UARTs 0 through 2 is UART012, the clock for UARTs 3 through
7 is UART34567.
For UART012, we stop the clock driver from changing the clock rate. This
is because the Synopsys UART driver simply sets the reference clock to 16x
the baud rate, but doesn't check if the actual rate is within the required
tolerance. The RZ/N1 clock divider can't provide this (we have to rely on
the UART's internal divider to set the correct clock rate), so you end up
with a clock rate that is way off what you wanted.

In addition, since the clock is shared between multiple UARTs, you don't
want the driver trying to change the clock rate as it may affect the other
UARTs (which may not have been configured yet, so you don't know what baud
rate they will use). Normally, the clock rate is set early on before Linux
to some very high rate that supports all of the clock rates you want.

This change stops the UART34567 clock rate from changing for the same
reasons.

Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Fixes: 4c3d88526eba2143 ("clk: renesas: Renesas R9A06G032 clock driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/clk/renesas/r9a06g032-clocks.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c
index a0b6ecdc63dd..6d2b56891559 100644
--- a/drivers/clk/renesas/r9a06g032-clocks.c
+++ b/drivers/clk/renesas/r9a06g032-clocks.c
@@ -539,7 +539,8 @@ r9a06g032_div_round_rate(struct clk_hw *hw,
 	 * several uarts attached to this divider, and changing this impacts
 	 * everyone.
 	 */
-	if (clk->index == R9A06G032_DIV_UART) {
+	if (clk->index == R9A06G032_DIV_UART ||
+	    clk->index == R9A06G032_DIV_P2_PG) {
 		pr_devel("%s div uart hack!\n", __func__);
 		return clk_get_rate(hw->clk);
 	}
-- 
2.17.1


  parent reply	other threads:[~2018-11-13  6:03 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  5:49 [PATCH AUTOSEL 4.19 01/44] bfs: add sanity check at bfs_fill_super() Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 02/44] cifs: don't dereference smb_file_target before null check Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 03/44] cifs: fix return value for cifs_listxattr Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 04/44] arm64: kprobe: make page to RO mode when allocate it Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 05/44] nvme-pci: fix conflicting p2p resource adds Sasha Levin
2018-11-13  5:49   ` Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 06/44] block: brd: associate with queue until adding disk Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 07/44] bpf: fix partial copy of map_ptr when dst is scalar Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 08/44] net: hns3: bugfix for rtnl_lock's range in the hclgevf_reset() Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 09/44] net: hns3: bugfix for rtnl_lock's range in the hclge_reset() Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 10/44] net: hns3: bugfix for handling mailbox while the command queue reinitialized Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 11/44] net: hns3: bugfix for the initialization of command queue's spin lock Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 12/44] ixgbe: fix MAC anti-spoofing filter after VFLR Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 13/44] mm: Fix warning in insert_pfn() Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 14/44] mm/memory_hotplug: make add_memory() take the device_hotplug_lock Sasha Levin
2018-11-13  5:49   ` Sasha Levin
2018-11-13  5:49   ` Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 15/44] reiserfs: propagate errors from fill_with_dentries() properly Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 16/44] hfs: prevent btree data loss on root split Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 17/44] hfsplus: " Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 18/44] mm/gup_benchmark.c: prevent integer overflow in ioctl Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 19/44] perf unwind: Take pgoff into account when reporting elf to libdwfl Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 20/44] um: Give start_idle_thread() a return code Sasha Levin
2018-11-13  5:49   ` Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 21/44] drm/edid: Add 6 bpc quirk for BOE panel Sasha Levin
2018-11-13  5:49   ` Sasha Levin
2018-11-13  5:49   ` Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 22/44] afs: Handle EIO from delivery function Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 23/44] platform/x86: intel_telemetry: report debugfs failure Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 24/44] clk: fixed-rate: fix of_node_get-put imbalance Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 25/44] perf symbols: Set PLT entry/header sizes properly on Sparc Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 26/44] fs/exofs: fix potential memory leak in mount option parsing Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 27/44] clk: samsung: exynos5420: Enable PERIS clocks for suspend Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 28/44] apparmor: Fix uninitialized value in aa_split_fqname Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 29/44] x86/earlyprintk: Add a force option for pciserial device Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 30/44] platform/x86: acerhdf: Add BIOS entry for Gateway LT31 v1.3307 Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 31/44] clk: meson-axg: pcie: drop the mpll3 clock parent Sasha Levin
2018-11-13  5:49   ` Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 32/44] arm64: percpu: Initialize ret in the default case Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 33/44] clk: meson: clk-pll: drop CLK_GET_RATE_NOCACHE where unnecessary Sasha Levin
2018-11-13  5:49   ` Sasha Levin
2018-11-13  5:49 ` Sasha Levin [this message]
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 35/44] clk: sunxi-ng: sun50i: h6: Add 2x fixed post-divider to MMC module clocks Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 36/44] clk: ti: fix OF child-node lookup Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 37/44] mm: thp: fix MADV_DONTNEED vs migrate_misplaced_transhuge_page race condition Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 38/44] mm: thp: fix mmu_notifier in migrate_misplaced_transhuge_page() Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 39/44] mm: calculate deferred pages after skipping mirrored memory Sasha Levin
2018-11-13  5:49   ` Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 40/44] mm: don't raise MEMCG_OOM event due to failed high-order allocation Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 41/44] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 42/44] userfaultfd: allow get_mempolicy(MPOL_F_NODE|MPOL_F_ADDR) to trigger userfaults Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 43/44] mm: don't miss the last page because of round-off error Sasha Levin
2018-11-13  5:49 ` [PATCH AUTOSEL 4.19 44/44] mm: don't warn about large allocations for slab Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113054950.77898-34-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=phil.edworthy@renesas.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.