From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pengfei Xu <pengfei.xu@intel.com>
Date: Fri, 16 Nov 2018 11:54:01 +0800
Subject: [LTP] [PATCH] lib: Add library function for parsing kernel
	config
In-Reply-To: <20181115134441.27359-1-chrubis@suse.cz>
References: <20181115134441.27359-1-chrubis@suse.cz>
Message-ID: <20181116035401.z2o67pjhxtutap6x@xpf-desktop>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi Cyril,
  Thanks for kconfig checking API!
  It's worked in most of Linux OS.

  Just add konfig to support Clear Linux which kconfig is saved
  in "/lib/kernel/config-xxx"
  And for print comments, if you agree as below.

On 2018-11-15 at 14:44:41 +0100, Cyril Hrubis wrote:
> diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c
> new file mode 100644
> +
> +	snprintf(path_buf, path_buf_len, "/boot/config-%s", un.release);
> +
> +	if (!access(path_buf, F_OK))
> +		return path_buf;
> +
  Could add suport for Clear Linux kconfig location:
	snprintf(path_buf, path_buf_len, "/lib/kernel/config-%s", un.release);

	if (!access(path_buf, F_OK))
		return path_buf;

> +	tst_res(TINFO, "Couldn't locate kernel config!");
> +
> +	return NULL;
> +}

> +	int abort_test = 0;
> +
> +	for (i = 0; i < conf_cnt; i++) {
> +		if (!conf_match[i]) {
> +			abort_test = 1;
> +			tst_res(TINFO, "Kernel is missing %s", kconfigs[i]);
   Could change TINFO above to TCONF?

> +		}
> +	}
> +
> +	if (abort_test)
> +		tst_brk(TCONF, "Aborting test due to missing kernel config options!");
	Add 'above' in print?
		tst_brk(TCONF,
			"Aborting test due to missing above kernel config options!");

Thanks!
B.R.