All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	"jianchao.wang" <jianchao.w.wang@oracle.com>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH V2 for-4.21 2/2] blk-mq: alloc q->queue_ctx as normal array
Date: Fri, 16 Nov 2018 06:06:23 -0800	[thread overview]
Message-ID: <20181116140623.GC4595@kroah.com> (raw)
In-Reply-To: <20181116112311.4117-3-ming.lei@redhat.com>

On Fri, Nov 16, 2018 at 07:23:11PM +0800, Ming Lei wrote:
> Now q->queue_ctx is just one read-mostly table for query the
> 'blk_mq_ctx' instance from one cpu index, it isn't necessary
> to allocate it as percpu variable. One simple array may be
> more efficient.

"may be", have you run benchmarks to be sure?  If so, can you add the
results of them to this changelog?  If there is no measurable
difference, then why make this change at all?

thanks,

greg k-h

  reply	other threads:[~2018-11-16 14:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 11:23 [PATCH V2 0/2] blk-mq: fix kobject lifetime issue Ming Lei
2018-11-16 11:23 ` [PATCH V2 for-4.21 1/2] blk-mq: not embed .mq_kobj and ctx->kobj into queue instance Ming Lei
2018-11-16 14:05   ` Greg Kroah-Hartman
2018-11-17  2:26     ` Ming Lei
2018-11-19 10:06       ` Greg Kroah-Hartman
2018-11-19 10:20         ` Ming Lei
2018-11-16 11:23 ` [PATCH V2 for-4.21 2/2] blk-mq: alloc q->queue_ctx as normal array Ming Lei
2018-11-16 14:06   ` Greg Kroah-Hartman [this message]
2018-11-17  2:34     ` Ming Lei
2018-11-17 10:03       ` Greg Kroah-Hartman
2018-11-19  2:04         ` Ming Lei
2018-11-19 10:17           ` Greg Kroah-Hartman
2018-11-19 10:51             ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181116140623.GC4595@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=jianchao.w.wang@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.