From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.211]:50790 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728124AbeKQCKR (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 16 Nov 2018 21:10:17 -0500
Date: Fri, 16 Nov 2018 16:57:21 +0100
From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, sandeen@redhat.com, hch@lst.de,
        david@fromorbit.com, darrick.wong@oracle.com
Subject: Re: [PATCH 15/20] fiemap: Start using new callback from fiemap_ctx
Message-ID: <20181116155721.GI15119@lst.de>
References: <20181030131823.29040-1-cmaiolino@redhat.com> <20181030131823.29040-16-cmaiolino@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181030131823.29040-16-cmaiolino@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> +int fiemap_fill_usr_extent(struct fiemap_ctx *f_ctx, u64 logical,

Please spell out user.

> +int fiemap_fill_next_extent(struct fiemap_ctx *f_ctx, u64 logical,
> +			    u64 phys, u64 len, u32 flags)
> +{
> +	return f_ctx->fc_cb(f_ctx, logical, phys, len, flags);
> +}
> +EXPORT_SYMBOL(fiemap_fill_next_extent);

Do we really need this wrapper?  Which reminds me that we usually
pass the callbacks as direct function arguments.  Any good reason it
is in the context here?