From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 16 Nov 2018 12:09:32 -0500 Subject: [U-Boot] [PATCH] serial: ns16550: add setconfig support In-Reply-To: References: <20181102202808.5281-1-simon.k.r.goldschmidt@gmail.com> Message-ID: <20181116170932.GC11247@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Nov 16, 2018 at 06:04:40PM +0100, Simon Goldschmidt wrote: > Am Sa., 3. Nov. 2018, 08:56 hat Simon Goldschmidt < > simon.k.r.goldschmidt at gmail.com> geschrieben: > > > On 03.11.2018 07:08, Simon Glass wrote: > > > On 2 November 2018 at 14:28, Simon Goldschmidt > > > wrote: > > >> Add possibility to update the serial parity used. > > >> > > >> Signed-off-by: Simon Goldschmidt > > >> --- > > >> > > >> drivers/serial/ns16550.c | 43 ++++++++++++++++++++++++++++++++++++++-- > > >> 1 file changed, 41 insertions(+), 2 deletions(-) > > >> > > > Reviewed-by: Simon Glass > > > > > > Ideally we should call this from sandbox (or a test) somewhere. > > > > Hmm, I'm a bit lost there. I haven't really used the tests so far and > > grep'ing through test/ does not show any reference to ns16550 either > > (where I could easily add a test). > > > > Did you mean adding a test for this specific driver (ns16550) or for the > > call to 'setconfig' in general? (Because I thought Patrice had already > > done that.) > > > > Simon, any input on this? Does your comment somehow hold back this from > being pushed? I'm testing this now, btw. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: