From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381F5C43441 for ; Sat, 17 Nov 2018 15:39:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03F9E2080F for ; Sat, 17 Nov 2018 15:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03F9E2080F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726590AbeKRB47 (ORCPT ); Sat, 17 Nov 2018 20:56:59 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:36964 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726128AbeKRB47 (ORCPT ); Sat, 17 Nov 2018 20:56:59 -0500 Received: by mail-ot1-f68.google.com with SMTP id 40so24051411oth.4; Sat, 17 Nov 2018 07:39:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Vkxih/5I2a9Dk2orrHMlbXwUiFatKi2Hk3u6eepeUl4=; b=DP88k781DED/K3fNJRZizis6Ft5ZzkC7PtEojBPRTc8ets2VB+Z1r3py1SOlCLT2u6 aQd9jyYulp0kfo+gspHmxSmbsK6F+DoTsIPAN4U7zNFna8n5NW6YbpoHXSYYH1qYwER8 HUjiTAEk4dV58yp04K9Mfksx+APzICWipIbxRWwiNFKAesdil+GsuZDaNX1riUwENxbS SCrToVGScT6JYW7CpHuYO1rG/gCTmh+w41xhaW2MKxLD11v/0oNDhyju4iF8gGQdX4cC q7162bQPuke1uqqmVkKA5GSSLNx2YaUz2+lryPgpdUohjsPRJwyfeWnQSYnhK3vbqqp3 3sdQ== X-Gm-Message-State: AGRZ1gJpzlbtvTXjuQ5XVIfpBy7HKw2RPKiMGnGKVmdAj6l/Mpng+MmA SlNf4Ai1VOR3DcmN6l2/lA== X-Google-Smtp-Source: AJdET5c+5lq0BjI0IJMXpVc5Mc0AH5DK1Ca6njAtJM/45kHqvAb89CO1FsPOxRW49Guv5714vIXlYg== X-Received: by 2002:a9d:1715:: with SMTP id i21mr8684442ota.149.1542469196843; Sat, 17 Nov 2018 07:39:56 -0800 (PST) Received: from localhost ([166.137.105.180]) by smtp.gmail.com with ESMTPSA id t43sm14866544oti.73.2018.11.17.07.39.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Nov 2018 07:39:56 -0800 (PST) Date: Sat, 17 Nov 2018 09:39:54 -0600 From: Rob Herring To: Lubomir Rintel Cc: Mauro Carvalho Chehab , Jonathan Corbet , linux-media@vger.kernel.org, Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, James Cameron , Pavel Machek , Libin Yang , Albert Wang Subject: Re: [PATCH v2 03/11] media: dt-bindings: marvell,mmp2-ccic: Add Marvell MMP2 camera Message-ID: <20181117153954.GA28966@bogus> References: <20181112003520.577592-1-lkundrak@v3.sk> <20181112003520.577592-4-lkundrak@v3.sk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181112003520.577592-4-lkundrak@v3.sk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 12, 2018 at 01:35:12AM +0100, Lubomir Rintel wrote: > Add Marvell MMP2 camera host interface. > > Signed-off-by: Lubomir Rintel > --- > .../bindings/media/marvell,mmp2-ccic.txt | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt > > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt > new file mode 100644 > index 000000000000..a9c536e58dda > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt > @@ -0,0 +1,30 @@ > +Marvell MMP2 camera host interface > + > +Required properties: > + - compatible: Should be "marvell,mmp2-ccic" > + - reg: register base and size > + - interrupts: the interrupt number > + - any required generic properties defined in video-interfaces.txt > + > +Optional properties: > + - clocks: input clock (see clock-bindings.txt) > + - clock-output-names: should contain the name of the clock driving the > + sensor master clock MCLK Missing #clock-cells and clock-names. How many ports and endpoints also needs to be documented. > + > +Example: > + > + camera0: camera@d420a000 { > + compatible = "marvell,mmp2-ccic"; > + reg = <0xd420a000 0x800>; > + interrupts = <42>; > + clocks = <&soc_clocks MMP2_CLK_CCIC0>; > + clock-names = "CCICAXICLK"; > + #clock-cells = <0>; > + clock-output-names = "mclk"; > + > + port { > + camera0_0: endpoint { > + remote-endpoint = <&ov7670_0>; > + }; > + }; > + }; > -- > 2.19.1 >