All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuval Shaia <yuval.shaia@oracle.com>
To: yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com,
	dmitry.fleytman@gmail.com, jasowang@redhat.com,
	eblake@redhat.com, armbru@redhat.com, pbonzini@redhat.com,
	qemu-devel@nongnu.org, shamir.rabinovitch@oracle.com,
	cohuck@redhat.com
Subject: [Qemu-devel] [PATCH v4 04/23] hw/rdma: Abort send-op if fail to create addr handler
Date: Sun, 18 Nov 2018 14:28:24 +0200	[thread overview]
Message-ID: <20181118122843.10892-5-yuval.shaia@oracle.com> (raw)
In-Reply-To: <20181118122843.10892-1-yuval.shaia@oracle.com>

Function create_ah might return NULL, let's exit with an error.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
---
 hw/rdma/rdma_backend.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index d7a4bbd91f..1e148398a2 100644
--- a/hw/rdma/rdma_backend.c
+++ b/hw/rdma/rdma_backend.c
@@ -338,6 +338,10 @@ void rdma_backend_post_send(RdmaBackendDev *backend_dev,
     if (qp_type == IBV_QPT_UD) {
         wr.wr.ud.ah = create_ah(backend_dev, qp->ibpd,
                                 backend_dev->backend_gid_idx, dgid);
+        if (!wr.wr.ud.ah) {
+            comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_FAIL_BACKEND, ctx);
+            goto out_dealloc_cqe_ctx;
+        }
         wr.wr.ud.remote_qpn = dqpn;
         wr.wr.ud.remote_qkey = dqkey;
     }
-- 
2.17.2

  parent reply	other threads:[~2018-11-18 12:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-18 12:28 [Qemu-devel] [PATCH v4 00/23] Add support for RDMA MAD Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 01/23] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 02/23] hw/rdma: Add ability to force notification without re-arm Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 03/23] hw/rdma: Return qpn 1 if ibqp is NULL Yuval Shaia
2018-11-18 12:28 ` Yuval Shaia [this message]
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 05/23] hw/rdma: Add support for MAD packets Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 06/23] hw/pvrdma: Make function reset_device return void Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 07/23] hw/pvrdma: Make default pkey 0xFFFF Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 08/23] hw/pvrdma: Set the correct opcode for recv completion Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 09/23] hw/pvrdma: Set the correct opcode for send completion Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 10/23] json: Define new QMP message for pvrdma Yuval Shaia
2018-11-19  7:16   ` Markus Armbruster
2018-11-22 11:21     ` Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 11/23] hw/pvrdma: Add support to allow guest to configure GID table Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 12/23] vmxnet3: Move some definitions to header file Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 13/23] hw/pvrdma: Make sure PCI function 0 is vmxnet3 Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 14/23] hw/rdma: Initialize node_guid from vmxnet3 mac address Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 15/23] hw/pvrdma: Make device state depend on Ethernet function state Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 16/23] hw/pvrdma: Fill all CQE fields Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 17/23] hw/pvrdma: Fill error code in command's response Yuval Shaia
2018-11-25  7:38   ` Marcel Apfelbaum
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 18/23] hw/rdma: Remove unneeded code that handles more that one port Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 19/23] vl: Introduce shutdown_notifiers Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 20/23] hw/pvrdma: Clean device's resource when system is shutdown Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 21/23] hw/rdma: Do not use bitmap_zero_extend to free bitmap Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 22/23] hw/rdma: Do not call rdma_backend_del_gid on an empty gid Yuval Shaia
2018-11-18 12:28 ` [Qemu-devel] [PATCH v4 23/23] docs: Update pvrdma device documentation Yuval Shaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181118122843.10892-5-yuval.shaia@oracle.com \
    --to=yuval.shaia@oracle.com \
    --cc=armbru@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=dmitry.fleytman@gmail.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shamir.rabinovitch@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.