From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com ([209.85.128.66]:40384 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728724AbeKSXFb (ORCPT ); Mon, 19 Nov 2018 18:05:31 -0500 Received: by mail-wm1-f66.google.com with SMTP id q26so5084869wmf.5 for ; Mon, 19 Nov 2018 04:42:00 -0800 (PST) Date: Mon, 19 Nov 2018 13:41:56 +0100 From: Carlos Maiolino To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, sandeen@redhat.com, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH 16/20] fibmap: Use bmap instead of ->bmap method in ioctl_fibmap Message-ID: <20181119124156.lqmehfn6o4uckspm@hades.usersys.redhat.com> References: <20181030131823.29040-1-cmaiolino@redhat.com> <20181030131823.29040-17-cmaiolino@redhat.com> <20181116155853.GJ15119@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181116155853.GJ15119@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 16, 2018 at 04:58:53PM +0100, Christoph Hellwig wrote: > > + error = bmap(inode, (sector_t *)&block); > > You can't cast and int * to a sector_t * without causing problems. > You'll need a local variable of type sector_t that the value > gets assigned to and read back from instead. Ok, thanks for the information, I'll update it, but, could you detail a bit more what kind of problem you are referring to? I'm curious to understand why and which kind of problems it can cause. > Also shouldn't this patch be earlier in the series? I opted to move this patch to the end of the series, when most of the fiemap rework is done, I can move it to the beginning of the series if it's better. -- Carlos