From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAD0C18DF5 for ; Tue, 20 Nov 2018 14:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2EA920831 for ; Tue, 20 Nov 2018 14:25:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2EA920831 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729762AbeKUAyn (ORCPT ); Tue, 20 Nov 2018 19:54:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:33690 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727682AbeKUAym (ORCPT ); Tue, 20 Nov 2018 19:54:42 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8A9BDADE4; Tue, 20 Nov 2018 14:25:17 +0000 (UTC) Date: Tue, 20 Nov 2018 15:25:17 +0100 From: Michal Hocko To: David Hildenbrand Cc: linux-mm@kvack.org, Andrew Morton , Oscar Salvador , Pavel Tatashin , LKML Subject: Re: [RFC PATCH 1/3] mm, memory_hotplug: try to migrate full section worth of pages Message-ID: <20181120142517.GL22247@dhcp22.suse.cz> References: <20181120134323.13007-1-mhocko@kernel.org> <20181120134323.13007-2-mhocko@kernel.org> <65271adc-93b4-19fc-e54b-11db582359c5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65271adc-93b4-19fc-e54b-11db582359c5@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 20-11-18 15:18:41, David Hildenbrand wrote: [...] > (we could also check for pending signals inside that function if really > required) do_migrate_pages is not the proper layer to check signals. Because the loop only isolates pages and that is not expensive. The most expensive part is deeper down in the migration core. We wait for page lock or writeback and that can take a long. None of that is killable wait which is a larger surgery but something that we should consider should there be any need to address this. > Reviewed-by: David Hildenbrand Thanks! -- Michal Hocko SUSE Labs