From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 7/7] regulator: core: Remove loop disabling supplies in
 regulator_force_disable()
Date: Tue, 20 Nov 2018 16:59:32 +0000
Message-ID: <20181120165932.GN3894@sirena.org.uk>
References: <20181120002654.1891-1-dianders@chromium.org>
 <20181120002654.1891-7-dianders@chromium.org>
 <20181120155458.GG3894@sirena.org.uk>
 <CAD=FV=UHiwjt2a8GFZKG3ZrRfjTgQDWD_mZu_qZP7Ve-HNTMYg@mail.gmail.com>
 <20181120162504.GJ3894@sirena.org.uk>
 <CAD=FV=VncEViv-mUJzUdjA8qvEouHHtiVfV2EpYi6bLAMW7S7Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="95CBLwa+io9O2zXc"
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CAD=FV=VncEViv-mUJzUdjA8qvEouHHtiVfV2EpYi6bLAMW7S7Q@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Doug Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>, Evan Green <evgreen@chromium.org>, Stephen Boyd <swboyd@chromium.org>, Dmitry Osipenko <digetx@gmail.com>, ryandcase@chromium.org, David Collins <collinsd@codeaurora.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, LKML <linux-kernel@vger.kernel.org>
List-Id: linux-arm-msm@vger.kernel.org


--95CBLwa+io9O2zXc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Nov 20, 2018 at 08:57:32AM -0800, Doug Anderson wrote:
> On Tue, Nov 20, 2018 at 8:25 AM Mark Brown <broonie@kernel.org> wrote:

> > I do wish there
> > were a way to flag API calls as needing review :(

> Would it be worth adding a WARN_ON(1) splat here or at least a
> "dev_warn" so people knew it wasn't really an API for general use?
> ...or is that going overboard?

That might work ehre but it's not just this call, and the trouble is
that there are legitimate use cases and we can't exactly have a magic
"no, I know what I'm doing" flag that things need to pass or anything.

--95CBLwa+io9O2zXc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlv0PXMACgkQJNaLcl1U
h9BEWQf/YALGgDhe7vExtg+3DBwOz8l2OGOw+KcdvIvAntF5cgNJDoPRj3VWfnc7
ZduD9EOGmWTHsxi0a+1f2ugr9YP0erOTLbwxg9ZWcEjMxtVejqepyycC+W13Vt/2
UnbbMyMHek9zDN2QiUMMJdPYbYsR1wO6C19ELAnYvog+wJ3CZ7AnOLAHdvh9pNkY
t9ymfuBGbCpbOACp1bZgZCm9GVjcMw3G4Q5F9mZ3QGjQsC/R1gMaux1WdCocmB5m
REexWFwEHjB7R2tJu9LMcDIqonBjDsjC5rYCuwvHN+EYdXmvpLREr0FRKHNqL0XU
T6qJI3Kd20P+945AOLzO0oppJz71xA==
=wlye
-----END PGP SIGNATURE-----

--95CBLwa+io9O2zXc--