From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH net-next,v3 12/12] qede: use ethtool_rx_flow_rule() to
 remove duplicated parser code
Date: Thu, 22 Nov 2018 14:59:08 -0200
Message-ID: <20181122165908.GD8353@localhost.localdomain>
References: <20181121025132.14305-1-pablo@netfilter.org>
 <20181121025132.14305-13-pablo@netfilter.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, davem@davemloft.net,
        thomas.lendacky@amd.com, f.fainelli@gmail.com,
        ariel.elior@cavium.com, michael.chan@broadcom.com,
        santosh@chelsio.com, madalin.bucur@nxp.com,
        yisen.zhuang@huawei.com, salil.mehta@huawei.com,
        jeffrey.t.kirsher@intel.com, tariqt@mellanox.com,
        saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com,
        jakub.kicinski@netronome.com, peppe.cavallaro@st.com,
        grygorii.strashko@ti.com, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com,
        joabreu@synopsys.com, linux-net-drivers@solarflare.com,
        ganeshgr@chelsio.com, ogerlitz@mellanox.com,
        Manish.Chopra@cavium.com
To: Pablo Neira Ayuso <pablo@netfilter.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt1-f171.google.com ([209.85.160.171]:46542 "EHLO
        mail-qt1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2388150AbeKWDjZ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 22 Nov 2018 22:39:25 -0500
Received: by mail-qt1-f171.google.com with SMTP id y20so8043830qtm.13
        for <netdev@vger.kernel.org>; Thu, 22 Nov 2018 08:59:12 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20181121025132.14305-13-pablo@netfilter.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Nov 21, 2018 at 03:51:32AM +0100, Pablo Neira Ayuso wrote:
...
>  static int
>  qede_parse_flower_attr(struct qede_dev *edev, __be16 proto,
> -		       struct tc_cls_flower_offload *f,
> -		       struct qede_arfs_tuple *tuple)
> +		       struct flow_rule *rule, struct qede_arfs_tuple *tuple)

What about s/qede_parse_flower_attr/qede_parse_flow_attr/ or so? As it
is not about flower anymore.

It also helps here:

> -static int qede_flow_spec_to_tuple(struct qede_dev *edev,
> -				   struct qede_arfs_tuple *t,
> -				   struct ethtool_rx_flow_spec *fs)
> +static int qede_flow_spec_to_rule(struct qede_dev *edev,
> +				  struct qede_arfs_tuple *t,
> +				  struct ethtool_rx_flow_spec *fs)
>  {
...
> +
> +	if (qede_parse_flower_attr(edev, proto, flow->rule, t)) {
> +		err = -EINVAL;
> +		goto err_out;
> +	}
> +
> +	/* Make sure location is valid and filter isn't already set */
> +	err = qede_flow_spec_validate(edev, &flow->rule->action, t,
> +				      fs->location);
...