From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37CB2C43441 for ; Thu, 22 Nov 2018 17:30:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E72620824 for ; Thu, 22 Nov 2018 17:30:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E72620824 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406343AbeKWEKd (ORCPT ); Thu, 22 Nov 2018 23:10:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55960 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404220AbeKWEKc (ORCPT ); Thu, 22 Nov 2018 23:10:32 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7483230013B9; Thu, 22 Nov 2018 17:30:12 +0000 (UTC) Received: from treble (ovpn-121-105.rdu2.redhat.com [10.10.121.105]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 769F65C25A; Thu, 22 Nov 2018 17:30:06 +0000 (UTC) Date: Thu, 22 Nov 2018 11:30:04 -0600 From: Josh Poimboeuf To: Borislav Petkov Cc: Thomas Gleixner , Linus Torvalds , Linux List Kernel Mailing , the arch/x86 maintainers , Peter Zijlstra , Andrew Lutomirski , Jiri Kosina , thomas.lendacky@amd.com, Andrea Arcangeli , David Woodhouse , Andi Kleen , dave.hansen@intel.com, Casey Schaufler , "Mallick, Asit K" , "Van De Ven, Arjan" , jcm@redhat.com, longman9394@gmail.com, Greg KH , david.c.stewart@intel.com, Kees Cook , Tim Chen Subject: Re: [patch 01/24] x86/speculation: Update the TIF_SSBD comment Message-ID: <20181122173004.fn4tqoclhcyibxff@treble> References: <20181121201430.559770965@linutronix.de> <20181121201722.337599561@linutronix.de> <20181121230450.k75e4ipdag73dayz@treble> <20181121230854.GH27559@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181121230854.GH27559@zn.tnic> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 22 Nov 2018 17:30:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 22, 2018 at 12:08:54AM +0100, Borislav Petkov wrote: > On Wed, Nov 21, 2018 at 05:04:50PM -0600, Josh Poimboeuf wrote: > > Why not just 'user'? Like SPECTRE_V2_USER_*. > > Sure, a bit better except that it doesn't explain what it does, I'd say. But it does describe its purpose, especially in relation to the 'spectre_v2=' option. Previously 'spectre_v2=' might have been more appropriately named 'spectre_v2_kernel=' because it only protected the kernel from Spectre v2 attacks. Now with these new patches, 'spectre_v2=on' will protect the entire system. Whereas 'spectre_v2_user=' is a subset of that; it helps protect user space from itself. Appending "user" to the existing 'spectre_v2=' option helps to communicate that, IMO. Now off to eat a giant turkey. -- Josh