From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/3] tcp: take a bit more care of backlog stress Date: Fri, 23 Nov 2018 11:25:16 -0800 (PST) Message-ID: <20181123.112516.1009412686662405132.davem@davemloft.net> References: <20181121175240.6075-1-edumazet@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jean-louis@dupond.be, ncardwell@google.com, ycheng@google.com, eric.dumazet@gmail.com To: edumazet@google.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:33256 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbeKXGKx (ORCPT ); Sat, 24 Nov 2018 01:10:53 -0500 In-Reply-To: <20181121175240.6075-1-edumazet@google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Wed, 21 Nov 2018 09:52:37 -0800 > While working on the SACK compression issue Jean-Louis Dupond > reported, we found that his linux box was suffering very hard > from tail drops on the socket backlog queue, because the opposite > TCP stack was ont implementing latest RFC recommendations. > > First patch is a cleanup > > Second patch is attempting coalescing when a new packet must > be added to the backlog queue. Cooking bigger skbs helps > to keep backlog list smaller and speeds its handling when > user thread finally releases the socket lock. > > Third patch is implementing head drop as a last resort. > Head drops are generally better for optimal TCP behavior. My impression is that patch #2 needs some fixes in order to not lose dupacks. So there will be a respin of this. Thanks.