All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: claudiu.manoil@nxp.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	alexandru.marginean@nxp.com, catalin.horghidan@nxp.com
Subject: Re: [PATCH net-next v3 1/4] enetc: Introduce basic PF and VF ENETC ethernet drivers
Date: Fri, 23 Nov 2018 22:29:15 -0800 (PST)	[thread overview]
Message-ID: <20181123.222915.1197343130823511085.davem@davemloft.net> (raw)
In-Reply-To: <1542969963-10676-2-git-send-email-claudiu.manoil@nxp.com>

From: Claudiu Manoil <claudiu.manoil@nxp.com>
Date: Fri, 23 Nov 2018 12:46:00 +0200

> +static int enetc_poll(struct napi_struct *napi, int budget)
> +{
> +	struct enetc_int_vector
> +		*v = container_of(napi, struct enetc_int_vector, napi);
> +	bool complete = true;
> +	int work_done;
> +	int i;
> +
> +	for (i = 0; i < v->count_tx_rings; i++) {
> +		work_done = enetc_clean_tx_ring(&v->tx_ring[i], budget);
> +		if (work_done == budget)
> +			complete = false;
> +	}

You should not count TX completion processing as NAPI poll "work".
It is relatively "free" compared to RX packet processing.

  reply	other threads:[~2018-11-24  6:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23 10:45 [PATCH net-next v3 0/4] Introduce ENETC ethernet drivers Claudiu Manoil
2018-11-23 10:46 ` [PATCH net-next v3 1/4] enetc: Introduce basic PF and VF " Claudiu Manoil
2018-11-24  6:29   ` David Miller [this message]
2018-11-24 15:40   ` kbuild test robot
2018-11-23 10:46 ` [PATCH net-next v3 2/4] enetc: Add ethtool statistics Claudiu Manoil
2018-11-23 10:46 ` [PATCH net-next v3 3/4] enetc: Add vf to pf messaging support Claudiu Manoil
2018-11-23 10:46 ` [PATCH net-next v3 4/4] enetc: Add RFS and RSS support Claudiu Manoil
2018-11-25  7:28   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181123.222915.1197343130823511085.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexandru.marginean@nxp.com \
    --cc=catalin.horghidan@nxp.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.