From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD0DEC43441 for ; Fri, 23 Nov 2018 19:25:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 681A520861 for ; Fri, 23 Nov 2018 19:25:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 681A520861 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441341AbeKXGKo (ORCPT ); Sat, 24 Nov 2018 01:10:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:53234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbeKXGKo (ORCPT ); Sat, 24 Nov 2018 01:10:44 -0500 Received: from vmware.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 124AB20874; Fri, 23 Nov 2018 19:25:06 +0000 (UTC) Date: Fri, 23 Nov 2018 14:25:04 -0500 From: Steven Rostedt To: Joel Fernandes Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Masami Hiramatsu , Josh Poimboeuf , Frederic Weisbecker , Andy Lutomirski , Mark Rutland Subject: Re: [RFC][PATCH 09/14] function_graph: Move ftrace_graph_get_addr() to fgraph.c Message-ID: <20181123142504.5c748c93@vmware.local.home> In-Reply-To: <20181123031338.GC17060@google.com> References: <20181122012708.491151844@goodmis.org> <20181122012803.843285508@goodmis.org> <20181123031338.GC17060@google.com> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Nov 2018 19:13:38 -0800 Joel Fernandes wrote: > On Wed, Nov 21, 2018 at 08:27:17PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > Move the function function_graph_get_addr() to fgraph.c, as the management > > of the curr_ret_stack is going to change, and all the accesses to ret_stack > > needs to be done in fgraph.c. > > s/ftrace_graph_get_addr/ftrace_graph_ret_addr/ > Good catch. I wrote the change logs a bit after writing the patch. I had "get" on my mind. -- Steve