All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Sterba <dsterba@suse.cz>, Kees Cook <keescook@google.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: linux-next: build warning after merge of the btrfs-kdave tree
Date: Mon, 26 Nov 2018 11:06:29 +1100	[thread overview]
Message-ID: <20181126110629.45969c51@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

Hi David,

After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

In file included from include/linux/string.h:6,
                 from arch/powerpc/include/asm/paca.h:19,
                 from arch/powerpc/include/asm/current.h:16,
                 from include/linux/sched.h:12,
                 from fs/btrfs/volumes.c:6:
fs/btrfs/volumes.h: In function 'btrfs_op':
include/linux/compiler.h:77:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
 # define unlikely(x) __builtin_expect(!!(x), 0)
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/bug.h:72:2: note: in expansion of macro 'unlikely'
  unlikely(__ret_warn_on);    \
  ^~~~~~~~
fs/btrfs/volumes.h:395:3: note: in expansion of macro 'WARN_ON_ONCE'
   WARN_ON_ONCE(1);
   ^~~~~~~~~~~~
In file included from fs/btrfs/volumes.c:22:
fs/btrfs/volumes.h:396:2: note: here
  case REQ_OP_READ:
  ^~~~

Introduced by commit

  cf8cddd38bab3 ("btrfs: don't abuse REQ_OP_* flags for btrfs_map_block")

exposed by my new use of -Wimplicit-fallthrough

I am not sure why this has only turned up now (as opposed to earlier
today).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2018-11-26  0:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26  0:06 Stephen Rothwell [this message]
2018-11-26  7:56 ` linux-next: build warning after merge of the btrfs-kdave tree Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2019-05-03  0:21 Stephen Rothwell
2019-05-03 13:37 ` David Sterba
2019-01-23 22:53 Stephen Rothwell
2019-01-28 16:53 ` David Sterba
2017-12-19 22:20 Stephen Rothwell
2017-12-20  0:12 ` Qu Wenruo
2017-12-21 16:49   ` David Sterba
2017-12-22  0:32     ` Qu Wenruo
2017-05-17 23:41 Stephen Rothwell
2017-05-18 12:50 ` David Sterba
2017-05-25  1:31   ` Stephen Rothwell
2016-11-28  0:02 Stephen Rothwell
2016-12-06 22:38 ` Stephen Rothwell
2016-12-14 15:19   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181126110629.45969c51@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=dsterba@suse.cz \
    --cc=hch@lst.de \
    --cc=keescook@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.