Re: [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message

From: Igor Mammedov <imammedo@redhat.com>
To: Zhang Yi <yi.z.zhang@linux.intel.com>
Cc: xiaoguangrong.eric@gmail.com, dan.j.williams@intel.com,
	stefanha@redhat.com, pbonzini@redhat.com,
	yu.c.zhang@linux.intel.com, qemu-devel@nongnu.org,
	ehabkost@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message
Date: Mon, 26 Nov 2018 14:10:26 +0100	[thread overview]
Message-ID: <20181126141026.36986d6c@redhat.com> (raw)
In-Reply-To: <4773dd7667ce53e3894ac705badd6e580808c6ce.1542699775.git.yi.z.zhang@linux.intel.com>

On Tue, 20 Nov 2018 15:48:06 +0800
Zhang Yi <yi.z.zhang@linux.intel.com> wrote:

> object_get_canonical_path_component() returns a string which
> must be freed using g_free().
> 
> Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  numa.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/numa.c b/numa.c
> index 50ec016..3875e1e 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -533,6 +533,7 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
>              error_report("memory backend %s is used multiple times. Each "
>                           "-numa option must use a different memdev value.",
>                           path);
> +            g_free(path);
>              exit(1);
>          }
>