From: Martin Lau <kafai@fb.com>
To: Yonghong Song <yhs@fb.com>
Cc: Alexei Starovoitov <ast@fb.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 1/2] bpf: btf: support proper non-jit func info
Date: Mon, 26 Nov 2018 17:21:09 +0000 [thread overview]
Message-ID: <20181126172103.mjnaeudqd4fbbepx@kafai-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20181125072045.1389189-2-yhs@fb.com>
On Sat, Nov 24, 2018 at 11:20:44PM -0800, Yonghong Song wrote:
> Commit 838e96904ff3 ("bpf: Introduce bpf_func_info")
> added bpf func info support. The userspace is able
> to get better ksym's for bpf programs with jit, and
> is able to print out func prototypes.
>
> For a program containing func-to-func calls, the existing
> implementation returns user specified number of function
> calls and BTF types if jit is enabled. If the jit is not
> enabled, it only returns the type for the main function.
>
> This is undesirable. Interpreter may still be used
> and we should keep feature identical regardless of
> whether jit is enabled or not.
> This patch fixed this discrepancy.
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2018-11-27 4:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 7:20 [PATCH bpf-next 0/2] bpf: support proper non-jit func info Yonghong Song
2018-11-25 7:20 ` [PATCH bpf-next 1/2] bpf: btf: " Yonghong Song
2018-11-26 17:21 ` Martin Lau [this message]
2018-11-25 7:20 ` [PATCH bpf-next 2/2] tools/bpf: change selftest test_btf for both jit and non-jit Yonghong Song
2018-11-26 17:21 ` Martin Lau
2018-11-27 2:04 ` [PATCH bpf-next 0/2] bpf: support proper non-jit func info Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126172103.mjnaeudqd4fbbepx@kafai-mbp.dhcp.thefacebook.com \
--to=kafai@fb.com \
--cc=Kernel-team@fb.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.