From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRKbb-00036l-I4 for qemu-devel@nongnu.org; Mon, 26 Nov 2018 12:23:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRKbV-00083W-IM for qemu-devel@nongnu.org; Mon, 26 Nov 2018 12:23:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51776) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRKbT-00081w-GO for qemu-devel@nongnu.org; Mon, 26 Nov 2018 12:23:25 -0500 Date: Mon, 26 Nov 2018 17:23:09 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20181126172308.GJ2547@work-vm> References: <20181115192446.17187-1-minyard@acm.org> <20181115192446.17187-7-minyard@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181115192446.17187-7-minyard@acm.org> Subject: Re: [Qemu-devel] [PATCH v2 06/12] boards.h: Ignore migration for SMBus devices on older machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org Cc: qemu-devel@nongnu.org, Paolo Bonzini , "Michael S . Tsirkin" , Corey Minyard , Eduardo Habkost , Marcel Apfelbaum * minyard@acm.org (minyard@acm.org) wrote: > From: Corey Minyard > > Migration capability is being added for pm_smbus and SMBus devices. > This change will allow backwards compatibility to be kept when > migrating back to an old qemu version. Add a bool to the machine > class tho keep smbus migration from happening. Future changes > will use this. So this is also going to have to be in the 3.0 and 3.1 machine options and maybe some other architectures? Dave > Signed-off-by: Corey Minyard > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > --- > hw/i386/pc_piix.c | 1 + > hw/i386/pc_q35.c | 1 + > include/hw/boards.h | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index cb28227cc3..3d1ccb1af1 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -443,6 +443,7 @@ static void pc_i440fx_2_12_machine_options(MachineClass *m) > pc_i440fx_3_0_machine_options(m); > m->is_default = 0; > m->alias = NULL; > + m->smbus_no_migration_support = true; > SET_MACHINE_COMPAT(m, PC_COMPAT_2_12); > } > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 90e88c9b28..0c6fca6a40 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -324,6 +324,7 @@ static void pc_q35_2_12_machine_options(MachineClass *m) > { > pc_q35_3_0_machine_options(m); > m->alias = NULL; > + m->smbus_no_migration_support = true; > SET_MACHINE_COMPAT(m, PC_COMPAT_2_12); > } > > diff --git a/include/hw/boards.h b/include/hw/boards.h > index f82f28468b..65314fbe2a 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -207,6 +207,7 @@ struct MachineClass { > void (*numa_auto_assign_ram)(MachineClass *mc, NodeInfo *nodes, > int nb_nodes, ram_addr_t size); > bool ignore_boot_device_suffixes; > + bool smbus_no_migration_support; > > HotplugHandler *(*get_hotplug_handler)(MachineState *machine, > DeviceState *dev); > -- > 2.17.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK