From mboxrd@z Thu Jan 1 00:00:00 1970 From: Omar Sandoval Subject: Re: [PATCH V12 06/20] block: rename bvec helpers Date: Mon, 26 Nov 2018 14:18:35 -0800 Message-ID: <20181126221835.GG30411@vader> References: <20181126021720.19471-1-ming.lei@redhat.com> <20181126021720.19471-7-ming.lei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181126021720.19471-7-ming.lei@redhat.com> Sender: linux-btrfs-owner@vger.kernel.org To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh List-Id: linux-raid.ids On Mon, Nov 26, 2018 at 10:17:06AM +0800, Ming Lei wrote: > We will support multi-page bvec soon, and have to deal with > single-page vs multi-page bvec. This patch follows Christoph's > suggestion to rename all the following helpers: > > for_each_bvec > bvec_iter_bvec > bvec_iter_len > bvec_iter_page > bvec_iter_offset > > into: > for_each_segment > segment_iter_bvec > segment_iter_len > segment_iter_page > segment_iter_offset > > so that these helpers named with 'segment' only deal with single-page > bvec, or called segment. We will introduce helpers named with 'bvec' > for multi-page bvec. > > bvec_iter_advance() isn't renamed becasue this helper is always operated > on real bvec even though multi-page bvec is supported. > > Suggested-by: Christoph Hellwig Reviewed-by: Omar Sandoval > Signed-off-by: Ming Lei > --- > .clang-format | 2 +- > drivers/md/dm-integrity.c | 2 +- > drivers/md/dm-io.c | 4 ++-- > drivers/nvdimm/blk.c | 4 ++-- > drivers/nvdimm/btt.c | 4 ++-- > include/linux/bio.h | 10 +++++----- > include/linux/bvec.h | 20 +++++++++++--------- > include/linux/ceph/messenger.h | 2 +- > lib/iov_iter.c | 2 +- > net/ceph/messenger.c | 14 +++++++------- > 10 files changed, 33 insertions(+), 31 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CF8C43610 for ; Mon, 26 Nov 2018 22:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 877D42082F for ; Mon, 26 Nov 2018 22:18:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="vkeurhET" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 877D42082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=osandov.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727076AbeK0JOR (ORCPT ); Tue, 27 Nov 2018 04:14:17 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:37879 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727279AbeK0JOQ (ORCPT ); Tue, 27 Nov 2018 04:14:16 -0500 Received: by mail-pl1-f193.google.com with SMTP id b5so14559086plr.4 for ; Mon, 26 Nov 2018 14:18:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nnRkIidyTMCkCU8s4XbXhP39Wm67YCXxFtSWO/jSdU8=; b=vkeurhETkMrogwJmGI3eGa62QwDe4P+LcCcTlzyvWMH3ofHRs0MY6V2ZMtGLgSIJu8 5TKpaf4v3xugYKohlsROKlKr07KQ+fgqw8xPMYAd536f4Bcp9YPfRYXrheq/uNZ/k/Hb wJwj0EW2vCOTGMz6LZxSHYJYkjrZeU+oOJuwmjTOrb2V2IsCRhZ682+Sz0kpWUHauGPg MLttGBLspbnFV4OAasq9Um7tqAJHWSITMjVpHsB7yZ2axltVtfxE7yy5GyNpYGRJpHTd MRHF3qI73pJ/mlDJxZyYTiTvRj8vsLSXGxzswrshkk4UkJIMQ7P+yk2ARm3KaeDpD2oQ elNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nnRkIidyTMCkCU8s4XbXhP39Wm67YCXxFtSWO/jSdU8=; b=EjmCPqTMvXXQ5vj0Q2o0OHjljLne827wYoTEOgkuFkRcCVJOINpttUTd/pssHhmzkV ehOQsRKLuNcKdAeZf6n4Xk7EmeiaECzj9q8nJ5W8g+dg33yyYTAL18gXLQvb5u26UYDQ CuBZgvAV4SabjhpuiMPLtnw5Mo1So1OzWRc0w41UjXkFrYtxbV8yGwKu1s4fV/ZsWMTp 7ugGuKdkfESNxXsmUur4PHRu7c84Jc9M2wFaUB7W6sZMEEnpQ0BXgx3hMUwlUYplB9ey tds57k42UB8HxzhzMPrjJ5xG0srnvF83cyzv9uCwz1TSpPM+3ua/TyYIUzAXhIwp8FHX fr/g== X-Gm-Message-State: AA+aEWYfUlTweOAKBjgk1Zt95XxfReQUc2Fd1xilpNVLNVohz1WvN3jI 9b2x8aeaczDecRdxkS1uuN5tdw== X-Google-Smtp-Source: AFSGD/UZvPnmXOxr18I1aqWNh2aCKHb4dIcemmTBolztFwKCRREIPoguVnvpQPIq5Z5KW+MHH3uPZA== X-Received: by 2002:a17:902:8214:: with SMTP id x20-v6mr28569658pln.224.1543270720790; Mon, 26 Nov 2018 14:18:40 -0800 (PST) Received: from vader ([2601:602:8b00:55d3:e6a7:a0ff:fe0b:c9a8]) by smtp.gmail.com with ESMTPSA id u69sm1721000pfj.116.2018.11.26.14.18.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 14:18:38 -0800 (PST) Date: Mon, 26 Nov 2018 14:18:35 -0800 From: Omar Sandoval To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V12 06/20] block: rename bvec helpers Message-ID: <20181126221835.GG30411@vader> References: <20181126021720.19471-1-ming.lei@redhat.com> <20181126021720.19471-7-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181126021720.19471-7-ming.lei@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Nov 26, 2018 at 10:17:06AM +0800, Ming Lei wrote: > We will support multi-page bvec soon, and have to deal with > single-page vs multi-page bvec. This patch follows Christoph's > suggestion to rename all the following helpers: > > for_each_bvec > bvec_iter_bvec > bvec_iter_len > bvec_iter_page > bvec_iter_offset > > into: > for_each_segment > segment_iter_bvec > segment_iter_len > segment_iter_page > segment_iter_offset > > so that these helpers named with 'segment' only deal with single-page > bvec, or called segment. We will introduce helpers named with 'bvec' > for multi-page bvec. > > bvec_iter_advance() isn't renamed becasue this helper is always operated > on real bvec even though multi-page bvec is supported. > > Suggested-by: Christoph Hellwig Reviewed-by: Omar Sandoval > Signed-off-by: Ming Lei > --- > .clang-format | 2 +- > drivers/md/dm-integrity.c | 2 +- > drivers/md/dm-io.c | 4 ++-- > drivers/nvdimm/blk.c | 4 ++-- > drivers/nvdimm/btt.c | 4 ++-- > include/linux/bio.h | 10 +++++----- > include/linux/bvec.h | 20 +++++++++++--------- > include/linux/ceph/messenger.h | 2 +- > lib/iov_iter.c | 2 +- > net/ceph/messenger.c | 14 +++++++------- > 10 files changed, 33 insertions(+), 31 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Omar Sandoval Date: Mon, 26 Nov 2018 14:18:35 -0800 Subject: [Cluster-devel] [PATCH V12 06/20] block: rename bvec helpers In-Reply-To: <20181126021720.19471-7-ming.lei@redhat.com> References: <20181126021720.19471-1-ming.lei@redhat.com> <20181126021720.19471-7-ming.lei@redhat.com> Message-ID: <20181126221835.GG30411@vader> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Nov 26, 2018 at 10:17:06AM +0800, Ming Lei wrote: > We will support multi-page bvec soon, and have to deal with > single-page vs multi-page bvec. This patch follows Christoph's > suggestion to rename all the following helpers: > > for_each_bvec > bvec_iter_bvec > bvec_iter_len > bvec_iter_page > bvec_iter_offset > > into: > for_each_segment > segment_iter_bvec > segment_iter_len > segment_iter_page > segment_iter_offset > > so that these helpers named with 'segment' only deal with single-page > bvec, or called segment. We will introduce helpers named with 'bvec' > for multi-page bvec. > > bvec_iter_advance() isn't renamed becasue this helper is always operated > on real bvec even though multi-page bvec is supported. > > Suggested-by: Christoph Hellwig Reviewed-by: Omar Sandoval > Signed-off-by: Ming Lei > --- > .clang-format | 2 +- > drivers/md/dm-integrity.c | 2 +- > drivers/md/dm-io.c | 4 ++-- > drivers/nvdimm/blk.c | 4 ++-- > drivers/nvdimm/btt.c | 4 ++-- > include/linux/bio.h | 10 +++++----- > include/linux/bvec.h | 20 +++++++++++--------- > include/linux/ceph/messenger.h | 2 +- > lib/iov_iter.c | 2 +- > net/ceph/messenger.c | 14 +++++++------- > 10 files changed, 33 insertions(+), 31 deletions(-)