From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Yang Xiao <YangX92@hotmail.com>
Cc: "r.weclawski@gmail.com" <r.weclawski@gmail.com>,
"straube.linux@gmail.com" <straube.linux@gmail.com>,
"santhameena13@gmail.com" <santhameena13@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"jananis37@gmail.com" <jananis37@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c
Date: Tue, 27 Nov 2018 08:57:50 +0100 [thread overview]
Message-ID: <20181127075750.GA929@kroah.com> (raw)
In-Reply-To: <HK0PR01MB216364A68D785B7EBC8DD43EADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
On Tue, Nov 27, 2018 at 07:29:07AM +0000, Yang Xiao wrote:
> From: Young_X <YangX92@hotmail.com>
Please use your "full" name like you did in your from: line of your
email
>
> The error at line 3267 was the result of an off-by-one error in
> a for loop in line 3253.
> If condition in line 3254 never satisfies, then the value of
> pstat->aid is NUM_STA+1. This will lead to out-of-bound access
> in line 3267.
Why is this indented? No need for that.
Can you fix that up and resend?
thanks,
greg k-h
next parent reply other threads:[~2018-11-27 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <HK0PR01MB216364A68D785B7EBC8DD43EADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
2018-11-27 7:57 ` gregkh [this message]
2018-11-27 8:15 ` [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c Dan Carpenter
[not found] ` <HK0PR01MB2163A0287797ECA3CDA68AA2ADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
2018-11-27 8:34 ` Dan Carpenter
[not found] ` <HK0PR01MB2163FB565C3ADD4BCE1FE7D2ADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
2018-11-27 8:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127075750.GA929@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=YangX92@hotmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=jananis37@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=r.weclawski@gmail.com \
--cc=santhameena13@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.