All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
	davem@davemloft.net, richardcochran@gmail.com,
	sudipm.mukherjee@gmail.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails
Date: Tue, 27 Nov 2018 09:54:48 +0100	[thread overview]
Message-ID: <20181127085448.GA29599@kroah.com> (raw)
In-Reply-To: <53ba0e4e-5848-e6cb-4abf-39db292ba7f3@enneenne.com>

On Tue, Nov 27, 2018 at 09:36:38AM +0100, Rodolfo Giometti wrote:
> On 27/11/2018 08:34, Greg KH wrote:
> > On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote:
> > > On 26/11/2018 11:24, YueHaibing wrote:
> > > > pps_register_source() has keeps error codes in a local variable,
> > > > but it does not make use of the code. This patch let it return
> > > > the errcode in case of failure.
> > > > 
> > > > Suggested-by: Richard Cochran <richardcochran@gmail.com>
> > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > > 
> > > Acked-by: Rodolfo Giometti <giometti@enneenne.com>
> > 
> > You are the maintainer of this file, shouldn't you be the one sending it
> > off to Linus or putting it in your tree somewhere?
> 
> This subsystem never had an official tree and in the past I simply acked the
> code and patches was taken by you (or other maintainers) for inclusion... I
> know it's not usual by it worked as is since right now!
> 
> However if you prefer having an official tree even for LinuxPPS I can do it
> and then sending my pull requests to Linus! Just let me know what is better
> for you! :-)

Ok, I'll take it now, thanks.

greg k-h

      reply	other threads:[~2018-11-27  8:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 10:24 [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails YueHaibing
2018-11-26 10:43 ` Rodolfo Giometti
2018-11-27  7:34   ` Greg KH
2018-11-27  8:36     ` Rodolfo Giometti
2018-11-27  8:54       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181127085448.GA29599@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=giometti@enneenne.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.