From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD3AC43441 for ; Tue, 27 Nov 2018 12:37:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80D782082F for ; Tue, 27 Nov 2018 12:37:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vjoGONHI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80D782082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729019AbeK0Xfc (ORCPT ); Tue, 27 Nov 2018 18:35:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:34966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726544AbeK0Xfc (ORCPT ); Tue, 27 Nov 2018 18:35:32 -0500 Received: from quaco.infradead.org (unknown [190.15.121.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2026A208E4; Tue, 27 Nov 2018 12:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543322264; bh=1xcnuaSSDOL89XKWstZVl6ixiUj/nF89Rm+ukEgNoqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vjoGONHIOWPlwkj1GtGQaYfKnH9swRobMhA4UFeS/tO/o0nMWuL/kt8zzsO24/KGT JXcgHV9HNcCSAlzloc4FsYnOTdlDE0Ul/G38iY7x8OTJNHS15Gowy9X0ctNqA3kdGW 4UNMNBeEig0lcyz6Ts6/18QMuaRvGrOGZvBf1E8E= Received: by quaco.infradead.org (Postfix, from userid 1000) id F3C9E41114; Tue, 27 Nov 2018 09:37:41 -0300 (-03) Date: Tue, 27 Nov 2018 09:37:41 -0300 From: Arnaldo Carvalho de Melo To: Ravi Bangoria Cc: Jiri Olsa , alexander.shishkin@linux.intel.com, namhyung@kernel.org, yao.jin@linux.intel.com, linux-kernel@vger.kernel.org, yuzhoujian@didichuxing.com, tmricht@linux.vnet.ibm.com, anton@samba.org Subject: Re: [PATCH] perf stat: Fix shadow stats for clock events Message-ID: <20181127123741.GA15747@kernel.org> References: <20181115141745.GJ9600@krava> <20181116042843.24067-1-ravi.bangoria@linux.ibm.com> <20181116133555.GA30465@krava> <2f319b94-8d6c-581b-19f3-43a1ab5774ef@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f319b94-8d6c-581b-19f3-43a1ab5774ef@linux.ibm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Nov 27, 2018 at 01:50:44PM +0530, Ravi Bangoria escreveu: > > > On 11/16/18 7:05 PM, Jiri Olsa wrote: > > On Fri, Nov 16, 2018 at 09:58:43AM +0530, Ravi Bangoria wrote: > >> Commit 0aa802a79469 ("perf stat: Get rid of extra clock display > >> function") introduced scale and unit for clock events. Thus, > >> perf_stat__update_shadow_stats() now saves scaled values of > >> clock events in msecs, instead of original nsecs. But while > >> calculating values of shadow stats we still consider clock > >> event values in nsecs. This results in a wrong shadow stat > >> values. Ex, > >> > >> # ./perf stat -e task-clock,cycles ls > >> > >> 2.60 msec task-clock:u # 0.877 CPUs utilized > >> 2,430,564 cycles:u # 1215282.000 GHz > >> > >> Fix this by saving original nsec values for clock events in > >> perf_stat__update_shadow_stats(). After patch: > >> > >> # ./perf stat -e task-clock,cycles ls > >> > >> 3.14 msec task-clock:u # 0.839 CPUs utilized > >> 3,094,528 cycles:u # 0.985 GHz > >> > >> Reported-by: Anton Blanchard > >> Suggested-by: Jiri Olsa > >> Fixes: 0aa802a79469 ("perf stat: Get rid of extra clock display function") > >> Signed-off-by: Ravi Bangoria > > > > Reviewed-by: Jiri Olsa > > Hi Arnaldo, Please pull this. I did it yesterday, its just that I installed a new notebook and the MTA was down :-\ All should be fixed by now and the patch should go Ingo's way soon. - Arnaldo