From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: x86/mce/AMD: Make sure banks were initialized before accessing them From: Borislav Petkov Message-Id: <20181127123828.GC26395@zn.tnic> Date: Tue, 27 Nov 2018 13:38:28 +0100 To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , John Clemens , Yazen Ghannam Cc: Tony Luck , linux-edac@vger.kernel.org, Aravind Gopalakrishnan , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= List-ID: T24gVHVlLCBOb3YgMjcsIDIwMTggYXQgMDE6MDk6MjBQTSArMDEwMCwgQm9yaXNsYXYgUGV0a292 IHdyb3RlOgo+IE9uIFR1ZSwgTm92IDI3LCAyMDE4IGF0IDExOjE3OjAwQU0gKzAxMDAsIFJhZmHF giBNacWCZWNraSB3cm90ZToKPiA+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNr aS5wbD4KPiA+IAo+ID4gSXQgbWF5IGhhcHBlbiBhbWRfdGhyZXNob2xkX2ludGVycnVwdCgpIGZp cmVzIGJlZm9yZSBiYW5rcyBnZXQgc2V0dXAgYXMKPiA+IHBhcnQgb2YgdGhlIHRocmVzaG9sZF9p bml0X2RldmljZSgpIGNhbGwuIFN1Y2ggYSBjYXNlIHJlcXVpcmVzIGEgcHJvcGVyCj4gPiBjaGVj ayB0byBhdm9pZCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UuCj4gCj4gWWVhaCwgYW5kIHRoaXMg Y29kZSBpcyB3cm9uZyBhcyBoZWxsLiA6LVwKCkpvaG4sIGRvZXMgdGhlIGJlbG93IGh1bmsgaGVs cCBib290aW5nPwoKWW91IG1pZ2h0IHN0aWxsIHNlZQoKICAiVW5leHBlY3RlZCB0aHJlc2hvbGQg aW50ZXJydXB0IGF0IHZlY3RvciBmOSIKCm9yIHNvIGJ1dCB5b3Ugc2hvdWxkIHN0aWxsIGJlIGFi bGUgdG8gYm9vdC4KCkBZYXplbiwgYnR3IGxvb2sgYXQgdGhlIGJ1Z3ppbGxhIGVudHJ5IC0gZG1l c2cgaGFzIGEgYnVuY2ggb2YgTUNFcyBkdXJpbmcgYm9vdDoKClsgICAgMi4wMDExNzhdIG1jZTog W0hhcmR3YXJlIEVycm9yXTogTWFjaGluZSBjaGVjayBldmVudHMgbG9nZ2VkClsgICAgMi4wMDEz MDJdIG1jZTogW0hhcmR3YXJlIEVycm9yXTogQ1BVIDQ6IE1hY2hpbmUgQ2hlY2s6IDAgQmFuayAx OiBkODIwMDAwMDAwMGEwMTUxClsgICAgMi4wMDEzMDldIG1jZTogW0hhcmR3YXJlIEVycm9yXTog VFNDIGU0NWVlNzEyNCBNSVNDIGQwMWIwZmZmMDAwMDAwMDAgU1lORCA0YTAwMDAwMCBJUElEIDEw MGIwMDAwMDAwMDAKWyAgICAyLjAwMTMxN10gbWNlOiBbSGFyZHdhcmUgRXJyb3JdOiBQUk9DRVNT T1IgMjo4MTBmMTAgVElNRSAxNTM4MjcxMjk3IFNPQ0tFVCAwIEFQSUMgNCBtaWNyb2NvZGUgODEw MTAwYgoKaG93IGRvIHdlIGRlY29kZSB0aG9zZSBuZXcgb25lcyBpZiB0aGUgRURBQyBkZWNvZGVy IGlzIG5vdCBsb2FkZWQ/IEkuZS4sCmJ5IGhhbmQ/IFdlIHByb2JhYmx5IG5lZWQgc29tZSBJUElE IG1hcHBpbmcgb3Igc28uLi4KCkFuZCBhbHNvLCB3aHkgaXMgaGlzIGJveCBzcGV3aW5nIHNvIG1h bnkgb2YgdGhvc2UsIGl0IGlzIHRyeWluZyB0byB0ZWxsCnVzIHNvbWV0aGluZy4gOi0pCgpUaHgu CgpkaWZmIC0tZ2l0IGEvYXJjaC94ODYva2VybmVsL2NwdS9tY2hlY2svbWNlX2FtZC5jIGIvYXJj aC94ODYva2VybmVsL2NwdS9tY2hlY2svbWNlX2FtZC5jCmluZGV4IGRkMzNjMzU3NTQ4Zi4uZTEy NDU0ZTIxYjhhIDEwMDY0NAotLS0gYS9hcmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9tY2VfYW1k LmMKKysrIGIvYXJjaC94ODYva2VybmVsL2NwdS9tY2hlY2svbWNlX2FtZC5jCkBAIC01Niw3ICs1 Niw3IEBACiAvKiBUaHJlc2hvbGQgTFZUIG9mZnNldCBpcyBhdCBNU1IweEMwMDAwNDEwWzE1OjEy XSAqLwogI2RlZmluZSBTTUNBX1RIUl9MVlRfT0ZGCTB4RjAwMAogCi1zdGF0aWMgYm9vbCB0aHJl c2hvbGRpbmdfZW47CitzdGF0aWMgYm9vbCB0aHJlc2hvbGRpbmdfaXJxX2VuOwogCiBzdGF0aWMg Y29uc3QgY2hhciAqIGNvbnN0IHRoX25hbWVzW10gPSB7CiAJImxvYWRfc3RvcmUiLApAQCAtNTM0 LDkgKzUzNCw4IEBAIHByZXBhcmVfdGhyZXNob2xkX2Jsb2NrKHVuc2lnbmVkIGludCBiYW5rLCB1 bnNpZ25lZCBpbnQgYmxvY2ssIHUzMiBhZGRyLAogCiBzZXRfb2Zmc2V0OgogCW9mZnNldCA9IHNl dHVwX0FQSUNfbWNlX3RocmVzaG9sZChvZmZzZXQsIG5ldyk7Ci0KLQlpZiAoKG9mZnNldCA9PSBu ZXcpICYmIChtY2VfdGhyZXNob2xkX3ZlY3RvciAhPSBhbWRfdGhyZXNob2xkX2ludGVycnVwdCkp Ci0JCW1jZV90aHJlc2hvbGRfdmVjdG9yID0gYW1kX3RocmVzaG9sZF9pbnRlcnJ1cHQ7CisJaWYg KG9mZnNldCA9PSBuZXcpCisJCXRocmVzaG9sZGluZ19pcnFfZW4gPSB0cnVlOwogCiBkb25lOgog CW1jZV90aHJlc2hvbGRfYmxvY2tfaW5pdCgmYiwgb2Zmc2V0KTsKQEAgLTEzNTcsOSArMTM1Niw2 IEBAIGludCBtY2VfdGhyZXNob2xkX3JlbW92ZV9kZXZpY2UodW5zaWduZWQgaW50IGNwdSkKIHsK IAl1bnNpZ25lZCBpbnQgYmFuazsKIAotCWlmICghdGhyZXNob2xkaW5nX2VuKQotCQlyZXR1cm4g MDsKLQogCWZvciAoYmFuayA9IDA7IGJhbmsgPCBtY2FfY2ZnLmJhbmtzOyArK2JhbmspIHsKIAkJ aWYgKCEocGVyX2NwdShiYW5rX21hcCwgY3B1KSAmICgxIDw8IGJhbmspKSkKIAkJCWNvbnRpbnVl OwpAQCAtMTM3Nyw5ICsxMzczLDYgQEAgaW50IG1jZV90aHJlc2hvbGRfY3JlYXRlX2RldmljZSh1 bnNpZ25lZCBpbnQgY3B1KQogCXN0cnVjdCB0aHJlc2hvbGRfYmFuayAqKmJwOwogCWludCBlcnIg PSAwOwogCi0JaWYgKCF0aHJlc2hvbGRpbmdfZW4pCi0JCXJldHVybiAwOwotCiAJYnAgPSBwZXJf Y3B1KHRocmVzaG9sZF9iYW5rcywgY3B1KTsKIAlpZiAoYnApCiAJCXJldHVybiAwOwpAQCAtMTQw OCw5ICsxNDAxLDYgQEAgc3RhdGljIF9faW5pdCBpbnQgdGhyZXNob2xkX2luaXRfZGV2aWNlKHZv aWQpCiB7CiAJdW5zaWduZWQgbGNwdSA9IDA7CiAKLQlpZiAobWNlX3RocmVzaG9sZF92ZWN0b3Ig PT0gYW1kX3RocmVzaG9sZF9pbnRlcnJ1cHQpCi0JCXRocmVzaG9sZGluZ19lbiA9IHRydWU7Ci0K IAkvKiB0byBoaXQgQ1BVcyBvbmxpbmUgYmVmb3JlIHRoZSBub3RpZmllciBpcyB1cCAqLwogCWZv cl9lYWNoX29ubGluZV9jcHUobGNwdSkgewogCQlpbnQgZXJyID0gbWNlX3RocmVzaG9sZF9jcmVh dGVfZGV2aWNlKGxjcHUpOwpAQCAtMTQxOSw2ICsxNDA5LDkgQEAgc3RhdGljIF9faW5pdCBpbnQg dGhyZXNob2xkX2luaXRfZGV2aWNlKHZvaWQpCiAJCQlyZXR1cm4gZXJyOwogCX0KIAorCWlmICh0 aHJlc2hvbGRpbmdfaXJxX2VuKQorCQltY2VfdGhyZXNob2xkX3ZlY3RvciA9IGFtZF90aHJlc2hv bGRfaW50ZXJydXB0OworCiAJcmV0dXJuIDA7CiB9CiAvKgo=