All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@bootlin.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: dts: sun8i: Add the H3/H5 CSI controller
Date: Tue, 27 Nov 2018 16:55:26 +0100	[thread overview]
Message-ID: <20181127155526.56b3h44axzo3jq43@flea> (raw)
In-Reply-To: <CAMty3ZCyFof967vsr7gi=hU2qGcX+A0C2LwLV4hgPCkm1Ta0wQ@mail.gmail.com>

On Tue, Nov 27, 2018 at 01:36:38PM +0530, Jagan Teki wrote:
> On Tue, Nov 27, 2018 at 1:24 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > On Tue, Nov 27, 2018 at 11:29:13AM +0530, Jagan Teki wrote:
> > > On Tue, Nov 20, 2018 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > >
> > > > From: Myl?ne Josserand <mylene.josserand@bootlin.com>
> > > >
> > > > The H3 and H5 features the same CSI controller that was initially found on
> > > > the A31.
> > > >
> > > > Add a DT node for it.
> > > >
> > > > Signed-off-by: Myl?ne Josserand <mylene.josserand@bootlin.com>
> > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > >
> > > > ---
> > > >
> > > > Changes from v3:
> > > >   - Removed the CSI MCLK pin from the default pin group
> > >
> > > If I'm not wrong, PE1 is CSI_MCLK and PE0 is CSI_PCLK so we have PE0
> > > and PE1 removed.
> >
> > i'm not sure what you mean, PCLK is still in that patch.
> 
> PE0 -> CSI_PCLK
> PE1 -> CSI_MCLK
> 
> So, removing CSI MCLK in "Changes from v3" means, removing PE1 right?
> but csi_pins removed PE0 which is CSI_PCLK, we need to remove PE1 from
> csi_pins and keep PE0. isn't it?

Ah, right. I've fixed it up while applying.

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181127/bb525883/attachment.sig>

      reply	other threads:[~2018-11-27 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 14:52 [PATCH v3] ARM: dts: sun8i: Add the H3/H5 CSI controller Maxime Ripard
2018-11-27  5:59 ` Jagan Teki
2018-11-27  7:53   ` Maxime Ripard
2018-11-27  8:06     ` Jagan Teki
2018-11-27 15:55       ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181127155526.56b3h44axzo3jq43@flea \
    --to=maxime.ripard@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.