All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: kaslevs@vmware.com
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: Fix record --date flag when sending tracing data to a listener
Date: Tue, 27 Nov 2018 22:21:12 -0500	[thread overview]
Message-ID: <20181127222112.7e07774c@vmware.local.home> (raw)
In-Reply-To: <20181114154328.14731-1-kaslevs@vmware.com>


Hi Slavomir,

One minor nit of this patch.

On Wed, 14 Nov 2018 17:43:28 +0200
kaslevs@vmware.com wrote:

> diff --git a/lib/traceevent/event-parse.c b/lib/traceevent/event-parse.c
> index 078ed5e..2e8031c 100644
> --- a/lib/traceevent/event-parse.c
> +++ b/lib/traceevent/event-parse.c
> @@ -5411,7 +5411,7 @@ void tep_event_info(struct trace_seq *s, struct tep_event_format *event,
>  
>  static bool is_timestamp_in_us(char *trace_clock, bool use_trace_clock)
>  {
> -	if (!use_trace_clock)
> +	if (!trace_clock || !use_trace_clock)
>  		return true;
>  
>  	if (!strcmp(trace_clock, "local") || !strcmp(trace_clock, "global")

This should be a separate patch, and it needs to be pushed to the Linux
kernel. Can you work with Tzvetomir in doing it?

Thanks!

-- Steve

      parent reply	other threads:[~2018-11-28 14:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14 15:43 [PATCH] trace-cmd: Fix record --date flag when sending tracing data to a listener kaslevs
2018-11-26 18:05 ` Steven Rostedt
2018-11-27 10:15   ` Slavomir Kaslev
2018-11-27 13:54     ` Steven Rostedt
2018-11-28  3:19     ` Steven Rostedt
2018-11-30 12:33       ` Slavomir Kaslev
2018-11-30 13:19         ` Slavomir Kaslev
2018-11-28  3:21 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181127222112.7e07774c@vmware.local.home \
    --to=rostedt@goodmis.org \
    --cc=kaslevs@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.