All of lore.kernel.org
 help / color / mirror / Atom feed
From: 배석진 <soukjin.bae@samsung.com>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: "Eric Dumazet" <eric.dumazet@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	유금환 <geumhwan.yu@samsung.com>,
	"Maciej Żenczykowski" <zenczykowski@gmail.com>,
	배석진 <soukjin.bae@samsung.com>
Subject: RE:(2) (2) FW: [Resource Leak] Suggesting patch for tcp_close
Date: Wed, 28 Nov 2018 17:49:09 +0900	[thread overview]
Message-ID: <20181128084909epcms1p64e84e47e798fcf949f58838d9aabab14@epcms1p6> (raw)
In-Reply-To: <CAKD1Yr14r6rGL8O9oofP9yQRN-i14HwG7nR2TNc4ua4eAfPrVg@mail.gmail.com>

> What harm is caused by these stale sessions? I thought that was the
> intended behaviour.
>

our system stability guys concern about this.
when its count grows up too much, whether it can be harm to system or not.

> If you look at the original design discussions that led to the
> SOCK_DESTROY and tcp_abort patch, the goal of SOCK_DESTROY was not
> primarily to clear TCP state, but primarily to unblock applications
> that were stuck in blocking socket operations such as read(), write()
> and connect. That is the reason why it only calls tcp_done if the
> SOCK_DEAD flag is not set. See in particular
> https://www.spinics.net/lists/netdev/msg352716.html , where opposition
> was voiced to being able to close sockets in TIME_WAIT_STATE. That
> said, I don't have a strong opinion on this: whatever works for Eric
> works for me.
> 

ok, i got your saying about purpose of SOCK_DESTROY.
maybe we have two options.
add a new point that can managing those tcp sessions.
or, just let it them.

thanks!

  parent reply	other threads:[~2018-11-28 19:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181123072258epcms1p8c41425598751be28f8cc05b91c7ac4b5@epcms1p8>
2018-11-23  7:22 ` Suggesting patch for tcp_close 배석진
     [not found]   ` <CGME20181123072258epcms1p8c41425598751be28f8cc05b91c7ac4b5@epcms1p7>
2018-11-28  1:09     ` FW: [Resource Leak] " 배석진
2018-11-28  4:57       ` Eric Dumazet
2018-11-28  4:58         ` Eric Dumazet
     [not found]       ` <CGME20181123072258epcms1p8c41425598751be28f8cc05b91c7ac4b5@epcms1p1>
2018-11-28  6:17         ` 배석진
2018-11-28  7:36           ` (2) " Lorenzo Colitti
     [not found]           ` <CGME20181123072258epcms1p8c41425598751be28f8cc05b91c7ac4b5@epcms1p6>
2018-11-28  8:49             ` 배석진 [this message]
2018-11-28 14:40           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128084909epcms1p64e84e47e798fcf949f58838d9aabab14@epcms1p6 \
    --to=soukjin.bae@samsung.com \
    --cc=eric.dumazet@gmail.com \
    --cc=geumhwan.yu@samsung.com \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=zenczykowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.