Re: [PATCH 11/17] kernel-shark-qt: Sort all graphs before plotting

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 28 Nov 2018 15:16:20 +0000
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:

> The CPU/Task graphs are plotted in sorted order. The graph
> having smallest CPU id/Pid will be plotted first (on top).

I'm fine with this. But I'm wondering if we want to allow the user to
move the plots in the future, if that would be a big design change or
not.

-- Steve

> 
> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
> ---
>  kernel-shark-qt/src/KsTraceGraph.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel-shark-qt/src/KsTraceGraph.cpp b/kernel-shark-qt/src/KsTraceGraph.cpp
> index 09b322a..0b5a8b1 100644
> --- a/kernel-shark-qt/src/KsTraceGraph.cpp
> +++ b/kernel-shark-qt/src/KsTraceGraph.cpp
> @@ -439,6 +439,7 @@ void KsTraceGraph::addCPUPlot(int cpu)
>  		return;
>  
>  	_glWindow._cpuList.append(cpu);
> +	qSort(_glWindow._cpuList);
>  	_selfUpdate();
>  }
>  
> @@ -449,6 +450,7 @@ void KsTraceGraph::addTaskPlot(int pid)
>  		return;
>  
>  	_glWindow._taskList.append(pid);
> +	qSort(_glWindow._taskList);
>  	_selfUpdate();
>  }
>