From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] xen: remove trailing spaces from public headers
Date: Wed, 28 Nov 2018 13:32:42 +0000 [thread overview]
Message-ID: <20181128133242.ehso5ga72acvdv3r@zion.uk.xensource.com> (raw)
In-Reply-To: <cf3c2377-d073-7838-435f-9f3e0d48ec61@suse.com>
On Wed, Nov 28, 2018 at 02:17:55PM +0100, Juergen Gross wrote:
> On 28/11/2018 13:52, Jan Beulich wrote:
> >>>> On 28.11.18 at 13:32, <jgross@suse.com> wrote:
> >> Several public header files have trailing spaces in them. This is
> >> rather annoying when importing them into other projects as they might
> >> be rejected not complying to coding style.
> >>
> >> Remove the trailing spaces in all headers below xen/include/public/.
> >>
> >> Signed-off-by: Juergen Gross <jgross@suse.com>
> >> ---
> >> I have omitted tmem.h in order to avoid a conflict with Wei's tmem
> >> removal series.
> >
> > To be honest I'm not convinced removing the public header would
> > be an appropriate step to take.
>
> In case it is kept I can easily send a followup patch to remove the two
> trailing spaces in there.
There is no need for a follow-up patch. I will handle that myself in my
series. I plan to commit your patch rather soon.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-11-28 13:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 12:32 [PATCH] xen: remove trailing spaces from public headers Juergen Gross
2018-11-28 12:36 ` Wei Liu
2018-11-28 12:47 ` Andrew Cooper
2018-11-28 12:52 ` Jan Beulich
2018-11-28 12:57 ` Wei Liu
2018-11-28 13:09 ` Jan Beulich
2018-11-28 13:20 ` Wei Liu
2018-11-28 13:17 ` Juergen Gross
2018-11-28 13:32 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128133242.ehso5ga72acvdv3r@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.