From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v4 4/6] microcode: don't call apply_microcode() in cpu_request_microcode() Date: Wed, 28 Nov 2018 16:02:25 +0100 Message-ID: <20181128150225.4axdecgu33xlwwzu@mac> References: <1543383256-12371-1-git-send-email-chao.gao@intel.com> <1543383256-12371-5-git-send-email-chao.gao@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gS1PK-0005Jt-Ms for xen-devel@lists.xenproject.org; Wed, 28 Nov 2018 15:05:42 +0000 Content-Disposition: inline In-Reply-To: <1543383256-12371-5-git-send-email-chao.gao@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Chao Gao Cc: xen-devel@lists.xenproject.org, Wei Liu , Jan Beulich , Andrew Cooper List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBOb3YgMjgsIDIwMTggYXQgMDE6MzQ6MTRQTSArMDgwMCwgQ2hhbyBHYW8gd3JvdGU6 Cj4gY3B1X3JlcXVlc3RfbWljcm9jb2RlKCkgd2lsbCBvbmx5IHBhcnNlIG1pY3JvY29kZSBmaWxl IGFuZCBzYXZlCj4gc3VpdGFibGUgbWljcm9jb2RlcyB0byBtaWNyb2NvZGVfY2FjaGUuIFRvIHVw ZGF0ZSBtaWNyb2NvZGUsCj4gYXBwbHlfbWljcm9jb2RlKCkgc2hvdWxkIGJlIGludm9rZWQgZXhw bGljaXRseS4KPiAKPiBPbiBBTUQgc2lkZSwgc3ZtX2hvc3Rfb3N2d19pbml0KCkgaXMgc3VwcG9z ZWQgdG8gYmUgY2FsbGVkIGFmdGVyCj4gbWljcm9jb2RlIHVwZGF0ZS4gQXMgYXBwbHlfbWljcmNv ZGUoKSB3b24ndCBiZSBjYWxsZWQgYnkKPiBjcHVfcmVxdWVzdF9taWNyb2NvZGUoKSBub3csIHN2 bV9ob3N0X29zdndfaW5pdCgpIGlzIGFsc28gbW92ZWQgdG8gdGhlCj4gZW5kIG9mIGFwcGx5X21p Y3JvY29kZSgpLgoKSSBkb24ndCB1bmRlcnN0YW5kIHRoZSBwcmV2aW91cyB1c2FnZSBvZiBjcHVf cmVxdWVzdF9taWNyb2NvZGUsIHdhcyBpdAp1c2VkIHRvIHVwZGF0ZSB0aGUgbWljcm9jb2RlPyBU aGUgbmFtZSBzZWVtcyB0byBzdWdnZXN0IGl0J3MgdXNlZCB0bwpnZXQgYSBtaWNyb2NvZGUgdmVy c2lvbiB3aXRob3V0IGFwcGx5aW5nIGFueXRoaW5nIHRvIHRoZSBDUFUuCgo+IAo+IFNpZ25lZC1v ZmYtYnk6IENoYW8gR2FvIDxjaGFvLmdhb0BpbnRlbC5jb20+Cj4gLS0tCj4gIHhlbi9hcmNoL3g4 Ni9taWNyb2NvZGUuYyAgICAgICB8IDU4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLQo+ICB4ZW4vYXJjaC94ODYvbWljcm9jb2RlX2FtZC5jICAgfCAxNSArKysrKy0t LS0tLQo+ICB4ZW4vYXJjaC94ODYvbWljcm9jb2RlX2ludGVsLmMgfCAgNSArLS0tCj4gIDMgZmls ZXMgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL3hlbi9hcmNoL3g4Ni9taWNyb2NvZGUuYyBiL3hlbi9hcmNoL3g4Ni9taWNyb2NvZGUu Ywo+IGluZGV4IDgzNTBkMjIuLmNjYTdiMmMgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L21p Y3JvY29kZS5jCj4gKysrIGIveGVuL2FyY2gveDg2L21pY3JvY29kZS5jCj4gQEAgLTIzMywyMCAr MjMzLDEyIEBAIGludCBtaWNyb2NvZGVfcmVzdW1lX2NwdSh1bnNpZ25lZCBpbnQgY3B1KQo+ICAg ICAgcmV0dXJuIGVycjsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBtaWNyb2NvZGVfdXBkYXRlX2Nw dShjb25zdCB2b2lkICpidWYsIHNpemVfdCBzaXplKQo+ICtzdGF0aWMgaW50IG1pY3JvY29kZV91 cGRhdGVfY3B1KHZvaWQpCj4gIHsKPiAgICAgIGludCBlcnI7Cj4gLSAgICB1bnNpZ25lZCBpbnQg Y3B1ID0gc21wX3Byb2Nlc3Nvcl9pZCgpOwo+IC0gICAgc3RydWN0IHVjb2RlX2NwdV9pbmZvICp1 Y2kgPSAmcGVyX2NwdSh1Y29kZV9jcHVfaW5mbywgY3B1KTsKPiAgCj4gICAgICBzcGluX2xvY2so Jm1pY3JvY29kZV9tdXRleCk7Cj4gLQo+IC0gICAgZXJyID0gbWljcm9jb2RlX29wcy0+Y29sbGVj dF9jcHVfaW5mbyhjcHUsICZ1Y2ktPmNwdV9zaWcpOwo+IC0gICAgaWYgKCBsaWtlbHkoIWVycikg KQo+IC0gICAgICAgIGVyciA9IG1pY3JvY29kZV9vcHMtPmNwdV9yZXF1ZXN0X21pY3JvY29kZShj cHUsIGJ1Ziwgc2l6ZSk7Cj4gLSAgICBlbHNlCj4gLSAgICAgICAgX19taWNyb2NvZGVfZmluaV9j cHUoY3B1KTsKPiAtCj4gKyAgICBlcnIgPSBtaWNyb2NvZGVfb3BzLT5hcHBseV9taWNyb2NvZGUo c21wX3Byb2Nlc3Nvcl9pZCgpKTsKPiAgICAgIHNwaW5fdW5sb2NrKCZtaWNyb2NvZGVfbXV0ZXgp Owo+ICAKPiAgICAgIHJldHVybiBlcnI7Cj4gQEAgLTI1OSw3ICsyNTEsNyBAQCBzdGF0aWMgbG9u ZyBkb19taWNyb2NvZGVfdXBkYXRlKHZvaWQgKl9pbmZvKQo+ICAKPiAgICAgIEJVR19PTihpbmZv LT5jcHUgIT0gc21wX3Byb2Nlc3Nvcl9pZCgpKTsKPiAgCj4gLSAgICBlcnJvciA9IG1pY3JvY29k ZV91cGRhdGVfY3B1KGluZm8tPmJ1ZmZlciwgaW5mby0+YnVmZmVyX3NpemUpOwo+ICsgICAgZXJy b3IgPSBtaWNyb2NvZGVfdXBkYXRlX2NwdSgpOwoKV2h5IGRvbid0IHlvdSBqdXN0IHNldCBpbmZv LT5lcnJvciA9IG1pY3JvY29kZV91cGRhdGVfY3B1KCk/CgpBRkFJQ1QgdGhpcyBpcyBkb25lIHRv IGF0dGVtcHQgdG8gdXBkYXRlIHRoZSByZW1haW5pbmcgQ1BVcyBpZiBvbmUKdXBkYXRlIGZhaWxl ZD8KCklzIHRoZXJlIGFueXdheSB0byByb2xsYmFjayB0byB0aGUgcHJldmlvdXMgc3RhdGUgc28g YWxsIENQVXMgaGF2ZSB0aGUKc2FtZSBtaWNyb2NvZGU/IEkgYXNzdW1lIG5vdGhpbmcgZ29vZCB3 aWxsIGNvbWUgb3V0IG9mIHJ1bm5pbmcgYQpzeXN0ZW0gd2l0aCBDUFVzIHVzaW5nIGRpZmZlcmVu dCBtaWNyb2NvZGUgdmVyc2lvbnMsIGJ1dCBtYXliZSB0aGF0J3MKbm90IHNvIGJhZD8KCj4gICAg ICBpZiAoIGVycm9yICkKPiAgICAgICAgICBpbmZvLT5lcnJvciA9IGVycm9yOwo+ICAKPiBAQCAt Mjc2LDYgKzI2OCw4IEBAIGludCBtaWNyb2NvZGVfdXBkYXRlKFhFTl9HVUVTVF9IQU5ETEVfUEFS QU0oY29uc3Rfdm9pZCkgYnVmLCB1bnNpZ25lZCBsb25nIGxlbikKPiAgewo+ICAgICAgaW50IHJl dDsKPiAgICAgIHN0cnVjdCBtaWNyb2NvZGVfaW5mbyAqaW5mbzsKPiArICAgIHVuc2lnbmVkIGlu dCBjcHUgPSBzbXBfcHJvY2Vzc29yX2lkKCk7Cj4gKyAgICBzdHJ1Y3QgdWNvZGVfY3B1X2luZm8g KnVjaSA9ICZwZXJfY3B1KHVjb2RlX2NwdV9pbmZvLCBjcHUpOwo+ICAKPiAgICAgIGlmICggbGVu ICE9ICh1aW50MzJfdClsZW4gKQo+ICAgICAgICAgIHJldHVybiAtRTJCSUc7Cj4gQEAgLTI5NCwx MCArMjg4LDYgQEAgaW50IG1pY3JvY29kZV91cGRhdGUoWEVOX0dVRVNUX0hBTkRMRV9QQVJBTShj b25zdF92b2lkKSBidWYsIHVuc2lnbmVkIGxvbmcgbGVuKQo+ICAgICAgICAgIHJldHVybiByZXQ7 Cj4gICAgICB9Cj4gIAo+IC0gICAgaW5mby0+YnVmZmVyX3NpemUgPSBsZW47Cj4gLSAgICBpbmZv LT5lcnJvciA9IDA7Cj4gLSAgICBpbmZvLT5jcHUgPSBjcHVtYXNrX2ZpcnN0KCZjcHVfb25saW5l X21hcCk7Cj4gLQo+ICAgICAgaWYgKCBtaWNyb2NvZGVfb3BzLT5zdGFydF91cGRhdGUgKQo+ICAg ICAgewo+ICAgICAgICAgIHJldCA9IG1pY3JvY29kZV9vcHMtPnN0YXJ0X3VwZGF0ZSgpOwo+IEBA IC0zMDgsNiArMjk4LDI2IEBAIGludCBtaWNyb2NvZGVfdXBkYXRlKFhFTl9HVUVTVF9IQU5ETEVf UEFSQU0oY29uc3Rfdm9pZCkgYnVmLCB1bnNpZ25lZCBsb25nIGxlbikKPiAgICAgICAgICB9Cj4g ICAgICB9Cj4gIAo+ICsgICAgc3Bpbl9sb2NrKCZtaWNyb2NvZGVfbXV0ZXgpOwo+ICsKPiArICAg IHJldCA9IG1pY3JvY29kZV9vcHMtPmNvbGxlY3RfY3B1X2luZm8oY3B1LCAmdWNpLT5jcHVfc2ln KTsKPiArICAgIGlmICggbGlrZWx5KCFyZXQpICkKPiArICAgICAgICByZXQgPSBtaWNyb2NvZGVf b3BzLT5jcHVfcmVxdWVzdF9taWNyb2NvZGUoY3B1LCBpbmZvLT5idWZmZXIsIGxlbik7Cj4gKyAg ICBlbHNlCj4gKyAgICAgICAgX19taWNyb2NvZGVfZmluaV9jcHUoY3B1KTsKPiArCj4gKyAgICBz cGluX3VubG9jaygmbWljcm9jb2RlX211dGV4KTsKCldoeSBkbyB5b3UgbmVlZCB0byBob2xkIHRo ZSBsb2NrIGhlcmU/CgptaWNyb2NvZGVfdXBkYXRlIGlzIGFscmVhZHkgc2VyaWFsaXplZCBhbmQg c2hvdWxkIG9ubHkgYmUgZXhlY3V0ZWQgb24KYSBDUFUgYXQgYSB0aW1lIGR1ZSB0byB0aGUgdXNh Z2Ugb2YgY2hhaW5lZApjb250aW51ZV9oeXBlcmNhbGxfb25fY3B1LgoKPiArCj4gKyAgICBpZiAo IHJldCA8PSAwICkKPiArICAgIHsKPiArICAgICAgICBwcmludGsoIk5vIHZhbGlkIG9yIG5ld2Vy IG1pY3JvY29kZSBmb3VuZC4gVXBkYXRlIGFib3J0IVxuIik7Cj4gKyAgICAgICAgcmV0dXJuIC1F SU5WQUw7Cj4gKyAgICB9Cj4gKwo+ICsgICAgaW5mby0+YnVmZmVyX3NpemUgPSBsZW47Cj4gKyAg ICBpbmZvLT5lcnJvciA9IDA7Cj4gKyAgICBpbmZvLT5jcHUgPSBjcHVtYXNrX2ZpcnN0KCZjcHVf b25saW5lX21hcCk7Cj4gKwo+ICAgICAgcmV0dXJuIGNvbnRpbnVlX2h5cGVyY2FsbF9vbl9jcHUo aW5mby0+Y3B1LCBkb19taWNyb2NvZGVfdXBkYXRlLCBpbmZvKTsKPiAgfQo+ICAKPiBAQCAtMzcw LDEzICszODAsMjkgQEAgaW50IF9faW5pdCBlYXJseV9taWNyb2NvZGVfdXBkYXRlX2NwdShib29s IHN0YXJ0X3VwZGF0ZSkKPiAgICAgIH0KPiAgICAgIGlmICggZGF0YSApCj4gICAgICB7Cj4gKyAg ICAgICAgdW5zaWduZWQgaW50IGNwdSA9IHNtcF9wcm9jZXNzb3JfaWQoKTsKPiArICAgICAgICBz dHJ1Y3QgdWNvZGVfY3B1X2luZm8gKnVjaSA9ICZwZXJfY3B1KHVjb2RlX2NwdV9pbmZvLCBjcHUp Owo+ICsKPiAgICAgICAgICBpZiAoIHN0YXJ0X3VwZGF0ZSAmJiBtaWNyb2NvZGVfb3BzLT5zdGFy dF91cGRhdGUgKQo+ICAgICAgICAgICAgICByYyA9IG1pY3JvY29kZV9vcHMtPnN0YXJ0X3VwZGF0 ZSgpOwo+ICAKPiAgICAgICAgICBpZiAoIHJjICkKPiAgICAgICAgICAgICAgcmV0dXJuIHJjOwo+ ICAKPiAtICAgICAgICByZXR1cm4gbWljcm9jb2RlX3VwZGF0ZV9jcHUoZGF0YSwgbGVuKTsKPiAr ICAgICAgICBzcGluX2xvY2soJm1pY3JvY29kZV9tdXRleCk7Cj4gKwo+ICsgICAgICAgIHJjID0g bWljcm9jb2RlX29wcy0+Y29sbGVjdF9jcHVfaW5mbyhjcHUsICZ1Y2ktPmNwdV9zaWcpOwo+ICsg ICAgICAgIGlmICggbGlrZWx5KCFyYykgKQo+ICsgICAgICAgICAgICByYyA9IG1pY3JvY29kZV9v cHMtPmNwdV9yZXF1ZXN0X21pY3JvY29kZShjcHUsIGRhdGEsIGxlbik7Cj4gKyAgICAgICAgZWxz ZQo+ICsgICAgICAgICAgICBfX21pY3JvY29kZV9maW5pX2NwdShjcHUpOwo+ICsKPiArICAgICAg ICBzcGluX3VubG9jaygmbWljcm9jb2RlX211dGV4KTsKPiArCj4gKyAgICAgICAgaWYgKCByYyA8 PSAwICkKPiArICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsgICAgICAgIHJldHVy biBtaWNyb2NvZGVfdXBkYXRlX2NwdSgpOwo+ICAgICAgfQo+ICAgICAgZWxzZQo+ICAgICAgICAg IHJldHVybiAtRU5PTUVNOwo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvbWljcm9jb2RlX2Ft ZC5jIGIveGVuL2FyY2gveDg2L21pY3JvY29kZV9hbWQuYwo+IGluZGV4IDZlNjU5OGEuLjZkODYw ZjMgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L21pY3JvY29kZV9hbWQuYwo+ICsrKyBiL3hl bi9hcmNoL3g4Ni9taWNyb2NvZGVfYW1kLmMKPiBAQCAtMjk5LDYgKzI5OSwxMCBAQCBzdGF0aWMg aW50IGFwcGx5X21pY3JvY29kZSh1bnNpZ25lZCBpbnQgY3B1KQo+ICAKPiAgICAgIHVjaS0+Y3B1 X3NpZy5yZXYgPSByZXY7Cj4gIAo+ICsjaWYgQ09ORklHX0hWTQo+ICsgICAgc3ZtX2hvc3Rfb3N2 d19pbml0KCk7Cj4gKyNlbmRpZgo+ICsKPiAgICAgIHJldHVybiAwOwo+ICB9Cj4gIAo+IEBAIC00 NjYsNiArNDcwLDcgQEAgc3RhdGljIGludCBjcHVfcmVxdWVzdF9taWNyb2NvZGUodW5zaWduZWQg aW50IGNwdSwgY29uc3Qgdm9pZCAqYnVmLAo+ICAgICAgc3RydWN0IHVjb2RlX2NwdV9pbmZvICp1 Y2kgPSAmcGVyX2NwdSh1Y29kZV9jcHVfaW5mbywgY3B1KTsKPiAgICAgIHVuc2lnbmVkIGludCBj dXJyZW50X2NwdV9pZDsKPiAgICAgIHVuc2lnbmVkIGludCBlcXVpdl9jcHVfaWQ7Cj4gKyAgICB1 bnNpZ25lZCBpbnQgbWF0Y2hlZF9jbnQgPSAwOwo+ICAKPiAgICAgIC8qIFdlIHNob3VsZCBiaW5k IHRoZSB0YXNrIHRvIHRoZSBDUFUgKi8KPiAgICAgIEJVR19PTihjcHUgIT0gcmF3X3NtcF9wcm9j ZXNzb3JfaWQoKSk7Cj4gQEAgLTU3Miw5ICs1NzcsNyBAQCBzdGF0aWMgaW50IGNwdV9yZXF1ZXN0 X21pY3JvY29kZSh1bnNpZ25lZCBpbnQgY3B1LCBjb25zdCB2b2lkICpidWYsCj4gIAo+ICAgICAg ICAgIGlmICggbWljcm9jb2RlX2ZpdHMobWNfYW1kLCBjcHUpICkKPiAgICAgICAgICB7Cj4gLSAg ICAgICAgICAgIGVycm9yID0gYXBwbHlfbWljcm9jb2RlKGNwdSk7Cj4gLSAgICAgICAgICAgIGlm ICggZXJyb3IgKQo+IC0gICAgICAgICAgICAgICAgYnJlYWs7Cj4gKyAgICAgICAgICAgIG1hdGNo ZWRfY250Kys7Cj4gICAgICAgICAgICAgIGFwcGxpZWRfb2Zmc2V0ID0gbGFzdF9vZmZzZXQ7Cj4g ICAgICAgICAgfQo+ICAKPiBAQCAtNjA5LDE3ICs2MTIsMTMgQEAgc3RhdGljIGludCBjcHVfcmVx dWVzdF9taWNyb2NvZGUodW5zaWduZWQgaW50IGNwdSwgY29uc3Qgdm9pZCAqYnVmLAo+ICAgICAg fQo+ICAKPiAgICBvdXQ6Cj4gLSNpZiBDT05GSUdfSFZNCj4gLSAgICBzdm1faG9zdF9vc3Z3X2lu aXQoKTsKPiAtI2VuZGlmCj4gLQo+ICAgICAgLyoKPiAgICAgICAqIEluIHNvbWUgY2FzZXMgd2Ug bWF5IHJldHVybiBhbiBlcnJvciBldmVuIGlmIHByb2Nlc3NvcidzIG1pY3JvY29kZSBoYXMKPiAg ICAgICAqIGJlZW4gdXBkYXRlZC4gRm9yIGV4YW1wbGUsIHRoZSBmaXJzdCBwYXRjaCBpbiBhIGNv bnRhaW5lciBmaWxlIGlzIGxvYWRlZAo+ICAgICAgICogc3VjY2Vzc2Z1bGx5IGJ1dCBzdWJzZXF1 ZW50IGNvbnRhaW5lciBmaWxlIHByb2Nlc3NpbmcgZW5jb3VudGVycyBhCj4gICAgICAgKiBmYWls dXJlLgo+ICAgICAgICovCj4gLSAgICByZXR1cm4gZXJyb3I7Cj4gKyAgICByZXR1cm4gIWVycm9y ID8gbWF0Y2hlZF9jbnQgOiBlcnJvcjsKCllvdSBjYW4gdXNlIGVycm9yID86IG1hdGNoZWRfY250 OyB3aGljaCBpcyBzaG9ydGVyLgoKPiAgfQo+ICAKPiAgc3RhdGljIGludCBzdGFydF91cGRhdGUo dm9pZCkKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L21pY3JvY29kZV9pbnRlbC5jIGIveGVu L2FyY2gveDg2L21pY3JvY29kZV9pbnRlbC5jCj4gaW5kZXggMTg1NzMzMi4uYTUyOTYyMyAxMDA2 NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvbWljcm9jb2RlX2ludGVsLmMKPiArKysgYi94ZW4vYXJj aC94ODYvbWljcm9jb2RlX2ludGVsLmMKPiBAQCAtNDY2LDEwICs0NjYsNyBAQCBzdGF0aWMgaW50 IGNwdV9yZXF1ZXN0X21pY3JvY29kZSh1bnNpZ25lZCBpbnQgY3B1LCBjb25zdCB2b2lkICpidWYs Cj4gICAgICBpZiAoIG9mZnNldCA8IDAgKQo+ICAgICAgICAgIGVycm9yID0gb2Zmc2V0Owo+ICAK PiAtICAgIGlmICggIWVycm9yICYmIG1hdGNoaW5nX2NvdW50ICkKPiAtICAgICAgICBlcnJvciA9 IGFwcGx5X21pY3JvY29kZShjcHUpOwo+IC0KPiAtICAgIHJldHVybiBlcnJvcjsKPiArICAgIHJl dHVybiAhZXJyb3IgPyBtYXRjaGluZ19jb3VudCA6IGVycm9yOwoKU2FtZSBoZXJlLgoKVGhhbmtz LCBSb2dlci4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0 dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=