From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gS2um-000610-Gc for qemu-devel@nongnu.org; Wed, 28 Nov 2018 11:42:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gS2rq-0007nu-4b for qemu-devel@nongnu.org; Wed, 28 Nov 2018 11:39:16 -0500 Date: Wed, 28 Nov 2018 17:39:00 +0100 From: Kevin Wolf Message-ID: <20181128163900.GG4222@dhcp-200-186.str.redhat.com> References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-3-paul.durrant@citrix.com> <20181128161917.GE4222@dhcp-200-186.str.redhat.com> <48596f1fe100419c8b28ed54bda0117b@AMSPEX02CL03.citrite.net> <65af28818a724749839dcb6576e0413d@AMSPEX02CL03.citrite.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65af28818a724749839dcb6576e0413d@AMSPEX02CL03.citrite.net> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: 'Stefano Stabellini' , "qemu-block@nongnu.org" , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Anthony Perard , Paolo Bonzini , Richard Henderson Am 28.11.2018 um 17:29 hat Paul Durrant geschrieben: > > -----Original Message----- > > From: Stefano Stabellini [mailto:sstabellini@kernel.org] > > Sent: 28 November 2018 16:28 > > To: Paul Durrant > > Cc: 'Kevin Wolf' ; qemu-block@nongnu.org; qemu- > > devel@nongnu.org; xen-devel@lists.xenproject.org; Stefano Stabellini > > ; Eduardo Habkost ; Michael > > S. Tsirkin ; Marcel Apfelbaum > > ; Anthony Perard ; > > Paolo Bonzini ; Richard Henderson > > Subject: RE: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and > > 'XenDevice' object hierarchy > > > > On Wed, 28 Nov 2018, Paul Durrant wrote: > > > > -----Original Message----- > > > > From: Kevin Wolf [mailto:kwolf@redhat.com] > > > > Sent: 28 November 2018 16:19 > > > > To: Paul Durrant > > > > Cc: qemu-block@nongnu.org; qemu-devel@nongnu.org; xen- > > > > devel@lists.xenproject.org; Stefano Stabellini > > ; > > > > Eduardo Habkost ; Michael S. Tsirkin > > > > ; Marcel Apfelbaum ; > > Anthony > > > > Perard ; Paolo Bonzini > > ; > > > > Richard Henderson > > > > Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' > > and > > > > 'XenDevice' object hierarchy > > > > > > > > Am 21.11.2018 um 16:11 hat Paul Durrant geschrieben: > > > > > This patch adds the basic boilerplate for a 'XenBus' object that > > will > > > > act > > > > > as a parent to 'XenDevice' PV backends. > > > > > A new 'XenBridge' object is also added to connect XenBus to the > > system > > > > bus. > > > > > > > > > > The XenBus object is instantiated by a new xen_bus_init() function > > > > called > > > > > from the same sites as the legacy xen_be_init() function. > > > > > > > > > > Subsequent patches will flesh-out the functionality of these > > objects. > > > > > > > > > > Signed-off-by: Paul Durrant > > > > > > > > > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c > > > > > new file mode 100644 > > > > > index 0000000000..dede2d914a > > > > > --- /dev/null > > > > > +++ b/hw/xen/xen-bus.c > > > > > @@ -0,0 +1,125 @@ > > > > > +/* > > > > > + * Copyright (c) Citrix Systems Inc. > > > > > + * All rights reserved. > > > > > + */ > > > > > > > > This doesn't look very compatible with the GPL. In fact it might even > > > > make it illegal for the QEMU project to distribute this code. :-) > > > > > > > > Other files you add throughout the series seem to have the same > > problem. > > > > > > > > > > I was working on the assumption that a lack of explicit license meant > > that the overall project license as described in item 2 in LICENSE. Did I > > misinterpret that text? > > > > It's "All rights reserved." the problem > > Oh, I see. I'm happy to remove that. That would be better at least. I'm not sure about files that have a copyright header, but no license statement. Do such files exist yet in the source tree? To be on the safe side, I'd just stick with the established practice, which is having a license header in every file. By the way, in a later patch you remove the existing license header, which is different from the default license (because parts of the source file are GPL 2 only). If you can't prove that all such parts (and parts derived from them) have been removed, this is also a problem. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Date: Wed, 28 Nov 2018 17:39:00 +0100 Message-ID: <20181128163900.GG4222@dhcp-200-186.str.redhat.com> References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-3-paul.durrant@citrix.com> <20181128161917.GE4222@dhcp-200-186.str.redhat.com> <48596f1fe100419c8b28ed54bda0117b@AMSPEX02CL03.citrite.net> <65af28818a724749839dcb6576e0413d@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gS2rk-0007Ld-Mg for xen-devel@lists.xenproject.org; Wed, 28 Nov 2018 16:39:08 +0000 Content-Disposition: inline In-Reply-To: <65af28818a724749839dcb6576e0413d@AMSPEX02CL03.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: 'Stefano Stabellini' , Eduardo Habkost , "qemu-block@nongnu.org" , "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , Marcel Apfelbaum , Paolo Bonzini , Anthony Perard , "xen-devel@lists.xenproject.org" , Richard Henderson List-Id: xen-devel@lists.xenproject.org QW0gMjguMTEuMjAxOCB1bSAxNzoyOSBoYXQgUGF1bCBEdXJyYW50IGdlc2NocmllYmVuOgo+ID4g LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IFN0ZWZhbm8gU3RhYmVsbGluaSBb bWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmddCj4gPiBTZW50OiAyOCBOb3ZlbWJlciAyMDE4 IDE2OjI4Cj4gPiBUbzogUGF1bCBEdXJyYW50IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT4KPiA+ IENjOiAnS2V2aW4gV29sZicgPGt3b2xmQHJlZGhhdC5jb20+OyBxZW11LWJsb2NrQG5vbmdudS5v cmc7IHFlbXUtCj4gPiBkZXZlbEBub25nbnUub3JnOyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmc7IFN0ZWZhbm8gU3RhYmVsbGluaQo+ID4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBF ZHVhcmRvIEhhYmtvc3QgPGVoYWJrb3N0QHJlZGhhdC5jb20+OyBNaWNoYWVsCj4gPiBTLiBUc2ly a2luIDxtc3RAcmVkaGF0LmNvbT47IE1hcmNlbCBBcGZlbGJhdW0KPiA+IDxtYXJjZWwuYXBmZWxi YXVtQGdtYWlsLmNvbT47IEFudGhvbnkgUGVyYXJkIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29t PjsKPiA+IFBhb2xvIEJvbnppbmkgPHBib256aW5pQHJlZGhhdC5jb20+OyBSaWNoYXJkIEhlbmRl cnNvbiA8cnRoQHR3aWRkbGUubmV0Pgo+ID4gU3ViamVjdDogUkU6IFtRZW11LWJsb2NrXSBbUEFU Q0ggMDIvMThdIHhlbjogaW50cm9kdWNlIG5ldyAnWGVuQnVzJyBhbmQKPiA+ICdYZW5EZXZpY2Un IG9iamVjdCBoaWVyYXJjaHkKPiA+IAo+ID4gT24gV2VkLCAyOCBOb3YgMjAxOCwgUGF1bCBEdXJy YW50IHdyb3RlOgo+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiA+ID4gRnJv bTogS2V2aW4gV29sZiBbbWFpbHRvOmt3b2xmQHJlZGhhdC5jb21dCj4gPiA+ID4gU2VudDogMjgg Tm92ZW1iZXIgMjAxOCAxNjoxOQo+ID4gPiA+IFRvOiBQYXVsIER1cnJhbnQgPFBhdWwuRHVycmFu dEBjaXRyaXguY29tPgo+ID4gPiA+IENjOiBxZW11LWJsb2NrQG5vbmdudS5vcmc7IHFlbXUtZGV2 ZWxAbm9uZ251Lm9yZzsgeGVuLQo+ID4gPiA+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBT dGVmYW5vIFN0YWJlbGxpbmkKPiA+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsKPiA+ID4gPiBF ZHVhcmRvIEhhYmtvc3QgPGVoYWJrb3N0QHJlZGhhdC5jb20+OyBNaWNoYWVsIFMuIFRzaXJraW4K PiA+ID4gPiA8bXN0QHJlZGhhdC5jb20+OyBNYXJjZWwgQXBmZWxiYXVtIDxtYXJjZWwuYXBmZWxi YXVtQGdtYWlsLmNvbT47Cj4gPiBBbnRob255Cj4gPiA+ID4gUGVyYXJkIDxhbnRob255LnBlcmFy ZEBjaXRyaXguY29tPjsgUGFvbG8gQm9uemluaQo+ID4gPHBib256aW5pQHJlZGhhdC5jb20+Owo+ ID4gPiA+IFJpY2hhcmQgSGVuZGVyc29uIDxydGhAdHdpZGRsZS5uZXQ+Cj4gPiA+ID4gU3ViamVj dDogUmU6IFtRZW11LWJsb2NrXSBbUEFUQ0ggMDIvMThdIHhlbjogaW50cm9kdWNlIG5ldyAnWGVu QnVzJwo+ID4gYW5kCj4gPiA+ID4gJ1hlbkRldmljZScgb2JqZWN0IGhpZXJhcmNoeQo+ID4gPiA+ Cj4gPiA+ID4gQW0gMjEuMTEuMjAxOCB1bSAxNjoxMSBoYXQgUGF1bCBEdXJyYW50IGdlc2Nocmll YmVuOgo+ID4gPiA+ID4gVGhpcyBwYXRjaCBhZGRzIHRoZSBiYXNpYyBib2lsZXJwbGF0ZSBmb3Ig YSAnWGVuQnVzJyBvYmplY3QgdGhhdAo+ID4gd2lsbAo+ID4gPiA+IGFjdAo+ID4gPiA+ID4gYXMg YSBwYXJlbnQgdG8gJ1hlbkRldmljZScgUFYgYmFja2VuZHMuCj4gPiA+ID4gPiBBIG5ldyAnWGVu QnJpZGdlJyBvYmplY3QgaXMgYWxzbyBhZGRlZCB0byBjb25uZWN0IFhlbkJ1cyB0byB0aGUKPiA+ IHN5c3RlbQo+ID4gPiA+IGJ1cy4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGUgWGVuQnVzIG9iamVj dCBpcyBpbnN0YW50aWF0ZWQgYnkgYSBuZXcgeGVuX2J1c19pbml0KCkgZnVuY3Rpb24KPiA+ID4g PiBjYWxsZWQKPiA+ID4gPiA+IGZyb20gdGhlIHNhbWUgc2l0ZXMgYXMgdGhlIGxlZ2FjeSB4ZW5f YmVfaW5pdCgpIGZ1bmN0aW9uLgo+ID4gPiA+ID4KPiA+ID4gPiA+IFN1YnNlcXVlbnQgcGF0Y2hl cyB3aWxsIGZsZXNoLW91dCB0aGUgZnVuY3Rpb25hbGl0eSBvZiB0aGVzZQo+ID4gb2JqZWN0cy4K PiA+ID4gPiA+Cj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWwuZHVy cmFudEBjaXRyaXguY29tPgo+ID4gPiA+Cj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvaHcveGVuL3hl bi1idXMuYyBiL2h3L3hlbi94ZW4tYnVzLmMKPiA+ID4gPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0 Cj4gPiA+ID4gPiBpbmRleCAwMDAwMDAwMDAwLi5kZWRlMmQ5MTRhCj4gPiA+ID4gPiAtLS0gL2Rl di9udWxsCj4gPiA+ID4gPiArKysgYi9ody94ZW4veGVuLWJ1cy5jCj4gPiA+ID4gPiBAQCAtMCww ICsxLDEyNSBAQAo+ID4gPiA+ID4gKy8qCj4gPiA+ID4gPiArICogQ29weXJpZ2h0IChjKSBDaXRy aXggU3lzdGVtcyBJbmMuCj4gPiA+ID4gPiArICogQWxsIHJpZ2h0cyByZXNlcnZlZC4KPiA+ID4g PiA+ICsgKi8KPiA+ID4gPgo+ID4gPiA+IFRoaXMgZG9lc24ndCBsb29rIHZlcnkgY29tcGF0aWJs ZSB3aXRoIHRoZSBHUEwuIEluIGZhY3QgaXQgbWlnaHQgZXZlbgo+ID4gPiA+IG1ha2UgaXQgaWxs ZWdhbCBmb3IgdGhlIFFFTVUgcHJvamVjdCB0byBkaXN0cmlidXRlIHRoaXMgY29kZS4gOi0pCj4g PiA+ID4KPiA+ID4gPiBPdGhlciBmaWxlcyB5b3UgYWRkIHRocm91Z2hvdXQgdGhlIHNlcmllcyBz ZWVtIHRvIGhhdmUgdGhlIHNhbWUKPiA+IHByb2JsZW0uCj4gPiA+ID4KPiA+ID4KPiA+ID4gSSB3 YXMgd29ya2luZyBvbiB0aGUgYXNzdW1wdGlvbiB0aGF0IGEgbGFjayBvZiBleHBsaWNpdCBsaWNl bnNlIG1lYW50Cj4gPiB0aGF0IHRoZSBvdmVyYWxsIHByb2plY3QgbGljZW5zZSBhcyBkZXNjcmli ZWQgaW4gaXRlbSAyIGluIExJQ0VOU0UuIERpZCBJCj4gPiBtaXNpbnRlcnByZXQgdGhhdCB0ZXh0 Pwo+ID4gCj4gPiBJdCdzICJBbGwgcmlnaHRzIHJlc2VydmVkLiIgdGhlIHByb2JsZW0KPiAKPiBP aCwgSSBzZWUuIEknbSBoYXBweSB0byByZW1vdmUgdGhhdC4KClRoYXQgd291bGQgYmUgYmV0dGVy IGF0IGxlYXN0LiBJJ20gbm90IHN1cmUgYWJvdXQgZmlsZXMgdGhhdCBoYXZlIGEKY29weXJpZ2h0 IGhlYWRlciwgYnV0IG5vIGxpY2Vuc2Ugc3RhdGVtZW50LiBEbyBzdWNoIGZpbGVzIGV4aXN0IHll dCBpbgp0aGUgc291cmNlIHRyZWU/IFRvIGJlIG9uIHRoZSBzYWZlIHNpZGUsIEknZCBqdXN0IHN0 aWNrIHdpdGggdGhlCmVzdGFibGlzaGVkIHByYWN0aWNlLCB3aGljaCBpcyBoYXZpbmcgYSBsaWNl bnNlIGhlYWRlciBpbiBldmVyeSBmaWxlLgoKQnkgdGhlIHdheSwgaW4gYSBsYXRlciBwYXRjaCB5 b3UgcmVtb3ZlIHRoZSBleGlzdGluZyBsaWNlbnNlIGhlYWRlciwKd2hpY2ggaXMgZGlmZmVyZW50 IGZyb20gdGhlIGRlZmF1bHQgbGljZW5zZSAoYmVjYXVzZSBwYXJ0cyBvZiB0aGUgc291cmNlCmZp bGUgYXJlIEdQTCAyIG9ubHkpLiBJZiB5b3UgY2FuJ3QgcHJvdmUgdGhhdCBhbGwgc3VjaCBwYXJ0 cyAoYW5kIHBhcnRzCmRlcml2ZWQgZnJvbSB0aGVtKSBoYXZlIGJlZW4gcmVtb3ZlZCwgdGhpcyBp cyBhbHNvIGEgcHJvYmxlbS4KCktldmluCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGlu Zm8veGVuLWRldmVs