Re: [PATCH v3 07/13] fanotify: copy event fid info to user

From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
	Matthew Bobrowski <mbobrowski@mbobrowski.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 07/13] fanotify: copy event fid info to user
Date: Thu, 29 Nov 2018 10:00:00 +0100	[thread overview]
Message-ID: <20181129090000.GE31087@quack2.suse.cz> (raw)
In-Reply-To: <20181125134352.21499-8-amir73il@gmail.com>

On Sun 25-11-18 15:43:46, Amir Goldstein wrote:
> If group requested FAN_REPORT_FID and event has file identifier
> copy that information to user reading the event after reading
> event metadata.
> metadata->event_len includes the length of the fid information.
> 
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
...
> +static int round_event_fid_len(struct fsnotify_event *fsn_event)
> +{
> +	struct fanotify_event *event = FANOTIFY_E(fsn_event);
> +
> +	if (!FANOTIFY_HAS_FID(event))
> +		return 0;
> +
> +	return roundup(FANOTIFY_FID_INFO_LEN(event), FAN_EVENT_METADATA_LEN);
> +}
> +

Why do you round up to FAN_EVENT_METADATA_LEN? I think rounding up to
multiple of 8 bytes should be more than enough... Otherwise the patch looks
good to me.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR