From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v4 4/6] microcode: don't call apply_microcode() in cpu_request_microcode() Date: Thu, 29 Nov 2018 10:46:05 +0100 Message-ID: <20181129094605.6skmo3xnwmuzwy6y@mac> References: <1543383256-12371-1-git-send-email-chao.gao@intel.com> <1543383256-12371-5-git-send-email-chao.gao@intel.com> <20181128150225.4axdecgu33xlwwzu@mac> <20181129042846.GC23701@gao-cwp> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gSIuO-0006XA-ML for xen-devel@lists.xenproject.org; Thu, 29 Nov 2018 09:46:56 +0000 Content-Disposition: inline In-Reply-To: <20181129042846.GC23701@gao-cwp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Chao Gao Cc: xen-devel@lists.xenproject.org, Wei Liu , Jan Beulich , Andrew Cooper List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBOb3YgMjksIDIwMTggYXQgMTI6Mjg6NDZQTSArMDgwMCwgQ2hhbyBHYW8gd3JvdGU6 Cj4gT24gV2VkLCBOb3YgMjgsIDIwMTggYXQgMDQ6MDI6MjVQTSArMDEwMCwgUm9nZXIgUGF1IE1v bm7DqSB3cm90ZToKPiA+T24gV2VkLCBOb3YgMjgsIDIwMTggYXQgMDE6MzQ6MTRQTSArMDgwMCwg Q2hhbyBHYW8gd3JvdGU6Cj4gPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9taWNyb2NvZGUu YyBiL3hlbi9hcmNoL3g4Ni9taWNyb2NvZGUuYwo+ID4+IGluZGV4IDgzNTBkMjIuLmNjYTdiMmMg MTAwNjQ0Cj4gPj4gLS0tIGEveGVuL2FyY2gveDg2L21pY3JvY29kZS5jCj4gPj4gKysrIGIveGVu L2FyY2gveDg2L21pY3JvY29kZS5jCj4gPj4gQEAgLTIzMywyMCArMjMzLDEyIEBAIGludCBtaWNy b2NvZGVfcmVzdW1lX2NwdSh1bnNpZ25lZCBpbnQgY3B1KQo+ID4+ICAgICAgcmV0dXJuIGVycjsK PiA+PiAgfQo+ID4+ICAKPiA+PiAtc3RhdGljIGludCBtaWNyb2NvZGVfdXBkYXRlX2NwdShjb25z dCB2b2lkICpidWYsIHNpemVfdCBzaXplKQo+ID4+ICtzdGF0aWMgaW50IG1pY3JvY29kZV91cGRh dGVfY3B1KHZvaWQpCj4gPj4gIHsKPiA+PiAgICAgIGludCBlcnI7Cj4gPj4gLSAgICB1bnNpZ25l ZCBpbnQgY3B1ID0gc21wX3Byb2Nlc3Nvcl9pZCgpOwo+ID4+IC0gICAgc3RydWN0IHVjb2RlX2Nw dV9pbmZvICp1Y2kgPSAmcGVyX2NwdSh1Y29kZV9jcHVfaW5mbywgY3B1KTsKPiA+PiAgCj4gPj4g ICAgICBzcGluX2xvY2soJm1pY3JvY29kZV9tdXRleCk7Cj4gPj4gLQo+ID4+IC0gICAgZXJyID0g bWljcm9jb2RlX29wcy0+Y29sbGVjdF9jcHVfaW5mbyhjcHUsICZ1Y2ktPmNwdV9zaWcpOwo+ID4+ IC0gICAgaWYgKCBsaWtlbHkoIWVycikgKQo+ID4+IC0gICAgICAgIGVyciA9IG1pY3JvY29kZV9v cHMtPmNwdV9yZXF1ZXN0X21pY3JvY29kZShjcHUsIGJ1Ziwgc2l6ZSk7Cj4gPj4gLSAgICBlbHNl Cj4gPj4gLSAgICAgICAgX19taWNyb2NvZGVfZmluaV9jcHUoY3B1KTsKPiA+PiAtCj4gPj4gKyAg ICBlcnIgPSBtaWNyb2NvZGVfb3BzLT5hcHBseV9taWNyb2NvZGUoc21wX3Byb2Nlc3Nvcl9pZCgp KTsKPiA+PiAgICAgIHNwaW5fdW5sb2NrKCZtaWNyb2NvZGVfbXV0ZXgpOwo+ID4+ICAKPiA+PiAg ICAgIHJldHVybiBlcnI7Cj4gPj4gQEAgLTI1OSw3ICsyNTEsNyBAQCBzdGF0aWMgbG9uZyBkb19t aWNyb2NvZGVfdXBkYXRlKHZvaWQgKl9pbmZvKQo+ID4+ICAKPiA+PiAgICAgIEJVR19PTihpbmZv LT5jcHUgIT0gc21wX3Byb2Nlc3Nvcl9pZCgpKTsKPiA+PiAgCj4gPj4gLSAgICBlcnJvciA9IG1p Y3JvY29kZV91cGRhdGVfY3B1KGluZm8tPmJ1ZmZlciwgaW5mby0+YnVmZmVyX3NpemUpOwo+ID4+ ICsgICAgZXJyb3IgPSBtaWNyb2NvZGVfdXBkYXRlX2NwdSgpOwo+ID4KPiA+V2h5IGRvbid0IHlv dSBqdXN0IHNldCBpbmZvLT5lcnJvciA9IG1pY3JvY29kZV91cGRhdGVfY3B1KCk/Cj4gPgo+ID5B RkFJQ1QgdGhpcyBpcyBkb25lIHRvIGF0dGVtcHQgdG8gdXBkYXRlIHRoZSByZW1haW5pbmcgQ1BV cyBpZiBvbmUKPiA+dXBkYXRlIGZhaWxlZD8KPiAKPiBZZXMuIEJ1dCB0aGlzIHBhdGNoIGRvZXNu J3QgY2hhbmdlIHRoZSBsb2dpYyBoZXJlLiBBY3R1YWxseSwgaWYgSFQgaXMKPiBlbmFibGVkIGFu ZCBtaWNyb2NvZGUgaXMgc2hhcmVkIGJldHdlZW4gdGhlIGxvZ2ljYWwgdGhyZWFkcyBvZiB0aGUg c2FtZQo+IGNvcmUsIHNvIGlmIG9uZSB0aHJlYWQgdXBkYXRlcyBtaWNyb2NvZGUgc3VjY2Vzc2Z1 bGx5LCBpdHMgc2libGluZyB3b3VsZAo+IGFsd2F5cyBmYWlsIGluIGN1cnJlbnQgbG9naWMuIEkg YW0gdHJ5aW5nIHRvIGV4cGxhaW4gd2h5IHdlIGNhbm5vdCBhYm9ydAo+IHRoZSB1cGRhdGUgZXZl biB0aG91Z2ggYW4gZXJyb3IgaXMgbWV0IGluIGN1cnJlbnQgbG9naWMuIEl0IGRlZmluaXRlbHkK PiBjYW4gYmUgc29sdmVkIGJ5IHR3ZWFraW5nIHRoZSBsb2dpYyBzbGlnaHRseS4gCj4gCj4gPgo+ ID5JcyB0aGVyZSBhbnl3YXkgdG8gcm9sbGJhY2sgdG8gdGhlIHByZXZpb3VzIHN0YXRlIHNvIGFs bCBDUFVzIGhhdmUgdGhlCj4gPnNhbWUgbWljcm9jb2RlPwo+IAo+IFNlZW1zIGl0IGlzIG5vdCBh bGxvd2VkIHRvIGxvYWQgYSBtaWNyb2NvZGUgd2l0aCBudW1lcmF0aWNhbGx5IHNtYWxsZXIKPiBy ZXZpc2lvbiBhY2NvcmRpbmcgdG8gOS4xMS43LjIuCj4gCj4gV2l0aCBwYXRjaCA2LCBhIHBhbmlj KCkgd291bGQgYmUgdHJpZ2dlcmVkIGlmIHNvbWUgY3B1cyBmYWlsZWQgdG8gZG8gdGhlCj4gdXBk YXRlLiBJIGRpZG4ndCB0cnkgdG8gY2hhbmdlIHRoZSBsb2dpYyBoZXJlLgo+IAo+ID5JIGFzc3Vt ZSBub3RoaW5nIGdvb2Qgd2lsbCBjb21lIG91dCBvZiBydW5uaW5nIGEKPiA+c3lzdGVtIHdpdGgg Q1BVcyB1c2luZyBkaWZmZXJlbnQgbWljcm9jb2RlIHZlcnNpb25zLCBidXQgbWF5YmUgdGhhdCdz Cj4gPm5vdCBzbyBiYWQ/Cj4gCj4gSXQgaXMgYmV0dGVyIHRoYXQgYWxsIENQVXMgaGF2ZSB0aGUg c2FtZSBtaWNyb2NvZGUgcmV2aXNpb24uIAo+IAo+IExpbnV4IGtlcm5lbCByZWplY3RzIGxhdGUg bWljcm9jb2RlIHVwZGF0ZSBpZiBmaW5kaW5nIHNvbWUgQ1BVcwo+IG9mZmxpbmVkLiBJIG1heSBw b3J0IHRoaXMgcGF0Y2ggdG8gWGVuIHRvbyBpbiBhIHNlcGFyYXRlIHBhdGNoLgoKV2hhdCBoYXBw ZW5zIHdpdGggaG90cGx1ZyBDUFVzPwoKRXZlbiBpZiB5b3UgZGlzYWJsZSBsYXRlIGxvYWRpbmcg d2hlbiB0aGVyZSBhcmUgb2ZmbGluZWQgQ1BVcyB5b3UKc3RpbGwgbmVlZCB0byBoYW5kbGUgaG90 cGx1ZyBDUFVzLCB3aGljaCBJTU8gc2hvdWxkIHNoYXJlIHRoZSBzYW1lCnBhdGggd2l0aCBvZmZs aW5lZCBDUFVzOiB0aGUgbWljcm9jb2RlIHVwZGF0ZSBzaG91bGQgYmUgZG9uZSBBU0FQCmFmdGVy IGJyaW5naW5nIHRoZSBDUFUgdXAuCgo+ID4KPiA+PiAgICAgIGlmICggZXJyb3IgKQo+ID4+ICAg ICAgICAgIGluZm8tPmVycm9yID0gZXJyb3I7Cj4gPj4gIAo+ID4+IEBAIC0yNzYsNiArMjY4LDgg QEAgaW50IG1pY3JvY29kZV91cGRhdGUoWEVOX0dVRVNUX0hBTkRMRV9QQVJBTShjb25zdF92b2lk KSBidWYsIHVuc2lnbmVkIGxvbmcgbGVuKQo+ID4+ICB7Cj4gPj4gICAgICBpbnQgcmV0Owo+ID4+ ICAgICAgc3RydWN0IG1pY3JvY29kZV9pbmZvICppbmZvOwo+ID4+ICsgICAgdW5zaWduZWQgaW50 IGNwdSA9IHNtcF9wcm9jZXNzb3JfaWQoKTsKPiA+PiArICAgIHN0cnVjdCB1Y29kZV9jcHVfaW5m byAqdWNpID0gJnBlcl9jcHUodWNvZGVfY3B1X2luZm8sIGNwdSk7Cj4gPj4gIAo+ID4+ICAgICAg aWYgKCBsZW4gIT0gKHVpbnQzMl90KWxlbiApCj4gPj4gICAgICAgICAgcmV0dXJuIC1FMkJJRzsK PiA+PiBAQCAtMjk0LDEwICsyODgsNiBAQCBpbnQgbWljcm9jb2RlX3VwZGF0ZShYRU5fR1VFU1Rf SEFORExFX1BBUkFNKGNvbnN0X3ZvaWQpIGJ1ZiwgdW5zaWduZWQgbG9uZyBsZW4pCj4gPj4gICAg ICAgICAgcmV0dXJuIHJldDsKPiA+PiAgICAgIH0KPiA+PiAgCj4gPj4gLSAgICBpbmZvLT5idWZm ZXJfc2l6ZSA9IGxlbjsKPiA+PiAtICAgIGluZm8tPmVycm9yID0gMDsKPiA+PiAtICAgIGluZm8t PmNwdSA9IGNwdW1hc2tfZmlyc3QoJmNwdV9vbmxpbmVfbWFwKTsKPiA+PiAtCj4gPj4gICAgICBp ZiAoIG1pY3JvY29kZV9vcHMtPnN0YXJ0X3VwZGF0ZSApCj4gPj4gICAgICB7Cj4gPj4gICAgICAg ICAgcmV0ID0gbWljcm9jb2RlX29wcy0+c3RhcnRfdXBkYXRlKCk7Cj4gPj4gQEAgLTMwOCw2ICsy OTgsMjYgQEAgaW50IG1pY3JvY29kZV91cGRhdGUoWEVOX0dVRVNUX0hBTkRMRV9QQVJBTShjb25z dF92b2lkKSBidWYsIHVuc2lnbmVkIGxvbmcgbGVuKQo+ID4+ICAgICAgICAgIH0KPiA+PiAgICAg IH0KPiA+PiAgCj4gPj4gKyAgICBzcGluX2xvY2soJm1pY3JvY29kZV9tdXRleCk7Cj4gPj4gKwo+ ID4+ICsgICAgcmV0ID0gbWljcm9jb2RlX29wcy0+Y29sbGVjdF9jcHVfaW5mbyhjcHUsICZ1Y2kt PmNwdV9zaWcpOwo+ID4+ICsgICAgaWYgKCBsaWtlbHkoIXJldCkgKQo+ID4+ICsgICAgICAgIHJl dCA9IG1pY3JvY29kZV9vcHMtPmNwdV9yZXF1ZXN0X21pY3JvY29kZShjcHUsIGluZm8tPmJ1ZmZl ciwgbGVuKTsKPiA+PiArICAgIGVsc2UKPiA+PiArICAgICAgICBfX21pY3JvY29kZV9maW5pX2Nw dShjcHUpOwo+ID4+ICsKPiA+PiArICAgIHNwaW5fdW5sb2NrKCZtaWNyb2NvZGVfbXV0ZXgpOwo+ ID4KPiA+V2h5IGRvIHlvdSBuZWVkIHRvIGhvbGQgdGhlIGxvY2sgaGVyZT8KPiA+Cj4gPm1pY3Jv Y29kZV91cGRhdGUgaXMgYWxyZWFkeSBzZXJpYWxpemVkIGFuZCBzaG91bGQgb25seSBiZSBleGVj dXRlZCBvbgo+ID5hIENQVSBhdCBhIHRpbWUgZHVlIHRvIHRoZSB1c2FnZSBvZiBjaGFpbmVkCj4g PmNvbnRpbnVlX2h5cGVyY2FsbF9vbl9jcHUuCj4gCj4gbWljcm9jb2RlX3Jlc3VtZV9jcHUoKSBh bHNvIHVzZXMgdGhlICd1Y2knIGFuZCB0aGUgZ2xvYmFsIG1pY3JvY29kZSBjYWNoZS4KPiBUaGlz IGxvY2sgaXMgdG8gcHJldmVudCB0aGVtIGhhcHBlbmluZyBzaW11bHRhbmVvdXNseSAoc29tZW9u ZSBpcwo+IGFkZGluZy9yZXBsYWNpbmcgZW50cmllcyB0byBhIGxpc3QgYW5kIGFub3RoZXIgaXMg cmVhZGluZyB0aGUgbGlzdCkuCj4gQWxsIGV4aXN0aW5nIGNhbGwgc2l0ZXMgb2YgY29sbGVjX2Nw dV9pbmZvKCkgYW5kIGNwdV9yZXF1ZXN0X21pY3JvY29kZSgpCj4gYXJlIHByb3RlY3RlZCB3aXRo IHRoaXMgbG9jay4KCkkgbWVhbiwgdGhlcmUgc2hvdWxkIGJlIHNvbWUga2luZCBvZiBwcm90ZWN0 aW9uIHRvIHByZXZlbnQgdGhlIGxpc3QKZnJvbSBjaGFuZ2luZyBhdCBhbGwgd2hpbGUgdGhlcmUn cyBhbiB1cGRhdGUgaW4gcHJvZ3Jlc3MsIG9yIGVsc2UgeW91CnJpc2sgdXNpbmcgZGlmZmVyZW50 IHZlcnNpb25zIGZvciBkaWZmZXJlbnQgQ1BVcyBpZiB0aGVyZSdzIGEgbGlzdAphZGRpdGlvbiB3 aGlsZSBhIG1pY3JvY29kZSB1cGRhdGUgaXMgaW4gcHJvZ3Jlc3M/CgpUaGUgY3VycmVudCBsb2Nr IHdpbGwganVzdCBwcmV2ZW50IGxpc3QgY29ycnVwdGlvbiBieSBzZXJpYWxpemluZwp1c2Vycywg YnV0IGl0J3Mgbm90IGdvaW5nIHRvIHByZXZlbnQgY2hhbmdlcyB3aGlsZSB0aGVyZSdzIGEgbWlj cm9jb2RlCnVwZGF0ZSBpbiBwcm9ncmVzcy4KCj4gPj4gQEAgLTYwOSwxNyArNjEyLDEzIEBAIHN0 YXRpYyBpbnQgY3B1X3JlcXVlc3RfbWljcm9jb2RlKHVuc2lnbmVkIGludCBjcHUsIGNvbnN0IHZv aWQgKmJ1ZiwKPiA+PiAgICAgIH0KPiA+PiAgCj4gPj4gICAgb3V0Ogo+ID4+IC0jaWYgQ09ORklH X0hWTQo+ID4+IC0gICAgc3ZtX2hvc3Rfb3N2d19pbml0KCk7Cj4gPj4gLSNlbmRpZgo+ID4+IC0K PiA+PiAgICAgIC8qCj4gPj4gICAgICAgKiBJbiBzb21lIGNhc2VzIHdlIG1heSByZXR1cm4gYW4g ZXJyb3IgZXZlbiBpZiBwcm9jZXNzb3IncyBtaWNyb2NvZGUgaGFzCj4gPj4gICAgICAgKiBiZWVu IHVwZGF0ZWQuIEZvciBleGFtcGxlLCB0aGUgZmlyc3QgcGF0Y2ggaW4gYSBjb250YWluZXIgZmls ZSBpcyBsb2FkZWQKPiA+PiAgICAgICAqIHN1Y2Nlc3NmdWxseSBidXQgc3Vic2VxdWVudCBjb250 YWluZXIgZmlsZSBwcm9jZXNzaW5nIGVuY291bnRlcnMgYQo+ID4+ICAgICAgICogZmFpbHVyZS4K PiA+PiAgICAgICAqLwo+ID4+IC0gICAgcmV0dXJuIGVycm9yOwo+ID4+ICsgICAgcmV0dXJuICFl cnJvciA/IG1hdGNoZWRfY250IDogZXJyb3I7Cj4gPgo+ID5Zb3UgY2FuIHVzZSBlcnJvciA/OiBt YXRjaGVkX2NudDsgd2hpY2ggaXMgc2hvcnRlci4KPiAKPiBJIHdhcyB0b2xkIHRoYXQgSXQgd291 bGQgYmUgZ29vZCB0byBwdXQgdGhlIGxpa2VseSBjYXNlIGluIHRoZSBmaXJzdCBwbGFjZS4KClRo aXMgaXMgbm90IGEgaG90IHBhdGggYW55d2F5LCBidXQgaWYgeW91IHByZWZlciB0aGUgY3VycmVu dCBjb2RlIEknbQpmaW5lIHdpdGggaXQuCgpUaGFua3MsIFJvZ2VyLgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==