All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-kernel@vger.kernel.org,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH v5 01/21] nvmem: Move nvmem_type_str array to its only user
Date: Thu, 29 Nov 2018 12:59:38 +0200	[thread overview]
Message-ID: <20181129105956.25933-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20181129105956.25933-1-andriy.shevchenko@linux.intel.com>

Since we put static variable to a header file it's copied to each module
that includes the header. But not all of them are actually using it.

Move nvmem_type_str array to its only user to make a compiler happy:

In file included from include/linux/rtc.h:18,
                 from drivers/rtc/rtc-proc.c:15:
include/linux/nvmem-provider.h:29:27: warning: ‘nvmem_type_str’ defined but not used [-Wunused-const-variable=]
 static const char * const nvmem_type_str[] = {
                           ^~~~~~~~~~~~~~

Suggested-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Suggested-by: Joe Perches <joe@perches.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/nvmem/core.c           | 7 +++++++
 include/linux/nvmem-provider.h | 7 -------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index d9fd11033c1c..22345e65a301 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -61,6 +61,13 @@ static LIST_HEAD(nvmem_lookup_list);
 
 static BLOCKING_NOTIFIER_HEAD(nvmem_notifier);
 
+static const char * const nvmem_type_str[] = {
+	[NVMEM_TYPE_UNKNOWN] = "Unknown",
+	[NVMEM_TYPE_EEPROM] = "EEPROM",
+	[NVMEM_TYPE_OTP] = "OTP",
+	[NVMEM_TYPE_BATTERY_BACKED] = "Battery backed",
+};
+
 #ifdef CONFIG_DEBUG_LOCK_ALLOC
 static struct lock_class_key eeprom_lock_key;
 #endif
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 00ff92571683..5b2dd0a987d2 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -26,13 +26,6 @@ enum nvmem_type {
 	NVMEM_TYPE_BATTERY_BACKED,
 };
 
-static const char * const nvmem_type_str[] = {
-	[NVMEM_TYPE_UNKNOWN] = "Unknown",
-	[NVMEM_TYPE_EEPROM] = "EEPROM",
-	[NVMEM_TYPE_OTP] = "OTP",
-	[NVMEM_TYPE_BATTERY_BACKED] = "Battery backed",
-};
-
 /**
  * struct nvmem_config - NVMEM device configuration
  *
-- 
2.19.2


  reply	other threads:[~2018-11-29 11:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 10:59 [PATCH v5 00/21] lib, rtc: Print rtc_time via %ptR[dt][r] Andy Shevchenko
2018-11-29 10:59 ` Andy Shevchenko [this message]
2018-11-29 10:59 ` [PATCH v5 02/21] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2018-12-04 13:30   ` Petr Mladek
2018-12-04 16:12     ` Andy Shevchenko
2018-12-04 16:16       ` Geert Uytterhoeven
2018-12-04 16:38         ` Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 03/21] rtc: Switch to use %ptR Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 04/21] rtc: at91rm9200: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 05/21] rtc: at91sam9: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 06/21] rtc: m41t80: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 07/21] rtc: m48t59: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 08/21] rtc: mcp795: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 09/21] rtc: pcf50633: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 10/21] rtc: pic32: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 11/21] rtc: pm8xxx: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 12/21] rtc: puv3: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 13/21] rtc: rk808: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 14/21] rtc: rx6110: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 15/21] rtc: rx8025: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 16/21] rtc: s3c: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 17/21] rtc: s5m: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 18/21] rtc: tegra: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 19/21] Input: hp_sdc_rtc - " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 20/21] m68k/mac: " Andy Shevchenko
2018-12-02  9:42   ` Geert Uytterhoeven
2018-11-29 10:59 ` [PATCH v5 21/21] PM: " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129105956.25933-2-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=salyzyn@android.com \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.