From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v4 0/4] perf report/annotate: Support average IPC and IPC coverage for function
Date: Thu, 29 Nov 2018 12:33:30 +0100 [thread overview]
Message-ID: <20181129113330.GE25884@krava> (raw)
In-Reply-To: <1543505978-19808-1-git-send-email-yao.jin@linux.intel.com>
On Thu, Nov 29, 2018 at 11:39:34PM +0800, Jin Yao wrote:
> Add supporting of displaying the average IPC and IPC coverage
> percentage per function.
>
> For example,
>
> $ perf record -b ...
> $ perf report -s symbol or
> perf report -s symbol --stdio
>
> Overhead Symbol IPC [IPC Coverage]
> 39.60% [.] __random 2.30 [ 54.8%]
> 18.02% [.] main 0.43 [ 54.3%]
> 14.21% [.] compute_flag 2.29 [100.0%]
> 14.16% [.] rand 0.36 [100.0%]
> 7.06% [.] __random_r 2.57 [ 70.5%]
> 6.85% [.] rand@plt 0.00 [ 0.0%]
> ...
>
> $ perf annotate --stdio2
>
> Percent IPC Cycle (Average IPC: 2.30, IPC Coverage: 54.8%)
>
> Disassembly of section .text:
>
> 000000000003aac0 <random@@GLIBC_2.2.5>:
> 8.32 3.28 sub $0x18,%rsp
> 3.28 mov $0x1,%esi
> 3.28 xor %eax,%eax
> 3.28 cmpl $0x0,argp_program_version_hook@@GLIBC_2.2.5+0x1e0
> 11.57 3.28 1 ↓ je 20
> lock cmpxchg %esi,__abort_msg@@GLIBC_PRIVATE+0x8a0
> ↓ jne 29
> ↓ jmp 43
> 11.57 1.10 20: cmpxchg %esi,__abort_msg@@GLIBC_PRIVATE+0x8a0
> ...
>
> v4:
> ---
> Add a new patch "perf report: Documentation average IPC and IPC coverage"
> to explain the new columns "IPC" and "IPC Coverage".
>
> Other patches are not changed.
>
> v3:
> ---
> Remove the sortkey "ipc" from command-line. The columns "IPC"
> and "[IPC Coverage]" are automatically enabled when "symbol"
> is specified.
>
> Patch "perf report: Display average IPC and IPC coverage per symbol"
> is impacted.
>
> v2:
> ---
> 1. Merge in Jiri's patch to support stdio mode
>
> 2. Add a new patch "perf annotate: Create a annotate2 flag
> in struct symbol" which records if the symbol has been
> annotated yet.
>
> 3. Minor update such as adding { } for multiline code in 'if'
> condition.
>
> Jin Yao (4):
> perf annotate: Compute average IPC and IPC coverage per symbol
> perf annotate: Create a annotate2 flag in struct symbol
> perf report: Display average IPC and IPC coverage per symbol
> perf report: Documentation average IPC and IPC coverage
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2018-11-29 11:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 15:39 [PATCH v4 0/4] perf report/annotate: Support average IPC and IPC coverage for function Jin Yao
2018-11-29 11:33 ` Jiri Olsa [this message]
2018-11-30 0:26 ` Jin, Yao
2018-11-29 15:39 ` [PATCH v4 1/4] perf annotate: Compute average IPC and IPC coverage per symbol Jin Yao
2018-11-29 15:39 ` [PATCH v4 2/4] perf annotate: Create a annotate2 flag in struct symbol Jin Yao
2018-11-29 15:39 ` [PATCH v4 3/4] perf report: Display average IPC and IPC coverage per symbol Jin Yao
2018-11-29 15:39 ` [PATCH v4 4/4] perf report: Documentation average IPC and IPC coverage Jin Yao
2018-11-29 13:27 ` Ingo Molnar
2018-11-30 0:22 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129113330.GE25884@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.