From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA49C43441 for ; Thu, 29 Nov 2018 11:37:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9520F20673 for ; Thu, 29 Nov 2018 11:37:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9520F20673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727837AbeK2Wmq (ORCPT ); Thu, 29 Nov 2018 17:42:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35668 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726621AbeK2Wmp (ORCPT ); Thu, 29 Nov 2018 17:42:45 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0271E307CDDB; Thu, 29 Nov 2018 11:37:42 +0000 (UTC) Received: from gondolin (ovpn-117-114.ams2.redhat.com [10.36.117.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 876E41701A; Thu, 29 Nov 2018 11:37:30 +0000 (UTC) Date: Thu, 29 Nov 2018 12:37:26 +0100 From: Cornelia Huck To: Pierre Morel Cc: borntraeger@de.ibm.com, alex.williamson@redhat.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, frankja@linux.ibm.com, akrowiak@linux.ibm.com, pasic@linux.ibm.com, david@redhat.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, freude@linux.ibm.com, mimu@linux.ibm.com Subject: Re: [PATCH v2 3/3] vfio: ap: AP Queue Interrupt Control VFIO ioctl calls Message-ID: <20181129123726.62b04690.cohuck@redhat.com> In-Reply-To: <1542906675-7949-4-git-send-email-pmorel@linux.ibm.com> References: <1542906675-7949-1-git-send-email-pmorel@linux.ibm.com> <1542906675-7949-4-git-send-email-pmorel@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 29 Nov 2018 11:37:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Nov 2018 18:11:15 +0100 Pierre Morel wrote: > This is the implementation of the VFIO ioctl calls to handle > the AQIC interception and use GISA to handle interrupts. > > Signed-off-by: Pierre Morel > --- > drivers/s390/crypto/vfio_ap_ops.c | 110 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 109 insertions(+), 1 deletion(-) > > diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c > index 272ef42..f6e942f 100644 > --- a/drivers/s390/crypto/vfio_ap_ops.c > +++ b/drivers/s390/crypto/vfio_ap_ops.c > @@ -895,12 +895,121 @@ static int vfio_ap_mdev_get_device_info(unsigned long arg) > return copy_to_user((void __user *)arg, &info, minsz); > } > > +static unsigned long vfio_ap_get_nib(struct kvm *kvm, struct vfio_ap_aqic *parm) > +{ > + struct s390_io_adapter *adapter; > + struct s390_map_info *map; > + unsigned long nib; > + int found = 0; > + > + /* find the adapter */ > + if (parm->adapter_id > MAX_S390_IO_ADAPTERS) > + return 0; > + > + adapter = kvm->arch.adapters[parm->adapter_id]; > + if (!adapter) > + return 0; > + > + down_write(&adapter->maps_lock); > + list_for_each_entry(map, &adapter->maps, list) { > + if (map->guest_addr == parm->nib) { > + found = 1; > + break; > + } > + } > + up_write(&adapter->maps_lock); Regardless of which user space interface you ultimately use: I think you should leave poking the adapter handling innards to the adapter code and instead create and use an interface to look up the mapping from the guest address. > + > + if (!found) > + return 0; > + > + nib = (unsigned long) page_address(map->page); > + nib += (map->guest_addr & 0x0fff); > + > + return nib; > +}