From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 4/4] fzsync: Add delay bias for difficult races
Date: Thu, 29 Nov 2018 16:19:31 +0100 [thread overview]
Message-ID: <20181129151931.GB22216@rei.lan> (raw)
In-Reply-To: <20181105154217.18879-5-rpalethorpe@suse.com>
Hi!
> + * A positive change delays thread B and a negative one delays thread
> + * A. Calling this will invalidate the statistics gathered so far and extend
> + * the minimum sampling period. Calling it once the sampling period has
> + * finished will have no effect.
I guess that this comment ended up out of sync with the code, since we
no longer seem to do reset the statistic nor increase the number of
iterations. Which also means that the patch could be more minimal, there
is no need to move the statistic initialization into a separate function
since it's does not seem to be called from more than one place, etc.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-11-29 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 15:42 [LTP] [PATCH v4 0/4] New Fuzzy Sync library API Richard Palethorpe
2018-11-05 15:42 ` [LTP] [PATCH v4 1/4] tst_timer: Add nano second conversions Richard Palethorpe
2018-11-05 15:42 ` [LTP] [PATCH v4 2/4] fzsync: Simplify API with start/end race calls and limit exec time Richard Palethorpe
2018-11-22 15:41 ` Cyril Hrubis
2018-11-23 14:55 ` Richard Palethorpe
2018-11-05 15:42 ` [LTP] [PATCH v4 3/4] Convert tests to use fzsync_{start, end}_race API Richard Palethorpe
2018-11-05 15:42 ` [LTP] [PATCH v4 4/4] fzsync: Add delay bias for difficult races Richard Palethorpe
2018-11-29 15:19 ` Cyril Hrubis [this message]
2018-11-16 14:33 ` [LTP] [PATCH v4 0/4] New Fuzzy Sync library API Li Wang
2018-11-20 11:35 ` Richard Palethorpe
2018-11-20 13:09 ` Cyril Hrubis
2018-12-03 11:40 ` Richard Palethorpe
2018-11-22 15:35 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129151931.GB22216@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.