From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4ECC43441 for ; Thu, 29 Nov 2018 20:22:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1B6C21019 for ; Thu, 29 Nov 2018 20:22:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1B6C21019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726151AbeK3H2s (ORCPT ); Fri, 30 Nov 2018 02:28:48 -0500 Received: from mga14.intel.com ([192.55.52.115]:9163 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726019AbeK3H2s (ORCPT ); Fri, 30 Nov 2018 02:28:48 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2018 12:22:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,295,1539673200"; d="scan'208";a="94206579" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga007.jf.intel.com with ESMTP; 29 Nov 2018 12:22:09 -0800 Date: Thu, 29 Nov 2018 13:19:14 -0700 From: Keith Busch To: Christoph Hellwig Cc: Jens Axboe , Sagi Grimberg , Max Gurtovoy , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org Subject: Re: [PATCH 01/13] block: move queues types to the block layer Message-ID: <20181129201914.GB9377@localhost.localdomain> References: <20181129191310.9795-1-hch@lst.de> <20181129191310.9795-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181129191310.9795-2-hch@lst.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Nov 29, 2018 at 08:12:58PM +0100, Christoph Hellwig wrote: > +enum hctx_type { > + HCTX_TYPE_DEFAULT, /* all I/O not otherwise accounted for */ > + HCTX_TYPE_READ, /* just for READ I/O */ > + HCTX_TYPE_POLL, /* polled I/O of any kind */ > + > + HCTX_MAX_TYPES, > }; Well, there goes my plan to use this with Weighted-Round-Robin NVMe IO queues! I'm not that sad about it, though. Reviewed-by: Keith Busch From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@intel.com (Keith Busch) Date: Thu, 29 Nov 2018 13:19:14 -0700 Subject: [PATCH 01/13] block: move queues types to the block layer In-Reply-To: <20181129191310.9795-2-hch@lst.de> References: <20181129191310.9795-1-hch@lst.de> <20181129191310.9795-2-hch@lst.de> Message-ID: <20181129201914.GB9377@localhost.localdomain> On Thu, Nov 29, 2018@08:12:58PM +0100, Christoph Hellwig wrote: > +enum hctx_type { > + HCTX_TYPE_DEFAULT, /* all I/O not otherwise accounted for */ > + HCTX_TYPE_READ, /* just for READ I/O */ > + HCTX_TYPE_POLL, /* polled I/O of any kind */ > + > + HCTX_MAX_TYPES, > }; Well, there goes my plan to use this with Weighted-Round-Robin NVMe IO queues! I'm not that sad about it, though. Reviewed-by: Keith Busch