All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/libdrm: correct cunit test dependency
Date: Thu, 29 Nov 2018 22:54:56 +0100	[thread overview]
Message-ID: <20181129225456.21d37e68@windsurf> (raw)
In-Reply-To: <1541098696-25824-2-git-send-email-matthew.weber@rockwellcollins.com>

Hello,

On Thu,  1 Nov 2018 13:58:16 -0500, Matt Weber wrote:
> Previously the option to install tests would result in the test
> cases that don't have a cunit dependency, to build and be installed.
> 
> This patch adds the cunit dependency so all test cases are built and
> installed to target when that is selected via kconfig.

Looking at the libdrm build system, only the tests specific to  the
amdgpu backend/driver need cunit. So when you say "By default most of
the test cases will automatically be disabled if cunit is not present"
doesn't seem really accurate. So I've changed this patch to make cunit
an optional dependency: if it's there, we use it, otherwise, fine, we
have some tests, but not the amdgpu tests.

Did I miss something?

Anyway, I've applied the patch that adds it as an optional dependency
to the next branch.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-29 21:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 18:58 [Buildroot] [PATCH 1/2] package/cunit: new package Matt Weber
2018-11-01 18:58 ` [Buildroot] [PATCH 2/2] package/libdrm: correct cunit test dependency Matt Weber
2018-11-29 21:54   ` Thomas Petazzoni [this message]
2018-11-29 22:19     ` Matthew Weber
2018-11-29 21:53 ` [Buildroot] [PATCH 1/2] package/cunit: new package Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129225456.21d37e68@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.