From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 713F821962301 for ; Fri, 30 Nov 2018 10:22:09 -0800 (PST) Received: by mail-pg1-f194.google.com with SMTP id 17so2855661pgg.1 for ; Fri, 30 Nov 2018 10:22:09 -0800 (PST) Date: Fri, 30 Nov 2018 10:22:03 -0800 From: Luis Chamberlain Subject: Re: [RFC v3 06/19] arch: um: enable running kunit from User Mode Linux Message-ID: <20181130182203.GS18410@garbanzo.do-not-panic.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-7-brendanhiggins@google.com> <20181130033704.GL18410@garbanzo.do-not-panic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Rob Herring , Arnd Bergmann Cc: brakmo@fb.com, Brendan Higgins , dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , "Bird, Timothy" , Jeff Dike , Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , kunit-dev@googlegroups.com, Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman List-ID: On Fri, Nov 30, 2018 at 08:05:34AM -0600, Rob Herring wrote: > On Thu, Nov 29, 2018 at 9:37 PM Luis Chamberlain wrote: > > > > On Wed, Nov 28, 2018 at 03:26:03PM -0600, Rob Herring wrote: > > > On Wed, Nov 28, 2018 at 1:37 PM Brendan Higgins > > > wrote: > > > > > > > > Make minimum number of changes outside of the KUnit directories for > > > > KUnit to build and run using UML. > > > > > > There's nothing in this patch limiting this to UML. > > > > Not that one, but the abort thing segv thing is, eventually. > > To support other architectures we'd need to make a wrapper to that > > hack which Brendan added, and then allow each os to implement > > its own call, and add an asm-generic helper. > > I've not looked into why this is needed, but can't you make the abort > support optional and arches can select it when they support it. Its why I have asked for it to be properly documented. The patches in no way illustrate *why* such thing is done. And if we are going to potentially have other archs do something similar best to make it explicit. > At > least before, the DT unittests didn't need this to run and shouldn't > depend on it after converting to kunit. Luis _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 215D6C04EB8 for ; Fri, 30 Nov 2018 18:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9AE520673 for ; Fri, 30 Nov 2018 18:22:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9AE520673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726850AbeLAFcR (ORCPT ); Sat, 1 Dec 2018 00:32:17 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:34400 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbeLAFcR (ORCPT ); Sat, 1 Dec 2018 00:32:17 -0500 Received: by mail-pg1-f193.google.com with SMTP id 17so2855662pgg.1; Fri, 30 Nov 2018 10:22:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pQcUow3rtfROGco5fKqiF8AvO6eLeBwD4In1k1teLIg=; b=ph2cCJpqajKOz9PAmyEE71jqwmhGuj6oi1ba5pV8FA3d7at2yW4TJfh7QxAe6UNjGO llKL7s2lJbOh+udALjdu0sVdz61EjmMImHk52QSzCUp/ZRNPqVfJ/1C+qfRzEFD9Z1Eg VOPZYw83DVUpvxq/rs6BD2OP9dtW3+TYYDL+nI3jK3kN9lI2rH6nzYUeM3bQvAPgUPoF +qXpAl6lIEgNsQaTusGnuna2qXrxFJi5lajQtP0s6GTFU8jczCwBcWG3jZy7BHI7nb+R jkQCGCFIVzICmvuPz/8popum44e+OLLyJ5Fh2SK/h8abSG2DTdanuLXUiuL59kvrOGGQ nEjg== X-Gm-Message-State: AA+aEWa0t1a63OC8xGIuYor3pxaoBTqtnYrXhg4PuwgjaOoQfGCL56Rc Eo+M4tY/uOmyi0KSuWMf7mw= X-Google-Smtp-Source: AFSGD/UcmEtYJe8mp/VoGjf5O6sYcV5VbFAq5jcWCPggX43KCCGWhQnYWW/41gPVOCkjpzg7aQZXzw== X-Received: by 2002:a65:60c2:: with SMTP id r2mr4559360pgv.393.1543602128770; Fri, 30 Nov 2018 10:22:08 -0800 (PST) Received: from garbanzo.do-not-panic.com (c-73-71-40-85.hsd1.ca.comcast.net. [73.71.40.85]) by smtp.gmail.com with ESMTPSA id d18sm7781998pfj.47.2018.11.30.10.22.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Nov 2018 10:22:07 -0800 (PST) Received: by garbanzo.do-not-panic.com (sSMTP sendmail emulation); Fri, 30 Nov 2018 10:22:03 -0800 Date: Fri, 30 Nov 2018 10:22:03 -0800 From: Luis Chamberlain To: Rob Herring , Arnd Bergmann Cc: Brendan Higgins , Greg Kroah-Hartman , Kees Cook , shuah@kernel.org, Joel Stanley , Michael Ellerman , Joe Perches , brakmo@fb.com, Steven Rostedt , "Bird, Timothy" , Kevin Hilman , Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, "linux-kernel@vger.kernel.org" , Jeff Dike , Richard Weinberger , linux-um@lists.infradead.org, Daniel Vetter , dri-devel , Dan Williams , linux-nvdimm , Kieran Bingham , Frank Rowand , knut.omang@oracle.com Subject: Re: [RFC v3 06/19] arch: um: enable running kunit from User Mode Linux Message-ID: <20181130182203.GS18410@garbanzo.do-not-panic.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-7-brendanhiggins@google.com> <20181130033704.GL18410@garbanzo.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 30, 2018 at 08:05:34AM -0600, Rob Herring wrote: > On Thu, Nov 29, 2018 at 9:37 PM Luis Chamberlain wrote: > > > > On Wed, Nov 28, 2018 at 03:26:03PM -0600, Rob Herring wrote: > > > On Wed, Nov 28, 2018 at 1:37 PM Brendan Higgins > > > wrote: > > > > > > > > Make minimum number of changes outside of the KUnit directories for > > > > KUnit to build and run using UML. > > > > > > There's nothing in this patch limiting this to UML. > > > > Not that one, but the abort thing segv thing is, eventually. > > To support other architectures we'd need to make a wrapper to that > > hack which Brendan added, and then allow each os to implement > > its own call, and add an asm-generic helper. > > I've not looked into why this is needed, but can't you make the abort > support optional and arches can select it when they support it. Its why I have asked for it to be properly documented. The patches in no way illustrate *why* such thing is done. And if we are going to potentially have other archs do something similar best to make it explicit. > At > least before, the DT unittests didn't need this to run and shouldn't > depend on it after converting to kunit. Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: mcgrof at kernel.org (Luis Chamberlain) Date: Fri, 30 Nov 2018 10:22:03 -0800 Subject: [RFC v3 06/19] arch: um: enable running kunit from User Mode Linux In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-7-brendanhiggins@google.com> <20181130033704.GL18410@garbanzo.do-not-panic.com> Message-ID: <20181130182203.GS18410@garbanzo.do-not-panic.com> On Fri, Nov 30, 2018 at 08:05:34AM -0600, Rob Herring wrote: > On Thu, Nov 29, 2018 at 9:37 PM Luis Chamberlain wrote: > > > > On Wed, Nov 28, 2018 at 03:26:03PM -0600, Rob Herring wrote: > > > On Wed, Nov 28, 2018 at 1:37 PM Brendan Higgins > > > wrote: > > > > > > > > Make minimum number of changes outside of the KUnit directories for > > > > KUnit to build and run using UML. > > > > > > There's nothing in this patch limiting this to UML. > > > > Not that one, but the abort thing segv thing is, eventually. > > To support other architectures we'd need to make a wrapper to that > > hack which Brendan added, and then allow each os to implement > > its own call, and add an asm-generic helper. > > I've not looked into why this is needed, but can't you make the abort > support optional and arches can select it when they support it. Its why I have asked for it to be properly documented. The patches in no way illustrate *why* such thing is done. And if we are going to potentially have other archs do something similar best to make it explicit. > At > least before, the DT unittests didn't need this to run and shouldn't > depend on it after converting to kunit. Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: mcgrof@kernel.org (Luis Chamberlain) Date: Fri, 30 Nov 2018 10:22:03 -0800 Subject: [RFC v3 06/19] arch: um: enable running kunit from User Mode Linux In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-7-brendanhiggins@google.com> <20181130033704.GL18410@garbanzo.do-not-panic.com> Message-ID: <20181130182203.GS18410@garbanzo.do-not-panic.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20181130182203.CxbgMcYbfhd4eGKMEdC1HoS1MKP4ZOLR2njvxgMPkOA@z> On Fri, Nov 30, 2018@08:05:34AM -0600, Rob Herring wrote: > On Thu, Nov 29, 2018@9:37 PM Luis Chamberlain wrote: > > > > On Wed, Nov 28, 2018@03:26:03PM -0600, Rob Herring wrote: > > > On Wed, Nov 28, 2018 at 1:37 PM Brendan Higgins > > > wrote: > > > > > > > > Make minimum number of changes outside of the KUnit directories for > > > > KUnit to build and run using UML. > > > > > > There's nothing in this patch limiting this to UML. > > > > Not that one, but the abort thing segv thing is, eventually. > > To support other architectures we'd need to make a wrapper to that > > hack which Brendan added, and then allow each os to implement > > its own call, and add an asm-generic helper. > > I've not looked into why this is needed, but can't you make the abort > support optional and arches can select it when they support it. Its why I have asked for it to be properly documented. The patches in no way illustrate *why* such thing is done. And if we are going to potentially have other archs do something similar best to make it explicit. > At > least before, the DT unittests didn't need this to run and shouldn't > depend on it after converting to kunit. Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis Chamberlain Subject: Re: [RFC v3 06/19] arch: um: enable running kunit from User Mode Linux Date: Fri, 30 Nov 2018 10:22:03 -0800 Message-ID: <20181130182203.GS18410@garbanzo.do-not-panic.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-7-brendanhiggins@google.com> <20181130033704.GL18410@garbanzo.do-not-panic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C7D06E659 for ; Fri, 30 Nov 2018 18:22:09 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id g189so2845142pgc.5 for ; Fri, 30 Nov 2018 10:22:09 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring , Arnd Bergmann Cc: brakmo@fb.com, Brendan Higgins , dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , "Bird, Timothy" , Jeff Dike , Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Michael Ellerman , Joe Perches , Kevin Hilman List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBOb3YgMzAsIDIwMTggYXQgMDg6MDU6MzRBTSAtMDYwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gVGh1LCBOb3YgMjksIDIwMTggYXQgOTozNyBQTSBMdWlzIENoYW1iZXJsYWluIDxt Y2dyb2ZAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24gV2VkLCBOb3YgMjgsIDIwMTggYXQg MDM6MjY6MDNQTSAtMDYwMCwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gPiA+IE9uIFdlZCwgTm92IDI4 LCAyMDE4IGF0IDE6MzcgUE0gQnJlbmRhbiBIaWdnaW5zCj4gPiA+IDxicmVuZGFuaGlnZ2luc0Bn b29nbGUuY29tPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IE1ha2UgbWluaW11bSBudW1iZXIgb2Yg Y2hhbmdlcyBvdXRzaWRlIG9mIHRoZSBLVW5pdCBkaXJlY3RvcmllcyBmb3IKPiA+ID4gPiBLVW5p dCB0byBidWlsZCBhbmQgcnVuIHVzaW5nIFVNTC4KPiA+ID4KPiA+ID4gVGhlcmUncyBub3RoaW5n IGluIHRoaXMgcGF0Y2ggbGltaXRpbmcgdGhpcyB0byBVTUwuCj4gPgo+ID4gTm90IHRoYXQgb25l LCBidXQgdGhlIGFib3J0IHRoaW5nIHNlZ3YgdGhpbmcgaXMsIGV2ZW50dWFsbHkuCj4gPiBUbyBz dXBwb3J0IG90aGVyIGFyY2hpdGVjdHVyZXMgd2UnZCBuZWVkIHRvIG1ha2UgYSB3cmFwcGVyIHRv IHRoYXQKPiA+IGhhY2sgd2hpY2ggQnJlbmRhbiBhZGRlZCwgYW5kIHRoZW4gYWxsb3cgZWFjaCBv cyB0byBpbXBsZW1lbnQKPiA+IGl0cyBvd24gY2FsbCwgYW5kIGFkZCBhbiBhc20tZ2VuZXJpYyBo ZWxwZXIuCj4gCj4gSSd2ZSBub3QgbG9va2VkIGludG8gd2h5IHRoaXMgaXMgbmVlZGVkLCBidXQg Y2FuJ3QgeW91IG1ha2UgdGhlIGFib3J0Cj4gc3VwcG9ydCBvcHRpb25hbCBhbmQgYXJjaGVzIGNh biBzZWxlY3QgaXQgd2hlbiB0aGV5IHN1cHBvcnQgaXQuCgpJdHMgd2h5IEkgaGF2ZSBhc2tlZCBm b3IgaXQgdG8gYmUgcHJvcGVybHkgZG9jdW1lbnRlZC4gVGhlIHBhdGNoZXMgaW4gbm8Kd2F5IGls bHVzdHJhdGUgKndoeSogc3VjaCB0aGluZyBpcyBkb25lLiBBbmQgaWYgd2UgYXJlIGdvaW5nIHRv CnBvdGVudGlhbGx5IGhhdmUgb3RoZXIgYXJjaHMgZG8gc29tZXRoaW5nIHNpbWlsYXIgYmVzdCB0 byBtYWtlIGl0CmV4cGxpY2l0LgoKPiBBdAo+IGxlYXN0IGJlZm9yZSwgdGhlIERUIHVuaXR0ZXN0 cyBkaWRuJ3QgbmVlZCB0aGlzIHRvIHJ1biBhbmQgc2hvdWxkbid0Cj4gZGVwZW5kIG9uIGl0IGFm dGVyIGNvbnZlcnRpbmcgdG8ga3VuaXQuCgogIEx1aXMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f196.google.com ([209.85.215.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gSnQh-0008Hz-Ld for linux-um@lists.infradead.org; Fri, 30 Nov 2018 18:22:21 +0000 Received: by mail-pg1-f196.google.com with SMTP id g189so2845141pgc.5 for ; Fri, 30 Nov 2018 10:22:09 -0800 (PST) Date: Fri, 30 Nov 2018 10:22:03 -0800 From: Luis Chamberlain Subject: Re: [RFC v3 06/19] arch: um: enable running kunit from User Mode Linux Message-ID: <20181130182203.GS18410@garbanzo.do-not-panic.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-7-brendanhiggins@google.com> <20181130033704.GL18410@garbanzo.do-not-panic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Rob Herring , Arnd Bergmann Cc: brakmo@fb.com, Brendan Higgins , dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , "Bird, Timothy" , Jeff Dike , Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman On Fri, Nov 30, 2018 at 08:05:34AM -0600, Rob Herring wrote: > On Thu, Nov 29, 2018 at 9:37 PM Luis Chamberlain wrote: > > > > On Wed, Nov 28, 2018 at 03:26:03PM -0600, Rob Herring wrote: > > > On Wed, Nov 28, 2018 at 1:37 PM Brendan Higgins > > > wrote: > > > > > > > > Make minimum number of changes outside of the KUnit directories for > > > > KUnit to build and run using UML. > > > > > > There's nothing in this patch limiting this to UML. > > > > Not that one, but the abort thing segv thing is, eventually. > > To support other architectures we'd need to make a wrapper to that > > hack which Brendan added, and then allow each os to implement > > its own call, and add an asm-generic helper. > > I've not looked into why this is needed, but can't you make the abort > support optional and arches can select it when they support it. Its why I have asked for it to be properly documented. The patches in no way illustrate *why* such thing is done. And if we are going to potentially have other archs do something similar best to make it explicit. > At > least before, the DT unittests didn't need this to run and shouldn't > depend on it after converting to kunit. Luis _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um