From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [v3 2/3] drm/i915/icl: Enable ICL Pipe CSC block Date: Fri, 30 Nov 2018 11:20:29 -0800 Message-ID: <20181130192029.GC31345@mdroper-desk.amr.corp.intel.com> References: <1543503103-882-1-git-send-email-uma.shankar@intel.com> <1543503103-882-3-git-send-email-uma.shankar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 702FC6E65F for ; Fri, 30 Nov 2018 19:20:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1543503103-882-3-git-send-email-uma.shankar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Uma Shankar Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com, maarten.lankhorst@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMjksIDIwMTggYXQgMDg6MjE6NDJQTSArMDUzMCwgVW1hIFNoYW5rYXIgd3Jv dGU6Cj4gRW5hYmxlIElDTCBwaXBlIGNzYyBoYXJkd2FyZS4gQ1NDIGJsb2NrIGlzIGVuYWJsZWQK PiBpbiBDU0NfTU9ERSByZWdpc3RlciBpbnN0ZWFkIG9mIFBMQU5FX0NPTE9SX0NUTC4KPiAKPiB2 MjogQWRkcmVzc2VkIE1hYXJ0ZW4ncyByZXZpZXcgY29tbWVudHMuCj4gCj4gdjM6IEFkZHJlc3Nl ZCBNYXR0J3MgcmV2aWV3IGNvbW1lbnRzLiBSZW1vdmVkIHJtdyBwYXR0ZXJucwo+IGFzIHN1Z2dl c3RlZCBieSBNYXR0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFVtYSBTaGFua2FyIDx1bWEuc2hhbmth ckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAg fCAgMiArKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jIHwgMjggKysrKysr KysrKysrKysrKysrKysrKystLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aCAgIHwgIDMgKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgNSBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcu aCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBpbmRleCBiMDE0N2JmLi42NDcw MDA4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAgLTk4MjQsNiArOTgyNCw4IEBA IGVudW0gc2tsX3Bvd2VyX2dhdGUgewo+ICAjZGVmaW5lIF9QSVBFX0FfQ1NDX0NPRUZGX1JWX0dW CTB4NDkwMjAKPiAgI2RlZmluZSBfUElQRV9BX0NTQ19DT0VGRl9CVgkweDQ5MDI0Cj4gICNkZWZp bmUgX1BJUEVfQV9DU0NfTU9ERQkweDQ5MDI4Cj4gKyNkZWZpbmUgICBDU0NfRU5BQkxFCQkJKDEg PDwgMzEpCj4gKyNkZWZpbmUgICBPVVRQVVRfQ1NDX0VOQUJMRQkJKDEgPDwgMzApCj4gICNkZWZp bmUgICBDU0NfQkxBQ0tfU0NSRUVOX09GRlNFVAkoMSA8PCAyKQo+ICAjZGVmaW5lICAgQ1NDX1BP U0lUSU9OX0JFRk9SRV9HQU1NQQkoMSA8PCAxKQo+ICAjZGVmaW5lICAgQ1NDX01PREVfWVVWX1RP X1JHQgkJKDEgPDwgMCkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Y29sb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiBpbmRleCA3Yzhj OTk2Li40MTRlMWNhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nv bG9yLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gQEAgLTEw OCwxMCArMTA4LDE0IEBAIHN0YXRpYyB1NjQgKmN0bV9tdWx0X2J5X2xpbWl0ZWQodTY0ICpyZXN1 bHQsIGNvbnN0IHU2NCAqaW5wdXQpCj4gIAlyZXR1cm4gcmVzdWx0Owo+ICB9Cj4gIAo+IC1zdGF0 aWMgdm9pZCBpbGtfbG9hZF95Y2Jjcl9jb252ZXJzaW9uX21hdHJpeChzdHJ1Y3QgaW50ZWxfY3J0 YyAqaW50ZWxfY3J0YykKPiArc3RhdGljIHZvaWQgaWxrX2xvYWRfeWNiY3JfY29udmVyc2lvbl9t YXRyaXgoc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQoKSXQncyBnZW5lcmFsbHkg cHJlZmVycmVkIHRvIHVzZSBJbnRlbCB0eXBlcyBmb3IgdGhlc2UgbG93ZXItbGV2ZWwKZnVuY3Rp b25zIHJhdGhlciB0aGFuIERSTSB0eXBlcy4gIEl0IGxvb2tzIGxpa2UgYSBsb3Qgb2YgdGhlIHBy ZWV4aXN0aW5nCmNvbG9yIG1hbmFnZW1lbnQgY29kZSBicmVha3MgZnJvbSB0aGlzIGNvbnZlbnRp b24sIHNvIHdlIG1pZ2h0IHdhbnQgdG8KYWxzbyBjbGVhbiB0aGF0IHVwIGluIHRoZSBwcmVleGlz dGluZyBjb2RlIGFzIGEgc2VwYXJhdGUgcGF0Y2guCgoKPiAgewo+ICsJc3RydWN0IGRybV9jcnRj ICpjcnRjID0gY3J0Y19zdGF0ZS0+Y3J0YzsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+ZGV2KTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRl bF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjKTsKPiAgCWludCBwaXBlID0gaW50ZWxfY3J0Yy0+ cGlwZTsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoaW50 ZWxfY3J0Yy0+YmFzZS5kZXYpOwo+ICsJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmludGVsX2Ny dGNfc3RhdGUgPQo+ICsJCQkJCXRvX2ludGVsX2NydGNfc3RhdGUoY3J0Y19zdGF0ZSk7Cj4gIAo+ ICAJSTkxNV9XUklURShQSVBFX0NTQ19QUkVPRkZfSEkocGlwZSksIDApOwo+ICAJSTkxNV9XUklU RShQSVBFX0NTQ19QUkVPRkZfTUUocGlwZSksIDApOwo+IEBAIC0xMjksNyArMTMzLDExIEBAIHN0 YXRpYyB2b2lkIGlsa19sb2FkX3ljYmNyX2NvbnZlcnNpb25fbWF0cml4KHN0cnVjdCBpbnRlbF9j cnRjICppbnRlbF9jcnRjKQo+ICAJSTkxNV9XUklURShQSVBFX0NTQ19QT1NUT0ZGX0hJKHBpcGUp LCBQT1NUT0ZGX1JHQl9UT19ZVVZfSEkpOwo+ICAJSTkxNV9XUklURShQSVBFX0NTQ19QT1NUT0ZG X01FKHBpcGUpLCBQT1NUT0ZGX1JHQl9UT19ZVVZfTUUpOwo+ICAJSTkxNV9XUklURShQSVBFX0NT Q19QT1NUT0ZGX0xPKHBpcGUpLCBQT1NUT0ZGX1JHQl9UT19ZVVZfTE8pOwo+IC0JSTkxNV9XUklU RShQSVBFX0NTQ19NT0RFKHBpcGUpLCAwKTsKPiArCj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2 KSA+PSAxMSkKPiArCQlpbnRlbF9jcnRjX3N0YXRlLT5jc2NfbW9kZSB8PSAgQ1NDX0VOQUJMRTsK ClNob3VsZG4ndCBmaXhlZCBSR0ItPllVViBiZSBkb25lIHdpdGggT1VUUFVUX0NTQ19FTkFCTEUg bm93IHRoYXQgd2UgaGF2ZQp0d28gQ1NDJ3MgdG8gd29yayB3aXRoIGluc3RlYWQgb2YganVzdCBv bmU/ICBJLmUuLCBJIHRoaW5rIHdlIGNhbiBsZWF2ZQp0aGUgZmlyc3QgcGlwZSBDU0MgZm9yIHRo ZSB1c2Vyc3BhY2UtZGVmaW5lZCB0cmFuc2Zvcm1hdGlvbiAob3IgaWRlbnRpdHkKaWYgbm9uZSBp cyBwcm92aWRlZCkgYW5kIHRoZW4gZW5hYmxlIHRoZSBvdXRwdXQgQ1NDIGlmIHdlIG5lZWQgdG8K Y29udmVydCB0byBZVVYgYW5kL29yIGNvbXByZXNzIHRvIGxpbWl0ZWQgcmFuZ2UuCgoKTWF0dAoK PiArCWVsc2UKPiArCQlpbnRlbF9jcnRjX3N0YXRlLT5jc2NfbW9kZSA9IDA7Cj4gIH0KPiAgCj4g IHN0YXRpYyB2b2lkIGlsa19sb2FkX2NzY19tYXRyaXgoc3RydWN0IGRybV9jcnRjX3N0YXRlICpj cnRjX3N0YXRlKQo+IEBAIC0xNTEsNyArMTU5LDcgQEAgc3RhdGljIHZvaWQgaWxrX2xvYWRfY3Nj X21hdHJpeChzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAo+ICAJaWYgKGlu dGVsX2NydGNfc3RhdGUtPm91dHB1dF9mb3JtYXQgPT0gSU5URUxfT1VUUFVUX0ZPUk1BVF9ZQ0JD UjQyMCB8fAo+ICAJICAgIGludGVsX2NydGNfc3RhdGUtPm91dHB1dF9mb3JtYXQgPT0gSU5URUxf T1VUUFVUX0ZPUk1BVF9ZQ0JDUjQ0NCkgewo+IC0JCWlsa19sb2FkX3ljYmNyX2NvbnZlcnNpb25f bWF0cml4KGludGVsX2NydGMpOwo+ICsJCWlsa19sb2FkX3ljYmNyX2NvbnZlcnNpb25fbWF0cml4 KGNydGNfc3RhdGUpOwo+ICAJCXJldHVybjsKPiAgCX0gZWxzZSBpZiAoY3J0Y19zdGF0ZS0+Y3Rt KSB7Cj4gIAkJc3RydWN0IGRybV9jb2xvcl9jdG0gKmN0bSA9IGNydGNfc3RhdGUtPmN0bS0+ZGF0 YTsKPiBAQCAtMjM5LDcgKzI0NywxMCBAQCBzdGF0aWMgdm9pZCBpbGtfbG9hZF9jc2NfbWF0cml4 KHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAgCQlJOTE1X1dSSVRFKFBJUEVf Q1NDX1BPU1RPRkZfTUUocGlwZSksIHBvc3RvZmYpOwo+ICAJCUk5MTVfV1JJVEUoUElQRV9DU0Nf UE9TVE9GRl9MTyhwaXBlKSwgcG9zdG9mZik7Cj4gIAo+IC0JCUk5MTVfV1JJVEUoUElQRV9DU0Nf TU9ERShwaXBlKSwgMCk7Cj4gKwkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpCj4gKwkJ CWludGVsX2NydGNfc3RhdGUtPmNzY19tb2RlIHw9ICBDU0NfRU5BQkxFOwo+ICsJCWVsc2UKPiAr CQkJaW50ZWxfY3J0Y19zdGF0ZS0+Y3NjX21vZGUgPSAwOwo+ICAJfSBlbHNlIHsKPiAgCQl1aW50 MzJfdCBtb2RlID0gQ1NDX01PREVfWVVWX1RPX1JHQjsKPiAgCj4gQEAgLTMwNSw5ICszMTYsMTUg QEAgdm9pZCBpbnRlbF9jb2xvcl9zZXRfY3NjKHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19z dGF0ZSkKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGNfc3RhdGUtPmNydGMt PmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2 KTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRj X3N0YXRlLT5jcnRjKTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICppbnRlbF9jcnRjX3N0 YXRlID0KPiArCQkJCXRvX2ludGVsX2NydGNfc3RhdGUoY3J0Y19zdGF0ZSk7Cj4gKwllbnVtIHBp cGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gIAo+ICAJaWYgKGRldl9wcml2LT5kaXNwbGF5 LmxvYWRfY3NjX21hdHJpeCkKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5sb2FkX2NzY19tYXRyaXgo Y3J0Y19zdGF0ZSk7Cj4gKwo+ICsJSTkxNV9XUklURShQSVBFX0NTQ19NT0RFKHBpcGUpLCBpbnRl bF9jcnRjX3N0YXRlLT5jc2NfbW9kZSk7Cj4gIH0KPiAgCj4gIC8qIExvYWRzIHRoZSBsZWdhY3kg cGFsZXR0ZS9nYW1tYSB1bml0IGZvciB0aGUgQ1JUQy4gKi8KPiBAQCAtNzM0LDYgKzc1MSw3IEBA IHZvaWQgaW50ZWxfY29sb3JfaW5pdChzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAkJZGV2X3By aXYtPmRpc3BsYXkubG9hZF9jc2NfbWF0cml4ID0gaWxrX2xvYWRfY3NjX21hdHJpeDsKPiAgCQlk ZXZfcHJpdi0+ZGlzcGxheS5sb2FkX2x1dHMgPSBnbGtfbG9hZF9sdXRzOwo+ICAJfSBlbHNlIGlm IChJU19JQ0VMQUtFKGRldl9wcml2KSkgewo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmxvYWRfY3Nj X21hdHJpeCA9IGlsa19sb2FkX2NzY19tYXRyaXg7Cj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkubG9h ZF9sdXRzID0gaWNsX2xvYWRfbHV0czsKPiAgCX0gZWxzZSB7Cj4gIAkJZGV2X3ByaXYtPmRpc3Bs YXkubG9hZF9sdXRzID0gaTl4eF9sb2FkX2x1dHM7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgK PiBpbmRleCBhNjJkNzdiLi5lN2I3N2MxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgK PiBAQCAtOTIyLDYgKzkyMiw5IEBAIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlIHsKPiAgCS8qIEdh bW1hIG1vZGUgcHJvZ3JhbW1lZCBvbiB0aGUgcGlwZSAqLwo+ICAJdWludDMyX3QgZ2FtbWFfbW9k ZTsKPiAgCj4gKwkvKiBDU0MgbW9kZSBwcm9ncmFtbWVkIG9uIHRoZSBwaXBlICovCj4gKwl1aW50 MzJfdCBjc2NfbW9kZTsKPiArCj4gIAkvKiBiaXRtYXNrIG9mIHZpc2libGUgcGxhbmVzIChlbnVt IHBsYW5lX2lkKSAqLwo+ICAJdTggYWN0aXZlX3BsYW5lczsKPiAgCXU4IG52MTJfcGxhbmVzOwo+ IC0tIAo+IDEuOS4xCj4gCgotLSAKTWF0dCBSb3BlcgpHcmFwaGljcyBTb2Z0d2FyZSBFbmdpbmVl cgpJb1RHIFBsYXRmb3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKSW50ZWwgQ29ycG9yYXRpb24K KDkxNikgMzU2LTI3OTUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==