From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FE7C04EB8 for ; Fri, 30 Nov 2018 19:55:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD6FB20868 for ; Fri, 30 Nov 2018 19:55:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZM5gUpHL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD6FB20868 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726624AbeLAHGE (ORCPT ); Sat, 1 Dec 2018 02:06:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:41870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbeLAHGE (ORCPT ); Sat, 1 Dec 2018 02:06:04 -0500 Received: from quaco.ghostprotocols.net (unknown [179.97.41.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57F812082F; Fri, 30 Nov 2018 19:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543607741; bh=ltdHhn9f2KkmrteF+jnUT3z4WErsClXVAYepYf39N4Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZM5gUpHLwFVyFyGjibMKAOE7Isezec0k+9LGZELzdvwpwuiD1qBctlVEpzuC4lu8c ZQ2OAUpCgnS1gfqMmHEY9YFkuIyKKMKN2zMcYgt22ip36mCGPXrF8eJ4QVdtmfrXg9 dtbTVJqRwMzqjadGSxUBDAGTo+MpJ1oyENBHYICg= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 8793B40BF1; Fri, 30 Nov 2018 16:55:39 -0300 (-03) Date: Fri, 30 Nov 2018 16:55:39 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Jiri Olsa , Namhyung Kim , Andrew Morton , Tzvetomir Stoyanov Subject: Re: [PATCH 7/9] tools/lib/traceevent: traceevent API cleanup Message-ID: <20181130195539.GF19230@kernel.org> References: <20181130154403.150474900@goodmis.org> <20181130154647.891651290@goodmis.org> <20181130191856.GC19230@kernel.org> <20181130143736.7b3fbd5f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181130143736.7b3fbd5f@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Nov 30, 2018 at 02:37:36PM -0500, Steven Rostedt escreveu: > On Fri, 30 Nov 2018 16:18:56 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Fri, Nov 30, 2018 at 10:44:10AM -0500, Steven Rostedt escreveu: > > > From: Tzvetomir Stoyanov > > > > > > In order to make libtraceevent into a proper library, its API > > > should be straightforward. This patch hides few API functions, > > > intended for internal usage only: > > > tep_free_event(), tep_free_format_field(), __tep_data2host2(), > > > __tep_data2host4() and __tep_data2host8(). > > > The patch also alignes the libtraceevent summary man page with > > > these API changes. > > > > I applied the previous patches, stopped here as it this one fails with > > the error bellow. > > Thanks, I'll take a look at it. > > What branch are you applying it against? Just to make sure I'm testing > the same thing you are. These are for next release, so perf/core, but I haven't pushed out what I have, have to test it over the containers before that, will kick that now so that I can push it externally. Will let you know when done. - Arnaldo > -- Steve > > > > > Please resend from this patch onwards. > > > > BTW, this is what I have right now: > > > > [acme@quaco perf]$ git log --oneline - 6 > > 9db9efe53c72 (HEAD -> perf/core) tools lib traceevent: Rename tep_free_format() to tep_free_event() > > e58c351e8383 tools lib traceevent, perf tools: Rename 'struct tep_event_format' to 'struct tep_event' > > 4237fd0b60d8 tools lib traceevent: Install trace-seq.h API header file > > bb837f2581dc tools lib traceevent: Added support for pkg-config > > a2c167ad70b6 tools lib traceevent: Implement new API tep_get_ref() > > 51d0337d0198 (acme.korg/perf/core) tools lib traceevent: Add sanity check to is_timestamp_in_us() > > -- - Arnaldo