From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Date: Fri, 30 Nov 2018 13:07:39 -0800 Message-ID: <20181130210739.GD22338@linux.intel.com> References: <20181130192737.15053-1-jarkko.sakkinen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kees Cook Cc: Linux MIPS Mailing List , Geert Uytterhoeven , "open list:DOCUMENTATION" , nouveau , Amir Goldstein , Dominik Brodowski , linux-ide@vger.kernel.org, Eric Dumazet , Linux mtd , makita.toshiaki@lab.ntt.co.jp, yanjun.zhu@oracle.com, linux-scsi@vger.kernel.org, Jonathan Corbet , Helge Deller , federico.vaga@vaga.pv.it, Yonghong Song , Paolo Abeni , Linux Media Mailing List , Petr Mladek , Linux PM list , shannon.nelson@oracle.com, sean.wang@mediatek.com, Steven Rostedt , Stefano Brivio linux-m List-Id: linux-ide@vger.kernel.org T24gRnJpLCBOb3YgMzAsIDIwMTggYXQgMTE6NDA6MTdBTSAtMDgwMCwgS2VlcyBDb29rIHdyb3Rl Ogo+IE9uIEZyaSwgTm92IDMwLCAyMDE4IGF0IDExOjI3IEFNIEphcmtrbyBTYWtraW5lbgo+IDxq YXJra28uc2Fra2luZW5AbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+Cj4gPiBJbiBvcmRlciB0 byBjb21wbHkgd2l0aCB0aGUgQ29DLCByZXBsYWNlICoqKiogd2l0aCBhIGh1Zy4KPiAKPiBIZWgu IEkgc3VwcG9ydCB0aGUgcmVwbGFjZW1lbnQgb2YgdGhlIHN0cm9uZ2VyIGxhbmd1YWdlLCBidXQg SSBmaW5kCj4gImh1ZyIsICJodWdnZWQiLCBhbmQgImh1Z2dpbmciIHRvIGJlIHZlcnkgd2VpcmQg cmVwbGFjZW1lbnRzLiBDYW4gd2UKPiBiaWtlc2hlZCB0aGlzIHRvICJoZWNrIiwgImhlY2tlZCIs IGFuZCAiaGVja2luZyIgKG9yICJoZWNraW4iIHRvCj4gZm9sbG93IHRydWUgRG9nZ28gbWVtZSBz dHlsZSkuCj4gCj4gIlRoaXMgQVBJIGlzIGh1Z2dlZCIgZG9lc24ndCBtYWtlIGFueSBzZW5zZSB0 byBtZS4gIlRoaXMgQVBJIGlzCj4gaGVja2VkIiBpcyBiZXR0ZXIsIG9yIGF0IGxlYXN0IGZ1bm5p ZXIgKHRvIG1lKS4gIkh1ZyB0aGlzIGludGVyZmFjZSIKPiBzaW1pbGFybHkgbWFrZXMgbm8gc2Vu c2UsIGJ1dCAiSGVjayB0aGlzIGludGVyZmFjZSIgc2VlbXMgYmV0dGVyLgo+ICJEb24ndCB0b3Vj aCBteSBoZWNraW5nIGNvZGUiLCAiV2hhdCB0aGUgaGVjayB3ZXJlIHRoZXkgdGhpbmtpbmc/Igo+ IGV0Yy4uLiAiaHVnIiBpcyBvZGQuCj4gCj4gQmV0dGVyIHlldCwgc2luY2UgaXQncyBvbmx5IDE3 IGZpbGVzLCBob3cgYWJvdXQgZG9pbmcgY29udGV4dC1zcGVjaWZpYwo+IGNoYW5nZXM/ICJUaGlz IEFQSSBpcyB0ZXJyaWJsZSIsICJIYXRlZnVsIGludGVyZmFjZSIsICJEb24ndCB0b3VjaCBteQo+ IGZyZWFraW4nIGNvZGUiLCAiV2hhdCBpbiB0aGUgd29ybGQgd2VyZSB0aGV5IHRoaW5raW5nPyIg ZXRjPwoKSSdtIGhhcHB5IHRvIHJlZmluZSB0aGlzICh0aHVzIHRoZSBSRkMgdGFnKSEgQW5kIGRl cGVuZGluZyBvbiB0aGUKY3VsdHVyZSwgaHVnZ2luZyBjb3VsZCBmYWxsIGluIHRoZSBoYXJyYXNt ZW50IGNhdGVnb3J5LiBBY3R1YWxseSwgd2hlbiBJCnRoaW5rIGFib3V0IGl0LCBpbiBGaW5sYW5k IHRoaXMga2luZCBvZiBwb2tpbmcgb2Ygb25lcyBwZXJzb25hbCBidWJibGUKd291bGQgYmUgc3Vj aCA6LSkKCkknbGwgcmVmaW5lIHRoZSBwYXRjaCBzZXQgd2l0aCBtb3JlIGNvbnRleHQgc2Vuc2l0 aXZlIHJlcGxhY2VtZW50cywKcGVyaGFwcyByZW1vdmluZyB0aGUgY29tbWVudCBhbHRvZ2V0aGVy IGluIHNvbWUgcGxhY2VzLiBUaGFuayB5b3UgZm9yCnRoZSBmZWVkYmFjayEKCi9KYXJra28KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A97C8C04EB8 for ; Fri, 30 Nov 2018 21:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7705E20660 for ; Fri, 30 Nov 2018 21:07:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7705E20660 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-parisc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726746AbeLAISQ (ORCPT ); Sat, 1 Dec 2018 03:18:16 -0500 Received: from mga02.intel.com ([134.134.136.20]:20447 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbeLAISQ (ORCPT ); Sat, 1 Dec 2018 03:18:16 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2018 13:07:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,299,1539673200"; d="scan'208";a="121033317" Received: from jsakkine-mobl1.jf.intel.com (HELO localhost) ([10.241.225.27]) by fmsmga001.fm.intel.com with ESMTP; 30 Nov 2018 13:07:39 -0800 Date: Fri, 30 Nov 2018 13:07:39 -0800 From: Jarkko Sakkinen To: Kees Cook Cc: LKML , Amir Goldstein , Andrew Morton , Andy Shevchenko , Daniel Axtens , "David S. Miller" , Dominik Brodowski , Maling list - DRI developers , Eric Dumazet , federico.vaga@vaga.pv.it, Geert Uytterhoeven , Helge Deller , Jonathan Corbet , Joshua Kinard , "open list:DOCUMENTATION" , "linux-fsdevel@vger.kernel.org" , linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Linux Media Mailing List , Linux MIPS Mailing List , Linux mtd , linux-parisc , Linux PM list , linux-scsi@vger.kernel.org, matthias.bgg@gmail.com, Network Development , nouveau , Paolo Abeni , Paul Burton , Petr Mladek , Rob Herring , sean.wang@mediatek.com, Sergey Senozhatsky , shannon.nelson@oracle.com, Stefano Brivio , Steven Rostedt , "Tobin C. Harding" , makita.toshiaki@lab.ntt.co.jp, Willem de Bruijn , Yonghong Song , yanjun.zhu@oracle.com Subject: Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Message-ID: <20181130210739.GD22338@linux.intel.com> References: <20181130192737.15053-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Fri, Nov 30, 2018 at 11:40:17AM -0800, Kees Cook wrote: > On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen > wrote: > > > > In order to comply with the CoC, replace **** with a hug. > > Heh. I support the replacement of the stronger language, but I find > "hug", "hugged", and "hugging" to be very weird replacements. Can we > bikeshed this to "heck", "hecked", and "hecking" (or "heckin" to > follow true Doggo meme style). > > "This API is hugged" doesn't make any sense to me. "This API is > hecked" is better, or at least funnier (to me). "Hug this interface" > similarly makes no sense, but "Heck this interface" seems better. > "Don't touch my hecking code", "What the heck were they thinking?" > etc... "hug" is odd. > > Better yet, since it's only 17 files, how about doing context-specific > changes? "This API is terrible", "Hateful interface", "Don't touch my > freakin' code", "What in the world were they thinking?" etc? I'm happy to refine this (thus the RFC tag)! And depending on the culture, hugging could fall in the harrasment category. Actually, when I think about it, in Finland this kind of poking of ones personal bubble would be such :-) I'll refine the patch set with more context sensitive replacements, perhaps removing the comment altogether in some places. Thank you for the feedback! /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Date: Fri, 30 Nov 2018 13:07:39 -0800 Message-ID: <20181130210739.GD22338@linux.intel.com> References: <20181130192737.15053-1-jarkko.sakkinen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Linux MIPS Mailing List , Geert Uytterhoeven , "open list:DOCUMENTATION" , nouveau , Amir Goldstein , Dominik Brodowski , linux-ide@vger.kernel.org, Eric Dumazet , Linux mtd , makita.toshiaki@lab.ntt.co.jp, yanjun.zhu@oracle.com, linux-scsi@vger.kernel.org, Jonathan Corbet , Helge Deller , federico.vaga@vaga.pv.it, Yonghong Song , Paolo Abeni , Linux Media Mailing List , Petr Mladek , Linux PM list , shannon.nelson@oracle.com, sean.wang@mediatek.com, Steven Rostedt , Stefano Brivio , linux-m To: Kees Cook Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" List-Id: netdev.vger.kernel.org T24gRnJpLCBOb3YgMzAsIDIwMTggYXQgMTE6NDA6MTdBTSAtMDgwMCwgS2VlcyBDb29rIHdyb3Rl Ogo+IE9uIEZyaSwgTm92IDMwLCAyMDE4IGF0IDExOjI3IEFNIEphcmtrbyBTYWtraW5lbgo+IDxq YXJra28uc2Fra2luZW5AbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+Cj4gPiBJbiBvcmRlciB0 byBjb21wbHkgd2l0aCB0aGUgQ29DLCByZXBsYWNlICoqKiogd2l0aCBhIGh1Zy4KPiAKPiBIZWgu IEkgc3VwcG9ydCB0aGUgcmVwbGFjZW1lbnQgb2YgdGhlIHN0cm9uZ2VyIGxhbmd1YWdlLCBidXQg SSBmaW5kCj4gImh1ZyIsICJodWdnZWQiLCBhbmQgImh1Z2dpbmciIHRvIGJlIHZlcnkgd2VpcmQg cmVwbGFjZW1lbnRzLiBDYW4gd2UKPiBiaWtlc2hlZCB0aGlzIHRvICJoZWNrIiwgImhlY2tlZCIs IGFuZCAiaGVja2luZyIgKG9yICJoZWNraW4iIHRvCj4gZm9sbG93IHRydWUgRG9nZ28gbWVtZSBz dHlsZSkuCj4gCj4gIlRoaXMgQVBJIGlzIGh1Z2dlZCIgZG9lc24ndCBtYWtlIGFueSBzZW5zZSB0 byBtZS4gIlRoaXMgQVBJIGlzCj4gaGVja2VkIiBpcyBiZXR0ZXIsIG9yIGF0IGxlYXN0IGZ1bm5p ZXIgKHRvIG1lKS4gIkh1ZyB0aGlzIGludGVyZmFjZSIKPiBzaW1pbGFybHkgbWFrZXMgbm8gc2Vu c2UsIGJ1dCAiSGVjayB0aGlzIGludGVyZmFjZSIgc2VlbXMgYmV0dGVyLgo+ICJEb24ndCB0b3Vj aCBteSBoZWNraW5nIGNvZGUiLCAiV2hhdCB0aGUgaGVjayB3ZXJlIHRoZXkgdGhpbmtpbmc/Igo+ IGV0Yy4uLiAiaHVnIiBpcyBvZGQuCj4gCj4gQmV0dGVyIHlldCwgc2luY2UgaXQncyBvbmx5IDE3 IGZpbGVzLCBob3cgYWJvdXQgZG9pbmcgY29udGV4dC1zcGVjaWZpYwo+IGNoYW5nZXM/ICJUaGlz IEFQSSBpcyB0ZXJyaWJsZSIsICJIYXRlZnVsIGludGVyZmFjZSIsICJEb24ndCB0b3VjaCBteQo+ IGZyZWFraW4nIGNvZGUiLCAiV2hhdCBpbiB0aGUgd29ybGQgd2VyZSB0aGV5IHRoaW5raW5nPyIg ZXRjPwoKSSdtIGhhcHB5IHRvIHJlZmluZSB0aGlzICh0aHVzIHRoZSBSRkMgdGFnKSEgQW5kIGRl cGVuZGluZyBvbiB0aGUKY3VsdHVyZSwgaHVnZ2luZyBjb3VsZCBmYWxsIGluIHRoZSBoYXJyYXNt ZW50IGNhdGVnb3J5LiBBY3R1YWxseSwgd2hlbiBJCnRoaW5rIGFib3V0IGl0LCBpbiBGaW5sYW5k IHRoaXMga2luZCBvZiBwb2tpbmcgb2Ygb25lcyBwZXJzb25hbCBidWJibGUKd291bGQgYmUgc3Vj aCA6LSkKCkknbGwgcmVmaW5lIHRoZSBwYXRjaCBzZXQgd2l0aCBtb3JlIGNvbnRleHQgc2Vuc2l0 aXZlIHJlcGxhY2VtZW50cywKcGVyaGFwcyByZW1vdmluZyB0aGUgY29tbWVudCBhbHRvZ2V0aGVy IGluIHNvbWUgcGxhY2VzLiBUaGFuayB5b3UgZm9yCnRoZSBmZWVkYmFjayEKCi9KYXJra28KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga02.intel.com ([134.134.136.20]:20447 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbeLAISQ (ORCPT ); Sat, 1 Dec 2018 03:18:16 -0500 Date: Fri, 30 Nov 2018 13:07:39 -0800 From: Jarkko Sakkinen To: Kees Cook Cc: LKML , Amir Goldstein , Andrew Morton , Andy Shevchenko , Daniel Axtens , "David S. Miller" , Dominik Brodowski , Maling list - DRI developers , Eric Dumazet , federico.vaga@vaga.pv.it, Geert Uytterhoeven , Helge Deller , Jonathan Corbet , Joshua Kinard , "open list:DOCUMENTATION" , "linux-fsdevel@vger.kernel.org" , linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Linux Media Mailing List , Linux MIPS Mailing List , Linux mtd , linux-parisc , Linux PM list , linux-scsi@vger.kernel.org, matthias.bgg@gmail.com, Network Development , nouveau , Paolo Abeni , Paul Burton , Petr Mladek , Rob Herring , sean.wang@mediatek.com, Sergey Senozhatsky , shannon.nelson@oracle.com, Stefano Brivio , Steven Rostedt , "Tobin C. Harding" , makita.toshiaki@lab.ntt.co.jp, Willem de Bruijn , Yonghong Song , yanjun.zhu@oracle.com Subject: Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Message-ID: <20181130210739.GD22338@linux.intel.com> References: <20181130192737.15053-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, Nov 30, 2018 at 11:40:17AM -0800, Kees Cook wrote: > On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen > wrote: > > > > In order to comply with the CoC, replace **** with a hug. > > Heh. I support the replacement of the stronger language, but I find > "hug", "hugged", and "hugging" to be very weird replacements. Can we > bikeshed this to "heck", "hecked", and "hecking" (or "heckin" to > follow true Doggo meme style). > > "This API is hugged" doesn't make any sense to me. "This API is > hecked" is better, or at least funnier (to me). "Hug this interface" > similarly makes no sense, but "Heck this interface" seems better. > "Don't touch my hecking code", "What the heck were they thinking?" > etc... "hug" is odd. > > Better yet, since it's only 17 files, how about doing context-specific > changes? "This API is terrible", "Hateful interface", "Don't touch my > freakin' code", "What in the world were they thinking?" etc? I'm happy to refine this (thus the RFC tag)! And depending on the culture, hugging could fall in the harrasment category. Actually, when I think about it, in Finland this kind of poking of ones personal bubble would be such :-) I'll refine the patch set with more context sensitive replacements, perhaps removing the comment altogether in some places. Thank you for the feedback! /Jarkko